From 88428b7a93347efc51be015cc12cb71fab3976a3 Mon Sep 17 00:00:00 2001 From: Gonglei Date: Fri, 30 Jan 2015 10:14:34 +0800 Subject: [PATCH] vnc: fix qemu crash when not configure vnc option Add missing vnc options: to, ipv4, ipv6 and fix qemu crash. Reproducer: $ x86_64-softmmu/qemu-system-x86_64 qemu-system-x86_64: Invalid parameter 'to' Segmentation fault (core dumped) BTW the patch fix the below bug: https://bugs.launchpad.net/qemu/+bug/1414222 Signed-off-by: Gonglei Reviewed-by: Don Slutz Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/ui/vnc.c b/ui/vnc.c index 02552ee27b..90e8a882e3 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3271,6 +3271,15 @@ static QemuOptsList qemu_vnc_opts = { },{ .name = "connections", .type = QEMU_OPT_NUMBER, + },{ + .name = "to", + .type = QEMU_OPT_NUMBER, + },{ + .name = "ipv4", + .type = QEMU_OPT_BOOL, + },{ + .name = "ipv6", + .type = QEMU_OPT_BOOL, },{ .name = "password", .type = QEMU_OPT_BOOL,