xemu-project/xemu
1
0
Fork 0
mirror of https://github.com/xemu-project/xemu.git synced 2024-11-23 19:49:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

hw/fmopl: Fix buffer access out-of-bounds errors

Browse Source 
Index 75 is one too large for AR_TABLE[75], DR_TABLE[75].
This error was reported by cppcheck.

hw/fmopl.c:600: error: Buffer access out-of-bounds: OPL.AR_TABLE
hw/fmopl.c:601: error: Buffer access out-of-bounds: OPL.DR_TABLE

Fix this by limiting the access to the allowed range.
MultiArcadeMachineEmulator has newer versions of fmopl,
but using these requires more efforts.

Cc: Blue Swirl <blauwirbel@gmail.com>
Reviewed-by: malc <av1474@comtv.ru>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
This commit is contained in:
Stefan Weil 2011-03-12 17:43:56 +01:00 committed by Blue Swirl
parent 7165448a91
commit 913895ab96
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hw/fmopl.c
View File

@ -45,6 +45,10 @@
#define PI 3.14159265358979323846 #define PI 3.14159265358979323846
#endif #endif
#ifndef ARRAY_SIZE
#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
#endif
/* -------------------- for debug --------------------- */ /* -------------------- for debug --------------------- */
/* #define OPL_OUTPUT_LOG */ /* #define OPL_OUTPUT_LOG */
#ifdef OPL_OUTPUT_LOG #ifdef OPL_OUTPUT_LOG
@ -595,7 +599,7 @@ static void init_timetables( FM_OPL *OPL , int ARRATE , int DRRATE )
OPL->AR_TABLE[i] = rate / ARRATE; OPL->AR_TABLE[i] = rate / ARRATE;
OPL->DR_TABLE[i] = rate / DRRATE; OPL->DR_TABLE[i] = rate / DRRATE;
} }
for (i = 60;i < 76;i++) for (i = 60; i < ARRAY_SIZE(OPL->AR_TABLE); i++)
{ {
OPL->AR_TABLE[i] = EG_AED-1; OPL->AR_TABLE[i] = EG_AED-1;
OPL->DR_TABLE[i] = OPL->DR_TABLE[60]; OPL->DR_TABLE[i] = OPL->DR_TABLE[60];