xemu-project/xemu
1
0
Fork 0
mirror of https://github.com/xemu-project/xemu.git synced 2025-02-08 05:07:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Correctly free nd structure

Browse Source 
When we "free" a NICInfo structure, we can leak pointers, since we don't do
much more than setting used = 0.

We free() the model parameter, but we don't set it to NULL. This means that
a new user of this structure will see garbage in there. It was not noticed
before because reusing a NICInfo is not that common, but it can be, for
users of device pci hotplug.

A user hit it, described at https://bugzilla.redhat.com/show_bug.cgi?id=524022

This patch memset's the whole structure, guaranteeing that anyone reusing it
will see a fresh NICinfo. Also, we free some other strings that are currently
leaking.

This codebase is quite old, so this patch should feed all stable trees.

Signed-off-by: Glauber Costa <glommer@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Glauber Costa 2009-09-17 16:53:39 -04:00 committed by Anthony Liguori
parent e5bc201df7
commit a979670344
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
net.c
View File

@ -2803,8 +2803,13 @@ void net_client_uninit(NICInfo *nd)
{
nd->vlan->nb_guest_devs--;
nb_nics--;
nd->used = 0;
free((void *)nd->model);
qemu_free((void *)nd->model);
qemu_free((void *)nd->name);
qemu_free((void *)nd->devaddr);
qemu_free((void *)nd->id);
memset(nd, 0, sizeof(*nd));
}
static int net_host_check_device(const char *device)