xemu-project/xemu
1
0
Fork 0
mirror of https://github.com/xemu-project/xemu.git synced 2024-11-24 12:09:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

qemu-char: correct return value from chr_read functions

Browse Source 
Even if a CharDriverState's source is blocked by the front-end,
it must not be dropped. The IOWatchPoll that wraps it will take
care of adding and removing it to the main loop.  Only remove
the source when the channel is closed; and in that case, make sure
that the wrapping IOWatchPoll is removed too.

These should just be theoretical bugs.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 1366385529-10329-4-git-send-email-pbonzini@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Paolo Bonzini 2013-04-19 17:32:08 +02:00 committed by Anthony Liguori
parent 85a67692d0
commit cdbf6e1659
1 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
qemu-char.c
View File

@ -781,12 +781,16 @@ static gboolean fd_chr_read(GIOChannel *chan, GIOCondition cond, void *opaque)
len = s->max_size; len = s->max_size;
} }
if (len == 0) { if (len == 0) {
return FALSE; return TRUE;
} }
status = g_io_channel_read_chars(chan, (gchar *)buf, status = g_io_channel_read_chars(chan, (gchar *)buf,
len, &bytes_read, NULL); len, &bytes_read, NULL);
if (status == G_IO_STATUS_EOF) { if (status == G_IO_STATUS_EOF) {
if (s->fd_in_tag) {
g_source_remove(s->fd_in_tag);
s->fd_in_tag = 0;
}
qemu_chr_be_event(chr, CHR_EVENT_CLOSED); qemu_chr_be_event(chr, CHR_EVENT_CLOSED);
return FALSE; return FALSE;
} }
@ -1105,8 +1109,9 @@ static gboolean pty_chr_read(GIOChannel *chan, GIOCondition cond, void *opaque)
len = sizeof(buf); len = sizeof(buf);
if (len > s->read_bytes) if (len > s->read_bytes)
len = s->read_bytes; len = s->read_bytes;
if (len == 0) if (len == 0) {
return FALSE; return TRUE;
}
status = g_io_channel_read_chars(s->fd, (gchar *)buf, len, &size, NULL); status = g_io_channel_read_chars(s->fd, (gchar *)buf, len, &size, NULL);
if (status != G_IO_STATUS_NORMAL) { if (status != G_IO_STATUS_NORMAL) {
pty_chr_state(chr, 0); pty_chr_state(chr, 0);
@ -2238,13 +2243,18 @@ static gboolean udp_chr_read(GIOChannel *chan, GIOCondition cond, void *opaque)
gsize bytes_read = 0; gsize bytes_read = 0;
GIOStatus status; GIOStatus status;
if (s->max_size == 0) if (s->max_size == 0) {
return FALSE; return TRUE;
}
status = g_io_channel_read_chars(s->chan, (gchar *)s->buf, sizeof(s->buf), status = g_io_channel_read_chars(s->chan, (gchar *)s->buf, sizeof(s->buf),
&bytes_read, NULL); &bytes_read, NULL);
s->bufcnt = bytes_read; s->bufcnt = bytes_read;
s->bufptr = s->bufcnt; s->bufptr = s->bufcnt;
if (status != G_IO_STATUS_NORMAL) { if (status != G_IO_STATUS_NORMAL) {
if (s->tag) {
g_source_remove(s->tag);
s->tag = 0;
}
return FALSE; return FALSE;
} }
@ -2497,7 +2507,7 @@ static gboolean tcp_chr_read(GIOChannel *chan, GIOCondition cond, void *opaque)
int len, size; int len, size;
if (!s->connected || s->max_size <= 0) { if (!s->connected || s->max_size <= 0) {
return FALSE; return TRUE;
} }
len = sizeof(buf); len = sizeof(buf);
if (len > s->max_size) if (len > s->max_size)