xemu-project/xemu
1
0
Fork 0
mirror of https://github.com/xemu-project/xemu.git synced 2024-11-24 03:59:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

linux-user: fix openat

Browse Source 
When running openat using qemu-arm, we stumbled over invalid permissions
on the created files. The reason for this is that the mode parameter gets
treates as an O_... flag, which it isn't - it's a permission bitmask.

This patch removes the needless translation of the mode parameter,
rendering permission passing of openat() to work with linux-user.

Reported-by: Dirk Mueller <dmueller@suse.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
This commit is contained in:
Alexander Graf 2011-09-25 06:25:35 +02:00 committed by Riku Voipio
parent cbb21eed18
commit f4c690101c
1 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
linux-user/syscall.c
View File

@ -379,25 +379,13 @@ static int sys_mknodat(int dirfd, const char *pathname, mode_t mode,
} }
#endif #endif
#ifdef TARGET_NR_openat #ifdef TARGET_NR_openat
static int sys_openat(int dirfd, const char *pathname, int flags, ...) static int sys_openat(int dirfd, const char *pathname, int flags, mode_t mode)
{ {
/* /*
* open(2) has extra parameter 'mode' when called with * open(2) has extra parameter 'mode' when called with
* flag O_CREAT. * flag O_CREAT.
*/ */
if ((flags & O_CREAT) != 0) { if ((flags & O_CREAT) != 0) {
va_list ap;
mode_t mode;
/*
* Get the 'mode' parameter and translate it to
* host bits.
*/
va_start(ap, flags);
mode = va_arg(ap, mode_t);
mode = target_to_host_bitmask(mode, fcntl_flags_tbl);
va_end(ap);
return (openat(dirfd, pathname, flags, mode)); return (openat(dirfd, pathname, flags, mode));
} }
return (openat(dirfd, pathname, flags)); return (openat(dirfd, pathname, flags));