Thomas Huth 03fcbd9dc5 qdev: Check for the availability of a hotplug controller before adding a device ... The qdev_unplug() function contains a g_assert(hotplug_ctrl) statement, so QEMU crashes when the user tries to device_add + device_del a device that does not have a corresponding hotplug controller. This could be provoked for a couple of devices in the past (see commit 4c93950659 or 84ebd3e8c7 for example), and can currently for example also be triggered like this: $ s390x-softmmu/qemu-system-s390x -M none -nographic QEMU 2.10.50 monitor - type 'help' for more information (qemu) device_add qemu-s390x-cpu,id=x (qemu) device_del x ** ERROR:qemu/qdev-monitor.c:872:qdev_unplug: assertion failed: (hotplug_ctrl) Aborted (core dumped) So devices clearly need a hotplug controller when they should be usable with device_add. The code in qdev_device_add() already checks whether the bus has a proper hotplug controller, but for devices that do not have a corresponding bus, there is no appropriate check available yet. In that case we should check whether the machine itself provides a suitable hotplug controller and refuse to plug the device if none is available. Reviewed-by: Igor Mammedov <imammedo@redhat.com> Signed-off-by: Thomas Huth <thuth@redhat.com> Message-Id: <1509617407-21191-3-git-send-email-thuth@redhat.com> Reviewed-by: Cornelia Huck <cohuck@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>		2018-01-19 11:18:51 -02:00
..
block	nbd: rename nbd_option and nbd_opt_reply	2018-01-10 12:11:23 -06:00
chardev	chardev: introduce qemu_chr_timeout_add_ms()	2018-01-12 13:22:02 +01:00
crypto
disas	target/xtensa: implement disassembler	2018-01-09 09:55:39 -08:00
exec	cpu_physical_memory_sync_dirty_bitmap: Another alignment fix	2018-01-16 14:54:52 +01:00
fpu
hw	qdev: Check for the availability of a hotplug controller before adding a device	2018-01-19 11:18:51 -02:00
io	io: introduce a network socket listener API	2017-12-15 15:07:26 +00:00
libdecnumber
migration	migration: finalize current_migration object	2018-01-15 12:48:05 +01:00
monitor
net	net: Remove the legacy "-net channel" parameter	2017-12-22 10:05:26 +08:00
qapi	qapi: Add qobject_is_equal()	2017-11-17 18:21:30 +01:00
qemu	memfd: split qemu_memfd_alloc()	2018-01-19 11:18:51 -02:00
qom	i386: hvf: add code base from Google's QEMU repository	2017-12-22 15:01:20 +01:00
scsi	scsi: provide general-purpose functions to manage sense data	2017-12-21 09:30:32 +01:00
standard-headers	linux-headers: update to 4.15-rc1	2017-12-13 17:59:23 +00:00
sysemu	i386: hvf: implement vga dirty page tracking	2017-12-22 15:01:48 +01:00
ui	sdl2: Ignore UI hotkeys after a focus change when GUI modifier is held	2018-01-12 15:51:18 +01:00
elf.h
glib-compat.h
qemu-common.h	Use HTTPS for qemu.org and other domains	2017-11-21 13:34:13 +00:00
qemu-io.h
trace-tcg.h