mirror of
https://github.com/xemu-project/xemu.git
synced 2024-11-25 04:30:02 +00:00
0479097859
QEMU currently crashes when trying to use a 'pc-dimm' on the pseries machine without specifying its 'memdev' property. This happens because pc_dimm_get_memory_region() does not check whether the 'memdev' property has properly been set by the user. Looking closer at this function, it's also obvious that it is using &error_abort to call another function - and this is bad in a function that is used in the hot-plugging calling chain since this can also cause QEMU to exit unexpectedly. So let's fix these issues in a proper way now: Add a "Error **errp" parameter to pc_dimm_get_memory_region() which we use in case the 'memdev' property has not been set by the user, and which we can use instead of the &error_abort, and change the callers of get_memory_region() to make use of this "errp" parameter for proper error checking. Signed-off-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> Signed-off-by: David Gibson <david@gibson.dropbear.id.au> |
||
|---|---|---|
| .. | ||
| kvm | ||
| xen | ||
| acpi-build.c | ||
| acpi-build.h | ||
| amd_iommu.c | ||
| amd_iommu.h | ||
| intel_iommu_internal.h | ||
| intel_iommu.c | ||
| kvmvapic.c | ||
| Makefile.objs | ||
| multiboot.c | ||
| multiboot.h | ||
| pc_piix.c | ||
| pc_q35.c | ||
| pc_sysfw.c | ||
| pc.c | ||
| pci-assign-load-rom.c | ||
| trace-events | ||
| x86-iommu.c | ||