xemu/nbd
Eric Blake 099fbcd65c nbd/server: Don't fail NBD_OPT_INFO for byte-aligned sources
In commit 0c1d50bd, I added a couple of TODO comments about whether we
consult bl.request_alignment when responding to NBD_OPT_INFO. At the
time, qemu as server was hard-coding an advertised alignment of 512 to
clients that promised to obey constraints, and there was no function
for getting at a device's preferred alignment. But in hindsight,
advertising 512 when the block device prefers 1 caused other
compliance problems, and commit b0245d64 changed one of the two TODO
comments to advertise a more accurate alignment. Time to fix the other
TODO.  Doesn't really impact qemu as client (our normal client doesn't
use NBD_OPT_INFO, and qemu-nbd --list promises to obey block sizes),
but it might prove useful to other clients.

Fixes: b0245d64
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20190403030526.12258-4-eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
2019-04-08 13:49:25 -05:00
..
client.c nbd/client: Reject inaccessible tail of inconsistent server 2019-04-01 08:31:16 -05:00
common.c nbd: generalize usage of nbd_read 2019-02-04 15:11:27 -06:00
Makefile.objs nbd: Split nbd.c 2016-01-15 18:58:02 +01:00
nbd-internal.h nbd: Move nbd_read_eof() to nbd/client.c 2019-02-25 15:03:19 +01:00
server.c nbd/server: Don't fail NBD_OPT_INFO for byte-aligned sources 2019-04-08 13:49:25 -05:00
trace-events nbd/server: Trace client noncompliance on unaligned requests 2019-04-08 13:42:24 -05:00