Stefan Hajnoczi 0a21ea3289 virtio-blk: avoid dataplane VirtIOBlockReq early free ... VirtIOBlockReq is freed later by virtio_blk_free_request() in hw/block/virtio-blk.c. Remove this extraneous g_slice_free(). This patch fixes the following segfault: 0x00005555556373af in virtio_blk_rw_complete (opaque=0x5555565ff5e0, ret=0) at hw/block/virtio-blk.c:99 99 bdrv_acct_done(req->dev->bs, &req->acct); (gdb) print req $1 = (VirtIOBlockReq *) 0x5555565ff5e0 (gdb) print req->dev $2 = (VirtIOBlock *) 0x0 (gdb) bt #0 0x00005555556373af in virtio_blk_rw_complete (opaque=0x5555565ff5e0, ret=0) at hw/block/virtio-blk.c:99 #1 0x0000555555840ebe in bdrv_co_em_bh (opaque=0x5555566152d0) at block.c:4675 #2 0x000055555583de77 in aio_bh_poll (ctx=ctx@entry=0x5555563a8150) at async.c:81 #3 0x000055555584b7a7 in aio_poll (ctx=0x5555563a8150, blocking=blocking@entry=true) at aio-posix.c:188 #4 0x00005555556e520e in iothread_run (opaque=0x5555563a7fd8) at iothread.c:41 #5 0x00007ffff42ba124 in start_thread () from /usr/lib/libpthread.so.0 #6 0x00007ffff16d14bd in clone () from /usr/lib/libc.so.6 Reported-by: Max Reitz <mreitz@redhat.com> Cc: Fam Zheng <famz@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Tested-by: Christian Borntraeger <borntraeger@de.ibm.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>		2014-07-14 12:03:20 +02:00
..
dataplane	virtio-blk: avoid dataplane VirtIOBlockReq early free	2014-07-14 12:03:20 +02:00
block.c	hw: move target-independent files to subdirectories	2013-04-08 18:13:12 +02:00
cdrom.c	bswap.h: Remove cpu_to_be32wu()	2013-11-05 19:57:47 -08:00
ecc.c	savevm: Remove all the unneeded version_minimum_id_old (arm)	2014-05-13 16:09:35 +01:00
fdc.c	savevm: Remove all the unneeded version_minimum_id_old (x86)	2014-06-16 04:55:26 +02:00
hd-geometry.c	hw: move target-independent files to subdirectories	2013-04-08 18:13:12 +02:00
m25p80.c	block: m25p80: Support read only bdrvs.	2014-06-21 16:40:14 +08:00
Makefile.objs	pc_sysfw: do not make it a device anymore	2013-08-12 09:31:14 -05:00
nand.c	savevm: Remove all the unneeded version_minimum_id_old (arm)	2014-05-13 16:09:35 +01:00
nvme.c	nvme: Permit zero-length block devices	2014-03-31 22:35:03 +02:00
nvme.h	NVMe: Initial commit for new storage interface	2013-06-17 17:47:59 +02:00
onenand.c	block: Drop superfluous conditionals around g_free()	2014-06-16 17:23:19 +08:00
pflash_cfi01.c	hw/block/pflash_cfi01: Report correct size info for parallel configs	2014-06-19 18:06:25 +01:00
pflash_cfi02.c	pflash_cfi02.c: fix debug macro	2013-09-01 19:32:42 +04:00
tc58128.c	shix: Don't require firmware presence for qtest	2013-11-05 17:47:29 +01:00
virtio-blk.c	virtio-blk: replace x-iothread with iothread link property	2014-07-01 09:15:02 +02:00
xen_blkif.h	xen_disk: add discard support	2014-05-07 16:18:04 +00:00
xen_disk.c	xen_disk: add discard support	2014-05-07 16:18:04 +00:00