Peter Crosthwaite 0ab4c94c84 qom: Split out object and class caches ... The object-cast and class-cast caches cannot be shared because class caching is conditional on the target type not being an interface and object caching is unconditional. Leads to a bug when a class cast to an interface follows an object cast to the same interface type: FooObject = FOO(obj); FooClass = FOO_GET_CLASS(obj); Where TYPE_FOO is an interface. The first (object) cast will be successful and cache the casting result (i.e. TYPE_FOO will be cached). The second (class) cast will then check the shared cast cache and register a hit. The issue is, when a class cast hits in the cache it just returns a pointer cast of the input class (i.e. the concrete class). When casting to an interface, the cast itself must return the interface class, not the concrete class. The implementation of class cast caching already ensures that the returned cast result is only a pointer cast before caching. The object cast logic however does not have this check. Resolve by just splitting the object and class caches. Cc: qemu-stable@nongnu.org Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Tested-by: Nathan Rossi <nathan.rossi@xilinx.com> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@gmail.com> Signed-off-by: Andreas Färber <afaerber@suse.de>		2013-12-24 17:27:17 +01:00
..
container.c	Make all static TypeInfos const	2013-01-10 15:11:53 -06:00
cpu.c	cpu: Document why cannot_instantiate_with_device_add_yet	2013-12-23 00:27:22 +01:00
Makefile.objs	build: remove universal-obj-y	2013-01-26 13:15:35 +00:00
object.c	qom: Split out object and class caches	2013-12-24 17:27:17 +01:00
qom-qobject.c	qom: move include files to include/qom/	2012-12-19 08:31:32 +01:00