mirror of
https://github.com/xemu-project/xemu.git
synced 2024-11-25 12:40:08 +00:00
f51074cdc6
Commit 79ca616 (v1.6.0) accidentally disabled legacy x86-only HMP
commands pci_add, pci_del: it defined CONFIG_PCI_HOTPLUG only as make
variable, not as preprocessor macro, killing the code conditional on
defined(CONFIG_PCI_HOTPLUG_OLD).
In all this time, nobody reported the loss. I only noticed it when I
tried to test some error reporting change that forced me to touch this
old crap again.
Fun: git-log hw/pci/pci-hotplug-old.c shows our faith in the backward
compatibility god has been strong enough to sacrifice at its altar
about a dozen times, but not strong enough to even once verify the
legacy feature's still there, let alone works.
Remove the commands along with the code backing them.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
10 lines
365 B
Makefile
10 lines
365 B
Makefile
common-obj-$(CONFIG_PCI) += pci.o pci_bridge.o
|
|
common-obj-$(CONFIG_PCI) += msix.o msi.o
|
|
common-obj-$(CONFIG_PCI) += shpc.o
|
|
common-obj-$(CONFIG_PCI) += slotid_cap.o
|
|
common-obj-$(CONFIG_PCI) += pci_host.o pcie_host.o
|
|
common-obj-$(CONFIG_PCI) += pcie.o pcie_aer.o pcie_port.o
|
|
|
|
common-obj-$(call lnot,$(CONFIG_PCI)) += pci-stub.o
|
|
common-obj-$(CONFIG_ALL) += pci-stub.o
|