xemu/hw/arm
Markus Armbruster 19f33f1689 hw: Mark device misusing nd_table[] FIXME
NICs defined with -net nic are for board initialization to wire up.
Board code examines nd_table[] to find them, and creates devices with
their qdev NIC properties set accordingly.

Except "allwinner-a10" goes on a fishing expedition for NIC
configuration instead of exposing the usual NIC properties for board
code to set: it uses nd_table[0] in its instance_init() method.

Picking up the first -net nic option's configuration that way works
when the device is created by board code.  But it's inappropriate for
-device and device_add.  Not only is it inconsistent with how the
other block device models work (they get their configuration from
properties "mac", "vlan", "netdev"), it breaks when nd_table[0] has
been picked up by the board or a previous -device / device_add
already.

Example:

    $ qemu-system-arm -S -M cubieboard -device allwinner-a10
    qemu-system-arm: -device allwinner-a10: Property 'allwinner-emac.netdev' can't take value 'hub0port0', it's in use
    Aborted (core dumped)

It also breaks in other entertaining ways:

    $ qemu-system-arm -M highbank -device allwinner-a10
    qemu-system-arm: -device allwinner-a10: Unsupported NIC model: xgmac
    $ qemu-system-arm -M highbank -net nic,model=allwinner-emac -device allwinner-a10
    qemu-system-arm: Unsupported NIC model: allwinner-emac

Mark the mistake with a FIXME comment.

Cc: Li Guang <lig.fnst@cn.fujitsu.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
2015-04-02 15:30:32 +02:00
..
allwinner-a10.c hw: Mark device misusing nd_table[] FIXME 2015-04-02 15:30:32 +02:00
armv7m.c target_arm: Parameterise the irq lines for armv7m_init 2015-02-05 13:37:21 +00:00
boot.c target-arm: Change reset to highest available EL 2015-02-05 13:37:22 +00:00
collie.c hw: Convert from BlockDriverState to BlockBackend, mostly 2014-10-20 14:02:25 +02:00
cubieboard.c memory: add parameter errp to memory_region_init_ram 2014-09-09 13:41:43 +02:00
digic_boards.c arm: fix memory leak 2015-03-19 11:11:55 +03:00
digic.c
exynos4_boards.c machine: Conversion of QEMUMachineInitArgs to MachineState 2014-05-28 17:35:01 +02:00
exynos4210.c error: Use error_report_err() where appropriate 2015-02-18 10:51:09 +01:00
gumstix.c hw: Convert from BlockDriverState to BlockBackend, mostly 2014-10-20 14:02:25 +02:00
highbank.c arm: fix memory leak 2015-03-19 11:11:55 +03:00
integratorcp.c integrator/cp: Implement CARDIN and WPROT signals 2015-03-11 13:21:06 +00:00
kzm.c memory: add parameter errp to memory_region_init_ram 2014-09-09 13:41:43 +02:00
mainstone.c hw: Convert from BlockDriverState to BlockBackend, mostly 2014-10-20 14:02:25 +02:00
Makefile.objs netduino2: Add the Netduino 2 Machine 2015-03-11 13:21:06 +00:00
musicpal.c hw: Convert from BlockDriverState to BlockBackend, mostly 2014-10-20 14:02:25 +02:00
netduino2.c netduino2: Add the Netduino 2 Machine 2015-03-11 13:21:06 +00:00
nseries.c arm/nseries: Fix warnings from Sparse 2015-03-19 11:11:55 +03:00
omap1.c omap: Fix warnings from Sparse 2015-03-19 11:11:55 +03:00
omap2.c omap: Fix warnings from Sparse 2015-03-19 11:11:55 +03:00
omap_sx1.c hw: Convert from BlockDriverState to BlockBackend, mostly 2014-10-20 14:02:25 +02:00
palm.c memory: add parameter errp to memory_region_init_ram 2014-09-09 13:41:43 +02:00
pxa2xx_gpio.c hw/arm/pxa2xx_gpio: Correct and register vmstate 2014-06-29 18:38:40 +01:00
pxa2xx_pic.c savevm: Remove all the unneeded version_minimum_id_old (arm) 2014-05-13 16:09:35 +01:00
pxa2xx.c hw/usb: simplified usb_enabled 2015-01-08 17:32:27 +00:00
realview.c error: Use error_report_err() where appropriate 2015-02-18 10:51:09 +01:00
spitz.c hw: Mark devices picking up block backends actively FIXME 2015-04-02 15:26:27 +02:00
stellaris.c target_arm: Parameterise the irq lines for armv7m_init 2015-02-05 13:37:21 +00:00
stm32f205_soc.c stm32f205: Add the stm32f205 SoC 2015-03-11 13:21:06 +00:00
strongarm.c memory: add parameter errp to memory_region_init_ram 2014-09-09 13:41:43 +02:00
strongarm.h
tosa.c hw: Convert from BlockDriverState to BlockBackend, mostly 2014-10-20 14:02:25 +02:00
versatilepb.c error: Use error_report_err() where appropriate 2015-02-18 10:51:09 +01:00
vexpress.c arm: fix memory leak 2015-03-19 11:11:55 +03:00
virt.c error: Replace error_report() & error_free() with error_report_err() 2015-03-19 11:11:55 +03:00
xilinx_zynq.c error: Use error_report_err() where appropriate 2015-02-18 10:51:09 +01:00
z2.c hw: Convert from BlockDriverState to BlockBackend, mostly 2014-10-20 14:02:25 +02:00