mirror of
https://github.com/xemu-project/xemu.git
synced 2024-12-19 17:58:29 +00:00
b106ad9185
free_cluster_index is only correct if update_refcount() was called from an allocation function, and even there it's brittle because it's used to protect unfinished allocations which still have a refcount of 0 - if it moves in the wrong place, the unfinished allocation can be corrupted. So not using it any more seems to be a good idea. Instead, use the first requested cluster to do the calculations. Return -EAGAIN if unfinished allocations could become invalid and let the caller restart its search for some free clusters. The context of creating a snapsnot is one situation where update_refcount() is called outside of a cluster allocation. For this case, the change fixes a buffer overflow if a cluster is referenced in an L2 table that cannot be represented by an existing refcount block. (new_table[refcount_table_index] was out of bounds) [Bump the qemu-iotests 026 refblock_alloc.write leak count from 10 to 11. --Stefan] Signed-off-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Max Reitz <mreitz@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
9 lines
234 B
Plaintext
9 lines
234 B
Plaintext
No errors were found on the image.
|
|
7292415/33554432 = 21.73% allocated, 0.00% fragmented, 0.00% compressed clusters
|
|
Image end offset: 4296152064
|
|
.
|
|
----------------------------------------------------------------------
|
|
Ran 1 tests
|
|
|
|
OK
|