Paolo Bonzini 30e5210a70 watchdog: fix deadlock with -watchdog-action pause
qemu_clock_enable says:

/* Disabling the clock will wait for related timerlists to stop
 * executing qemu_run_timers.  Thus, this functions should not
 * be used from the callback of a timer that is based on @clock.
 * Doing so would cause a deadlock.
 */

and it indeed does: vm_stop uses qemu_clock_enable on QEMU_CLOCK_VIRTUAL
and watchdogs are based on QEMU_CLOCK_VIRTUAL, and we get a deadlock.

Use qemu_system_vmstop_request_prepare()/qemu_system_vmstop_request()
instead; yet another alternative could be a BH.

I checked other occurrences of vm_stop and they should not have this
problem.  RUN_STATE_IO_ERROR could in principle (it depends on the
code in the drivers) but it has been fixed by commit 2bd3bce, "block:
asynchronously stop the VM on I/O errors", 2014-06-05.

Tested-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2014-07-09 18:17:08 +02:00
2014-06-23 11:00:12 -04:00
2014-07-01 13:13:04 +01:00
2014-06-27 12:11:53 +02:00
2014-06-20 23:59:19 +01:00
2014-06-27 09:27:56 -04:00
2014-06-05 16:10:33 +02:00
2014-06-29 18:59:06 +03:00
2014-06-05 16:10:33 +02:00
2014-07-01 13:13:04 +01:00
2014-06-27 09:27:55 -04:00
2014-06-16 13:24:35 +02:00
2014-06-09 15:43:40 +02:00
2014-06-23 11:12:28 -04:00
2014-06-23 11:01:25 -04:00
2014-06-05 16:10:33 +02:00
2014-06-19 18:44:21 +03:00
2014-06-19 16:41:54 +03:00
2014-06-27 09:27:55 -04:00
2014-06-23 11:01:25 -04:00
2014-06-23 19:09:50 +02:00
2014-06-30 12:50:17 +02:00
2014-03-13 14:34:16 +00:00
2014-05-28 17:36:21 +02:00
2014-06-16 17:23:21 +08:00
2014-06-09 15:43:40 +02:00
2014-05-24 00:07:29 +04:00
2014-06-27 10:39:10 +02:00
2014-06-19 18:44:22 +03:00
2014-02-17 11:57:23 -05:00
2014-06-05 16:10:33 +02:00
2014-07-01 18:48:01 +01:00
2014-07-01 14:21:50 +01:00
2014-05-07 16:16:43 +00:00

Read the documentation in qemu-doc.html or on http://wiki.qemu-project.org

- QEMU team
Description
Original Xbox Emulator for Windows, macOS, and Linux (Active Development)
Readme 531 MiB
Languages
C 82.5%
C++ 7%
Python 3.3%
Dylan 2.8%
Shell 1.5%
Other 2.6%