Peter Maydell 35b6e94ba5 s390: avoid always-true comparison in s390_pci_generate_fid() ...

Coverity points out that the comparison "fid <= ZPCI_MAX_FID"
in s390_pci_generate_fid() is always true (because fid
is 32 bits and ZPCI_MAX_FID is 0xffffffff). This isn't a
bug because the real loop termination condition is
expressed later via an "if (...) break;" inside the loop,
but it is a bit odd. Rephrase the loop to avoid the
unnecessary duplicate-but-never-true conditional.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

2016-10-28 18:17:23 +03:00

..

ccw-device.c

s390x/css: Unplug handler of virtual css bridge

2016-07-11 09:48:05 +02:00

ccw-device.h

s390x/css: Unplug handler of virtual css bridge

2016-07-11 09:48:05 +02:00

css-bridge.c

s390x/css: provide a dev_path for css devices

2016-07-20 15:47:25 +02:00

css.c

s390x/css: {c,h,t,r,x}sch: require enable AND device number valid

2016-09-28 13:24:51 +02:00

event-facility.c

include/qemu/osdep.h: Don't include qapi/error.h

2016-03-22 22:20:15 +01:00

ipl.c

s390x/css: Unplug handler of virtual css bridge

2016-07-11 09:48:05 +02:00

ipl.h

s390x/ipl: fix reboots for migration from different bios

2016-07-11 09:48:05 +02:00

Makefile.objs

s390x/css: Unplug handler of virtual css bridge

2016-07-11 09:48:05 +02:00

s390-pci-bus.c

s390: avoid always-true comparison in s390_pci_generate_fid()

2016-10-28 18:17:23 +03:00

s390-pci-bus.h

s390x/pci: assign msix io region for each pci device

2016-09-28 13:24:51 +02:00

s390-pci-inst.c

s390x/pci: re-arrange variable declarations

2016-09-28 13:24:50 +02:00

s390-pci-inst.h

Use #include "..." for our own headers, <...> for others

2016-07-12 16:19:16 +02:00

s390-skeys-kvm.c

s390: Clean up includes

2016-01-29 15:07:22 +00:00

s390-skeys.c

s390: use FILE instead of QEMUFile for creating text file

2016-05-26 11:31:05 +05:30

s390-virtio-ccw.c

s390x/kvm: disable cpu model for the 2.7 machine

2016-09-19 11:05:51 +02:00

s390-virtio-hcall.c

s390: Clean up includes

2016-01-29 15:07:22 +00:00

s390-virtio.c

s390x/cpumodel: "host" and "qemu" as CPU subclasses

2016-09-06 17:06:49 +02:00

s390-virtio.h

Clean up decorations and whitespace around header guards

2016-07-12 16:20:46 +02:00

sclp.c

s390x: remove useless cast

2016-09-15 15:32:22 +03:00

sclpcpu.c

s390: Clean up includes

2016-01-29 15:07:22 +00:00

sclpquiesce.c

Use #include "..." for our own headers, <...> for others

2016-07-12 16:19:16 +02:00

trace-events

trace-events: fix first line comment in trace-events

2016-08-12 10:36:01 +01:00

virtio-ccw.c

Couple of s390x patches:

2016-09-19 12:41:28 +01:00

virtio-ccw.h

virtio-ccw: set revision 2 as maximal revision number

2016-09-19 11:05:51 +02:00