mirror of
https://github.com/xemu-project/xemu.git
synced 2024-11-27 13:30:52 +00:00
5202861b20
Currently our semihosting implementations generally prohibit use of semihosting calls in system emulation from the guest userspace. This is a very long standing behaviour justified originally "to provide some semblance of security" (since code with access to the semihosting ABI can do things like read and write arbitrary files on the host system). However, it is sometimes useful to be able to run trusted guest code which performs semihosting calls from guest userspace, notably for test code. Add a command line suboption to the existing semihosting-config option group so that you can explicitly opt in to semihosting from guest userspace with -semihosting-config userspace=on (There is no equivalent option for the user-mode emulator, because there by definition all code runs in userspace and has access to semihosting already.) This commit adds the infrastructure for the command line option and adds a bool 'is_user' parameter to the function semihosting_userspace_enabled() that target code can use to check whether it should be permitting the semihosting call for userspace. It mechanically makes all the callsites pass 'false', so they continue checking "is semihosting enabled in general". Subsequent commits will make each target that implements semihosting honour the userspace=on option by passing the correct value and removing whatever "don't do this for userspace" checking they were doing by hand. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Acked-by: Alex Bennée <alex.bennee@linaro.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-Id: <20220822141230.3658237-2-peter.maydell@linaro.org> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
71 lines
1.2 KiB
C
71 lines
1.2 KiB
C
/*
|
|
* Semihosting Stubs for SoftMMU
|
|
*
|
|
* Copyright (c) 2019 Linaro Ltd
|
|
*
|
|
* Stubs for SoftMMU targets that don't actually do semihosting.
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0-or-later
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qemu/option.h"
|
|
#include "qemu/error-report.h"
|
|
#include "semihosting/semihost.h"
|
|
|
|
/* Empty config */
|
|
QemuOptsList qemu_semihosting_config_opts = {
|
|
.name = "",
|
|
.head = QTAILQ_HEAD_INITIALIZER(qemu_semihosting_config_opts.head),
|
|
.desc = {
|
|
{ /* end of list */ }
|
|
},
|
|
};
|
|
|
|
/* Queries to config status default to off */
|
|
bool semihosting_enabled(bool is_user)
|
|
{
|
|
return false;
|
|
}
|
|
|
|
SemihostingTarget semihosting_get_target(void)
|
|
{
|
|
return SEMIHOSTING_TARGET_AUTO;
|
|
}
|
|
|
|
/*
|
|
* All the rest are empty subs. We could g_assert_not_reached() but
|
|
* that adds extra weight to the final binary. Waste not want not.
|
|
*/
|
|
void qemu_semihosting_enable(void)
|
|
{
|
|
}
|
|
|
|
int qemu_semihosting_config_options(const char *optarg)
|
|
{
|
|
return 1;
|
|
}
|
|
|
|
const char *semihosting_get_arg(int i)
|
|
{
|
|
return NULL;
|
|
}
|
|
|
|
int semihosting_get_argc(void)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
const char *semihosting_get_cmdline(void)
|
|
{
|
|
return NULL;
|
|
}
|
|
|
|
void semihosting_arg_fallback(const char *file, const char *cmd)
|
|
{
|
|
}
|
|
|
|
void qemu_semihosting_chardev_init(void)
|
|
{
|
|
}
|