mirror of
https://github.com/xemu-project/xemu.git
synced 2024-11-28 22:10:33 +00:00
773c4a6228
The tests tries to let qemu server mode to process the connection
which turns out to be racy after commit 8258292e18 ("monitor: Remove
"x-oob", offer capability "oob" unconditionally"). This is because the
filter may try to mirror the packets before UNIX socket object is
ready (connected was set to true) from the view of qemu. In this case
the packet will be dropped silently.
Fixing this by passing pre-connected socket created by socketpair() to
qemu through fd.
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Li Zhijian <lizhijian@cn.fujitsu.com>
Cc: Peter Xu <peterx@redhat.com>
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Cc: Zhang Chen <zhangckid@gmail.com>
Cc: Markus Armbruster <armbru@redhat.com>
Cc: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Zhang Chen <zhangckid@gmail.com>
Message-id: 20190130031427.13129-1-jasowang@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
94 lines
2.5 KiB
C
94 lines
2.5 KiB
C
/*
|
|
* QTest testcase for filter-mirror
|
|
*
|
|
* Copyright (c) 2016 FUJITSU LIMITED
|
|
* Author: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or
|
|
* later. See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "libqtest.h"
|
|
#include "qapi/qmp/qdict.h"
|
|
#include "qemu/iov.h"
|
|
#include "qemu/sockets.h"
|
|
#include "qemu/error-report.h"
|
|
#include "qemu/main-loop.h"
|
|
|
|
/* TODO actually test the results and get rid of this */
|
|
#define qmp_discard_response(qs, ...) qobject_unref(qtest_qmp(qs, __VA_ARGS__))
|
|
|
|
static void test_mirror(void)
|
|
{
|
|
int send_sock[2], recv_sock[2];
|
|
uint32_t ret = 0, len = 0;
|
|
char send_buf[] = "Hello! filter-mirror~";
|
|
char *recv_buf;
|
|
uint32_t size = sizeof(send_buf);
|
|
size = htonl(size);
|
|
const char *devstr = "e1000";
|
|
QTestState *qts;
|
|
|
|
if (g_str_equal(qtest_get_arch(), "s390x")) {
|
|
devstr = "virtio-net-ccw";
|
|
}
|
|
|
|
ret = socketpair(PF_UNIX, SOCK_STREAM, 0, send_sock);
|
|
g_assert_cmpint(ret, !=, -1);
|
|
|
|
ret = socketpair(PF_UNIX, SOCK_STREAM, 0, recv_sock);
|
|
g_assert_cmpint(ret, !=, -1);
|
|
|
|
qts = qtest_initf(
|
|
"-netdev socket,id=qtest-bn0,fd=%d "
|
|
"-device %s,netdev=qtest-bn0,id=qtest-e0 "
|
|
"-chardev socket,id=mirror0,fd=%d "
|
|
"-object filter-mirror,id=qtest-f0,netdev=qtest-bn0,queue=tx,outdev=mirror0 "
|
|
, send_sock[1], devstr, recv_sock[1]);
|
|
|
|
struct iovec iov[] = {
|
|
{
|
|
.iov_base = &size,
|
|
.iov_len = sizeof(size),
|
|
}, {
|
|
.iov_base = send_buf,
|
|
.iov_len = sizeof(send_buf),
|
|
},
|
|
};
|
|
|
|
/* send a qmp command to guarantee that 'connected' is setting to true. */
|
|
qmp_discard_response(qts, "{ 'execute' : 'query-status'}");
|
|
ret = iov_send(send_sock[0], iov, 2, 0, sizeof(size) + sizeof(send_buf));
|
|
g_assert_cmpint(ret, ==, sizeof(send_buf) + sizeof(size));
|
|
close(send_sock[0]);
|
|
|
|
ret = qemu_recv(recv_sock[0], &len, sizeof(len), 0);
|
|
g_assert_cmpint(ret, ==, sizeof(len));
|
|
len = ntohl(len);
|
|
|
|
g_assert_cmpint(len, ==, sizeof(send_buf));
|
|
recv_buf = g_malloc(len);
|
|
ret = qemu_recv(recv_sock[0], recv_buf, len, 0);
|
|
g_assert_cmpstr(recv_buf, ==, send_buf);
|
|
|
|
g_free(recv_buf);
|
|
close(send_sock[0]);
|
|
close(send_sock[1]);
|
|
close(recv_sock[0]);
|
|
close(recv_sock[1]);
|
|
qtest_quit(qts);
|
|
}
|
|
|
|
int main(int argc, char **argv)
|
|
{
|
|
int ret;
|
|
|
|
g_test_init(&argc, &argv, NULL);
|
|
|
|
qtest_add_func("/netfilter/mirror", test_mirror);
|
|
ret = g_test_run();
|
|
|
|
return ret;
|
|
}
|