mirror of
https://github.com/xemu-project/xemu.git
synced 2024-11-25 04:30:02 +00:00
b6fcf32d9b
In the testsuite, UserDefTwo and UserDefNested were identical structs other than the member names. Reduce code duplication by having just one type, and choose names that also favor reuse. This will also make it easier for a later patch to get rid of inline nested types in QAPI. When touching code related to allocations, convert g_malloc0(sizeof(Type)) to the more typesafe g_new0(Type, 1). Ensure that 'make check-qapi-schema check-unit' still passes. Signed-off-by: Eric Blake <eblake@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com>
341 lines
10 KiB
C
341 lines
10 KiB
C
/*
|
|
* QMP Input Visitor unit-tests (strict mode).
|
|
*
|
|
* Copyright (C) 2011-2012, 2015 Red Hat Inc.
|
|
*
|
|
* Authors:
|
|
* Luiz Capitulino <lcapitulino@redhat.com>
|
|
* Paolo Bonzini <pbonzini@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#include <glib.h>
|
|
#include <stdarg.h>
|
|
|
|
#include "qemu-common.h"
|
|
#include "qapi/qmp-input-visitor.h"
|
|
#include "test-qapi-types.h"
|
|
#include "test-qapi-visit.h"
|
|
#include "qapi/qmp/types.h"
|
|
|
|
typedef struct TestInputVisitorData {
|
|
QObject *obj;
|
|
QmpInputVisitor *qiv;
|
|
} TestInputVisitorData;
|
|
|
|
static void validate_teardown(TestInputVisitorData *data,
|
|
const void *unused)
|
|
{
|
|
qobject_decref(data->obj);
|
|
data->obj = NULL;
|
|
|
|
if (data->qiv) {
|
|
qmp_input_visitor_cleanup(data->qiv);
|
|
data->qiv = NULL;
|
|
}
|
|
}
|
|
|
|
/* This is provided instead of a test setup function so that the JSON
|
|
string used by the tests are kept in the test functions (and not
|
|
int main()) */
|
|
static GCC_FMT_ATTR(2, 3)
|
|
Visitor *validate_test_init(TestInputVisitorData *data,
|
|
const char *json_string, ...)
|
|
{
|
|
Visitor *v;
|
|
va_list ap;
|
|
|
|
va_start(ap, json_string);
|
|
data->obj = qobject_from_jsonv(json_string, &ap);
|
|
va_end(ap);
|
|
|
|
g_assert(data->obj != NULL);
|
|
|
|
data->qiv = qmp_input_visitor_new_strict(data->obj);
|
|
g_assert(data->qiv != NULL);
|
|
|
|
v = qmp_input_get_visitor(data->qiv);
|
|
g_assert(v != NULL);
|
|
|
|
return v;
|
|
}
|
|
|
|
typedef struct TestStruct
|
|
{
|
|
int64_t integer;
|
|
bool boolean;
|
|
char *string;
|
|
} TestStruct;
|
|
|
|
static void visit_type_TestStruct(Visitor *v, TestStruct **obj,
|
|
const char *name, Error **errp)
|
|
{
|
|
Error *err = NULL;
|
|
|
|
visit_start_struct(v, (void **)obj, "TestStruct", name, sizeof(TestStruct),
|
|
&err);
|
|
if (err) {
|
|
goto out;
|
|
}
|
|
|
|
visit_type_int(v, &(*obj)->integer, "integer", &err);
|
|
if (err) {
|
|
goto out_end;
|
|
}
|
|
visit_type_bool(v, &(*obj)->boolean, "boolean", &err);
|
|
if (err) {
|
|
goto out_end;
|
|
}
|
|
visit_type_str(v, &(*obj)->string, "string", &err);
|
|
|
|
out_end:
|
|
error_propagate(errp, err);
|
|
err = NULL;
|
|
visit_end_struct(v, &err);
|
|
out:
|
|
error_propagate(errp, err);
|
|
}
|
|
|
|
static void test_validate_struct(TestInputVisitorData *data,
|
|
const void *unused)
|
|
{
|
|
TestStruct *p = NULL;
|
|
Error *err = NULL;
|
|
Visitor *v;
|
|
|
|
v = validate_test_init(data, "{ 'integer': -42, 'boolean': true, 'string': 'foo' }");
|
|
|
|
visit_type_TestStruct(v, &p, NULL, &err);
|
|
g_assert(!err);
|
|
g_free(p->string);
|
|
g_free(p);
|
|
}
|
|
|
|
static void test_validate_struct_nested(TestInputVisitorData *data,
|
|
const void *unused)
|
|
{
|
|
UserDefTwo *udp = NULL;
|
|
Error *err = NULL;
|
|
Visitor *v;
|
|
|
|
v = validate_test_init(data, "{ 'string0': 'string0', "
|
|
"'dict1': { 'string1': 'string1', "
|
|
"'dict2': { 'userdef': { 'integer': 42, "
|
|
"'string': 'string' }, 'string': 'string2'}}}");
|
|
|
|
visit_type_UserDefTwo(v, &udp, NULL, &err);
|
|
g_assert(!err);
|
|
qapi_free_UserDefTwo(udp);
|
|
}
|
|
|
|
static void test_validate_list(TestInputVisitorData *data,
|
|
const void *unused)
|
|
{
|
|
UserDefOneList *head = NULL;
|
|
Error *err = NULL;
|
|
Visitor *v;
|
|
|
|
v = validate_test_init(data, "[ { 'string': 'string0', 'integer': 42 }, { 'string': 'string1', 'integer': 43 }, { 'string': 'string2', 'integer': 44 } ]");
|
|
|
|
visit_type_UserDefOneList(v, &head, NULL, &err);
|
|
g_assert(!err);
|
|
qapi_free_UserDefOneList(head);
|
|
}
|
|
|
|
static void test_validate_union_native_list(TestInputVisitorData *data,
|
|
const void *unused)
|
|
{
|
|
UserDefNativeListUnion *tmp = NULL;
|
|
Visitor *v;
|
|
Error *err = NULL;
|
|
|
|
v = validate_test_init(data, "{ 'type': 'integer', 'data' : [ 1, 2 ] }");
|
|
|
|
visit_type_UserDefNativeListUnion(v, &tmp, NULL, &err);
|
|
g_assert(!err);
|
|
qapi_free_UserDefNativeListUnion(tmp);
|
|
}
|
|
|
|
static void test_validate_union_flat(TestInputVisitorData *data,
|
|
const void *unused)
|
|
{
|
|
UserDefFlatUnion *tmp = NULL;
|
|
Visitor *v;
|
|
Error *err = NULL;
|
|
|
|
v = validate_test_init(data,
|
|
"{ 'enum1': 'value1', "
|
|
"'string': 'str', "
|
|
"'boolean': true }");
|
|
/* TODO when generator bug is fixed, add 'integer': 41 */
|
|
|
|
visit_type_UserDefFlatUnion(v, &tmp, NULL, &err);
|
|
g_assert(!err);
|
|
qapi_free_UserDefFlatUnion(tmp);
|
|
}
|
|
|
|
static void test_validate_alternate(TestInputVisitorData *data,
|
|
const void *unused)
|
|
{
|
|
UserDefAlternate *tmp = NULL;
|
|
Visitor *v;
|
|
Error *err = NULL;
|
|
|
|
v = validate_test_init(data, "42");
|
|
|
|
visit_type_UserDefAlternate(v, &tmp, NULL, &err);
|
|
g_assert(!err);
|
|
qapi_free_UserDefAlternate(tmp);
|
|
}
|
|
|
|
static void test_validate_fail_struct(TestInputVisitorData *data,
|
|
const void *unused)
|
|
{
|
|
TestStruct *p = NULL;
|
|
Error *err = NULL;
|
|
Visitor *v;
|
|
|
|
v = validate_test_init(data, "{ 'integer': -42, 'boolean': true, 'string': 'foo', 'extra': 42 }");
|
|
|
|
visit_type_TestStruct(v, &p, NULL, &err);
|
|
g_assert(err);
|
|
if (p) {
|
|
g_free(p->string);
|
|
}
|
|
g_free(p);
|
|
}
|
|
|
|
static void test_validate_fail_struct_nested(TestInputVisitorData *data,
|
|
const void *unused)
|
|
{
|
|
UserDefTwo *udp = NULL;
|
|
Error *err = NULL;
|
|
Visitor *v;
|
|
|
|
v = validate_test_init(data, "{ 'string0': 'string0', 'dict1': { 'string1': 'string1', 'dict2': { 'userdef1': { 'integer': 42, 'string': 'string', 'extra': [42, 23, {'foo':'bar'}] }, 'string2': 'string2'}}}");
|
|
|
|
visit_type_UserDefTwo(v, &udp, NULL, &err);
|
|
g_assert(err);
|
|
qapi_free_UserDefTwo(udp);
|
|
}
|
|
|
|
static void test_validate_fail_list(TestInputVisitorData *data,
|
|
const void *unused)
|
|
{
|
|
UserDefOneList *head = NULL;
|
|
Error *err = NULL;
|
|
Visitor *v;
|
|
|
|
v = validate_test_init(data, "[ { 'string': 'string0', 'integer': 42 }, { 'string': 'string1', 'integer': 43 }, { 'string': 'string2', 'integer': 44, 'extra': 'ggg' } ]");
|
|
|
|
visit_type_UserDefOneList(v, &head, NULL, &err);
|
|
g_assert(err);
|
|
qapi_free_UserDefOneList(head);
|
|
}
|
|
|
|
static void test_validate_fail_union_native_list(TestInputVisitorData *data,
|
|
const void *unused)
|
|
{
|
|
UserDefNativeListUnion *tmp = NULL;
|
|
Error *err = NULL;
|
|
Visitor *v;
|
|
|
|
v = validate_test_init(data,
|
|
"{ 'type': 'integer', 'data' : [ 'string' ] }");
|
|
|
|
visit_type_UserDefNativeListUnion(v, &tmp, NULL, &err);
|
|
g_assert(err);
|
|
qapi_free_UserDefNativeListUnion(tmp);
|
|
}
|
|
|
|
static void test_validate_fail_union_flat(TestInputVisitorData *data,
|
|
const void *unused)
|
|
{
|
|
UserDefFlatUnion *tmp = NULL;
|
|
Error *err = NULL;
|
|
Visitor *v;
|
|
|
|
v = validate_test_init(data, "{ 'string': 'c', 'integer': 41, 'boolean': true }");
|
|
|
|
visit_type_UserDefFlatUnion(v, &tmp, NULL, &err);
|
|
g_assert(err);
|
|
qapi_free_UserDefFlatUnion(tmp);
|
|
}
|
|
|
|
static void test_validate_fail_union_flat_no_discrim(TestInputVisitorData *data,
|
|
const void *unused)
|
|
{
|
|
UserDefFlatUnion2 *tmp = NULL;
|
|
Error *err = NULL;
|
|
Visitor *v;
|
|
|
|
/* test situation where discriminator field ('enum1' here) is missing */
|
|
v = validate_test_init(data, "{ 'string': 'c', 'string1': 'd', 'string2': 'e' }");
|
|
|
|
visit_type_UserDefFlatUnion2(v, &tmp, NULL, &err);
|
|
g_assert(err);
|
|
qapi_free_UserDefFlatUnion2(tmp);
|
|
}
|
|
|
|
static void test_validate_fail_alternate(TestInputVisitorData *data,
|
|
const void *unused)
|
|
{
|
|
UserDefAlternate *tmp = NULL;
|
|
Visitor *v;
|
|
Error *err = NULL;
|
|
|
|
v = validate_test_init(data, "3.14");
|
|
|
|
visit_type_UserDefAlternate(v, &tmp, NULL, &err);
|
|
g_assert(err);
|
|
qapi_free_UserDefAlternate(tmp);
|
|
}
|
|
|
|
static void validate_test_add(const char *testpath,
|
|
TestInputVisitorData *data,
|
|
void (*test_func)(TestInputVisitorData *data, const void *user_data))
|
|
{
|
|
g_test_add(testpath, TestInputVisitorData, data, NULL, test_func,
|
|
validate_teardown);
|
|
}
|
|
|
|
int main(int argc, char **argv)
|
|
{
|
|
TestInputVisitorData testdata;
|
|
|
|
g_test_init(&argc, &argv, NULL);
|
|
|
|
validate_test_add("/visitor/input-strict/pass/struct",
|
|
&testdata, test_validate_struct);
|
|
validate_test_add("/visitor/input-strict/pass/struct-nested",
|
|
&testdata, test_validate_struct_nested);
|
|
validate_test_add("/visitor/input-strict/pass/list",
|
|
&testdata, test_validate_list);
|
|
validate_test_add("/visitor/input-strict/pass/union-flat",
|
|
&testdata, test_validate_union_flat);
|
|
validate_test_add("/visitor/input-strict/pass/alternate",
|
|
&testdata, test_validate_alternate);
|
|
validate_test_add("/visitor/input-strict/pass/union-native-list",
|
|
&testdata, test_validate_union_native_list);
|
|
validate_test_add("/visitor/input-strict/fail/struct",
|
|
&testdata, test_validate_fail_struct);
|
|
validate_test_add("/visitor/input-strict/fail/struct-nested",
|
|
&testdata, test_validate_fail_struct_nested);
|
|
validate_test_add("/visitor/input-strict/fail/list",
|
|
&testdata, test_validate_fail_list);
|
|
validate_test_add("/visitor/input-strict/fail/union-flat",
|
|
&testdata, test_validate_fail_union_flat);
|
|
validate_test_add("/visitor/input-strict/fail/union-flat-no-discriminator",
|
|
&testdata, test_validate_fail_union_flat_no_discrim);
|
|
validate_test_add("/visitor/input-strict/fail/alternate",
|
|
&testdata, test_validate_fail_alternate);
|
|
validate_test_add("/visitor/input-strict/fail/union-native-list",
|
|
&testdata, test_validate_fail_union_native_list);
|
|
|
|
g_test_run();
|
|
|
|
return 0;
|
|
}
|