Bin Meng cffb446e8f hw/sd: sdhci: Reset the data pointer of s->fifo_buffer[] when a different block size is programmed ... If the block size is programmed to a different value from the previous one, reset the data pointer of s->fifo_buffer[] so that s->fifo_buffer[] can be filled in using the new block size in the next transfer. With this fix, the following reproducer: outl 0xcf8 0x80001010 outl 0xcfc 0xe0000000 outl 0xcf8 0x80001001 outl 0xcfc 0x06000000 write 0xe000002c 0x1 0x05 write 0xe0000005 0x1 0x02 write 0xe0000007 0x1 0x01 write 0xe0000028 0x1 0x10 write 0x0 0x1 0x23 write 0x2 0x1 0x08 write 0xe000000c 0x1 0x01 write 0xe000000e 0x1 0x20 write 0xe000000f 0x1 0x00 write 0xe000000c 0x1 0x32 write 0xe0000004 0x2 0x0200 write 0xe0000028 0x1 0x00 write 0xe0000003 0x1 0x40 cannot be reproduced with the following QEMU command line: $ qemu-system-x86_64 -nographic -machine accel=qtest -m 512M \ -nodefaults -device sdhci-pci,sd-spec-version=3 \ -drive if=sd,index=0,file=null-co://,format=raw,id=mydrive \ -device sd-card,drive=mydrive -qtest stdio Cc: qemu-stable@nongnu.org Fixes: CVE-2020-17380 Fixes: CVE-2020-25085 Fixes: CVE-2021-3409 Fixes: d7dfca0807 ("hw/sdhci: introduce standard SD host controller") Reported-by: Alexander Bulekov <alxndr@bu.edu> Reported-by: Cornelius Aschermann (Ruhr-Universität Bochum) Reported-by: Sergej Schumilo (Ruhr-Universität Bochum) Reported-by: Simon Wörner (Ruhr-Universität Bochum) Buglink: https://bugs.launchpad.net/qemu/+bug/1892960 Buglink: https://bugs.launchpad.net/qemu/+bug/1909418 Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1928146 Tested-by: Alexander Bulekov <alxndr@bu.edu> Signed-off-by: Bin Meng <bmeng.cn@gmail.com> Message-Id: <20210303122639.20004-6-bmeng.cn@gmail.com> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>		2021-03-22 16:56:22 +01:00
..
allwinner-sdhost.c	Use DECLARE_*CHECKER* when possible (--force mode)	2020-09-09 09:27:11 -04:00
aspeed_sdhci.c	Fix SPDX-License-Identifier typos	2021-02-20 12:36:19 +01:00
bcm2835_sdhost.c	Use DECLARE_*CHECKER* when possible (--force mode)	2020-09-09 09:27:11 -04:00
cadence_sdhci.c	hw/sd: Add Cadence SDHCI emulation	2020-09-09 15:54:18 -07:00
core.c	hw/sd: Introduce receive_ready() callback	2021-02-20 00:17:09 +01:00
Kconfig	hw/sd: Add Cadence SDHCI emulation	2020-09-09 15:54:18 -07:00
meson.build	hw/sd: Add Cadence SDHCI emulation	2020-09-09 15:54:18 -07:00
milkymist-memcard.c	nomaintainer: Fix Lesser GPL version number	2020-11-15 17:04:40 +01:00
omap_mmc.c	hw/sd: Rename read/write_data() as read/write_byte()	2020-08-21 16:35:35 +02:00
pl181.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
pxa2xx_mmci.c	Use DECLARE_*CHECKER* when possible (--force mode)	2020-09-09 09:27:11 -04:00
sd.c	hw/sd: sd: Actually perform the erase operation	2021-03-22 15:34:29 +01:00
sdhci-internal.h	sd: sdhci: Implement basic vendor specific register support	2020-06-16 10:32:29 +01:00
sdhci-pci.c	sd: Use ERRP_GUARD()	2020-07-10 15:18:09 +02:00
sdhci.c	hw/sd: sdhci: Reset the data pointer of s->fifo_buffer[] when a different block size is programmed	2021-03-22 16:56:22 +01:00
sdmmc-internal.c	sdcard: Display command name when tracing CMD/ACMD	2018-03-09 17:09:44 +00:00
sdmmc-internal.h	Clean up header guards that don't match their file name	2019-05-13 08:58:55 +02:00
ssi-sd.c	hw/sd: ssi-sd: Handle the rest commands with R1b response type	2021-02-20 00:17:09 +01:00
trace-events	hw/sd/sdcard: Make iolen unsigned	2020-10-26 00:36:52 +01:00
trace.h	trace: switch position of headers to what Meson requires	2020-08-21 06:18:24 -04:00