Eric Blake 5de47735c7 nbd: Tolerate more errors to structured reply request ... A server may have a reason to reject a request for structured replies, beyond just not recognizing them as a valid request; similarly, it may have a reason for rejecting a request for a meta context. It doesn't hurt us to continue talking to such a server; otherwise 'qemu-nbd --list' of such a server fails to display all available details about the export. Encountered when temporarily tweaking nbdkit to reply with NBD_REP_ERR_POLICY. Present since structured reply support was first added (commit d795299b reused starttls handling, but starttls is different in that we can't fall back to other behavior on any error). Note that for an unencrypted client trying to connect to a server that requires encryption, this defers the point of failure to when we finally execute a strict command (such as NBD_OPT_GO or NBD_OPT_LIST), now that the intermediate NBD_OPT_STRUCTURED_REPLY does not diagnose NBD_REP_ERR_TLS_REQD as fatal; but as the protocol eventually gets us to a command where we can't continue onwards, the changed error message doesn't cause any security concerns. Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <20190824172813.29720-3-eblake@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> [eblake: fix iotest 233]		2019-09-05 15:57:37 -05:00
..
client.c	nbd: Tolerate more errors to structured reply request	2019-09-05 15:57:37 -05:00
common.c	nbd: generalize usage of nbd_read	2019-02-04 15:11:27 -06:00
Makefile.objs
nbd-internal.h	Include qemu/main-loop.h less	2019-08-16 13:31:52 +02:00
server.c	nbd: Use g_autofree in a few places	2019-09-05 15:52:45 -05:00
trace-events	nbd: Tolerate more errors to structured reply request	2019-09-05 15:57:37 -05:00