Eduardo Habkost e90f2a8c3e qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable ... cannot_instantiate_with_device_add_yet was introduced by commit efec3dd631 to replace no_user. It was supposed to be a temporary measure. When it was introduced, we had 54 cannot_instantiate_with_device_add_yet=true lines in the code. Today (3 years later) this number has not shrunk: we now have 57 cannot_instantiate_with_device_add_yet=true lines. I think it is safe to say it is not a temporary measure, and we won't see the flag go away soon. Instead of a long field name that misleads people to believe it is temporary, replace it a shorter and less misleading field: user_creatable. Except for code comments, changes were generated using the following Coccinelle patch: @@ expression DC; @@ ( -DC->cannot_instantiate_with_device_add_yet = false; +DC->user_creatable = true; | -DC->cannot_instantiate_with_device_add_yet = true; +DC->user_creatable = false; ) @@ typedef ObjectClass; expression dc; identifier class, data; @@ static void device_class_init(ObjectClass *class, void *data) { ... dc->hotpluggable = true; +dc->user_creatable = true; ... } @@ @@ struct DeviceClass { ... -bool cannot_instantiate_with_device_add_yet; +bool user_creatable; ... } @@ expression DC; @@ ( -!DC->cannot_instantiate_with_device_add_yet +DC->user_creatable | -DC->cannot_instantiate_with_device_add_yet +!DC->user_creatable ) Cc: Alistair Francis <alistair.francis@xilinx.com> Cc: Laszlo Ersek <lersek@redhat.com> Cc: Marcel Apfelbaum <marcel@redhat.com> Cc: Markus Armbruster <armbru@redhat.com> Cc: Peter Maydell <peter.maydell@linaro.org> Cc: Thomas Huth <thuth@redhat.com> Acked-by: Alistair Francis <alistair.francis@xilinx.com> Reviewed-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com> Acked-by: Marcel Apfelbaum <marcel@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Message-Id: <20170503203604.31462-2-ehabkost@redhat.com> [ehabkost: kept "TODO remove once we're there" comment] Reviewed-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>		2017-05-17 10:37:00 -03:00
..
adb.c	adb: change handler only when recognized	2016-10-28 09:38:26 +11:00
hid.c	input: Add trace event for empty keyboard queue	2017-05-03 14:20:12 +02:00
lm832x.c	i2c: Allow I2C devices to NAK start events	2017-01-09 11:40:20 +00:00
Makefile.objs	virtio-input: Fix device introspection on non-Linux hosts	2015-10-09 15:25:56 +02:00
milkymist-softusb.c	include/qemu/osdep.h: Don't include qapi/error.h	2016-03-22 22:20:15 +01:00
pckbd.c	pc: simplify passing qemu_irq	2016-09-08 18:05:21 +04:00
pl050.c	hw: explicitly include qemu/log.h	2016-05-19 16:42:29 +02:00
ps2.c	ps2: add support for mice with extra/side buttons	2017-01-31 08:14:51 +01:00
pxa2xx_keypad.c	arm: Clean up includes	2016-01-29 15:07:23 +00:00
stellaris_input.c	arm: Clean up includes	2016-01-29 15:07:23 +00:00
trace-events	input: Add trace event for empty keyboard queue	2017-05-03 14:20:12 +02:00
tsc210x.c	vmstateify tsc210x	2016-10-04 13:28:08 +01:00
tsc2005.c	vmstateify tsc2005	2016-10-04 13:28:08 +01:00
virtio-input-hid.c	ui: Support non-zero minimum values for absolute input axes	2017-05-11 09:42:16 +02:00
virtio-input-host.c	virtio-input: support absolute axis config in pass-through	2016-04-13 17:26:12 +02:00
virtio-input.c	virtio-input: fix eventq batching	2017-03-27 12:14:45 +02:00
vmmouse.c	qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable	2017-05-17 10:37:00 -03:00