mirror of
https://github.com/xemu-project/xemu.git
synced 2024-12-19 01:37:15 +00:00
1c6d75d5f7
"qom-list-types abstract=false" currently returns all interface types, as if they were not abstract. Fix this by making sure all interface types are abstract. All interface types have instance_size == 0, so we can use it to set abstract=true on type_initialize(). Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Message-Id: <1481567461-2341-1-git-send-email-ehabkost@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
178 lines
4.4 KiB
C
178 lines
4.4 KiB
C
/*
|
|
* Device introspection test cases
|
|
*
|
|
* Copyright (c) 2015 Red Hat Inc.
|
|
*
|
|
* Authors:
|
|
* Markus Armbruster <armbru@redhat.com>,
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
/*
|
|
* Covers QMP device-list-properties and HMP device_add help. We
|
|
* currently don't check that their output makes sense, only that QEMU
|
|
* survives. Useful since we've had an astounding number of crash
|
|
* bugs around here.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qemu-common.h"
|
|
#include "qapi/qmp/qstring.h"
|
|
#include "qapi/qmp/qbool.h"
|
|
#include "qapi/qmp/qdict.h"
|
|
#include "libqtest.h"
|
|
|
|
const char common_args[] = "-nodefaults -machine none";
|
|
|
|
static QList *qom_list_types(const char *implements, bool abstract)
|
|
{
|
|
QDict *resp;
|
|
QList *ret;
|
|
QDict *args = qdict_new();
|
|
|
|
qdict_put(args, "abstract", qbool_from_bool(abstract));
|
|
if (implements) {
|
|
qdict_put(args, "implements", qstring_from_str(implements));
|
|
}
|
|
resp = qmp("{'execute': 'qom-list-types',"
|
|
" 'arguments': %p }", args);
|
|
g_assert(qdict_haskey(resp, "return"));
|
|
ret = qdict_get_qlist(resp, "return");
|
|
QINCREF(ret);
|
|
QDECREF(resp);
|
|
return ret;
|
|
}
|
|
|
|
static QList *device_type_list(bool abstract)
|
|
{
|
|
return qom_list_types("device", abstract);
|
|
}
|
|
|
|
static void test_one_device(const char *type)
|
|
{
|
|
QDict *resp;
|
|
char *help, *qom_tree;
|
|
|
|
resp = qmp("{'execute': 'device-list-properties',"
|
|
" 'arguments': {'typename': %s}}",
|
|
type);
|
|
QDECREF(resp);
|
|
|
|
help = hmp("device_add \"%s,help\"", type);
|
|
g_free(help);
|
|
|
|
/*
|
|
* Some devices leave dangling pointers in QOM behind.
|
|
* "info qom-tree" has a good chance at crashing then
|
|
*/
|
|
qom_tree = hmp("info qom-tree");
|
|
g_free(qom_tree);
|
|
}
|
|
|
|
static void test_device_intro_list(void)
|
|
{
|
|
QList *types;
|
|
char *help;
|
|
|
|
qtest_start(common_args);
|
|
|
|
types = device_type_list(true);
|
|
QDECREF(types);
|
|
|
|
help = hmp("device_add help");
|
|
g_free(help);
|
|
|
|
qtest_end();
|
|
}
|
|
|
|
static void test_device_intro_none(void)
|
|
{
|
|
qtest_start(common_args);
|
|
test_one_device("nonexistent");
|
|
qtest_end();
|
|
}
|
|
|
|
static void test_device_intro_abstract(void)
|
|
{
|
|
qtest_start(common_args);
|
|
test_one_device("device");
|
|
qtest_end();
|
|
}
|
|
|
|
static void test_device_intro_concrete(void)
|
|
{
|
|
QList *types;
|
|
QListEntry *entry;
|
|
const char *type;
|
|
|
|
qtest_start(common_args);
|
|
types = device_type_list(false);
|
|
|
|
QLIST_FOREACH_ENTRY(types, entry) {
|
|
type = qdict_get_try_str(qobject_to_qdict(qlist_entry_obj(entry)),
|
|
"name");
|
|
g_assert(type);
|
|
test_one_device(type);
|
|
}
|
|
|
|
QDECREF(types);
|
|
qtest_end();
|
|
}
|
|
|
|
static void test_abstract_interfaces(void)
|
|
{
|
|
QList *all_types;
|
|
QList *obj_types;
|
|
QListEntry *ae;
|
|
|
|
qtest_start(common_args);
|
|
/* qom-list-types implements=interface would return any type
|
|
* that implements _any_ interface (not just interface types),
|
|
* so use a trick to find the interface type names:
|
|
* - list all object types
|
|
* - list all types, and look for items that are not
|
|
* on the first list
|
|
*/
|
|
all_types = qom_list_types(NULL, false);
|
|
obj_types = qom_list_types("object", false);
|
|
|
|
QLIST_FOREACH_ENTRY(all_types, ae) {
|
|
QDict *at = qobject_to_qdict(qlist_entry_obj(ae));
|
|
const char *aname = qdict_get_str(at, "name");
|
|
QListEntry *oe;
|
|
const char *found = NULL;
|
|
|
|
QLIST_FOREACH_ENTRY(obj_types, oe) {
|
|
QDict *ot = qobject_to_qdict(qlist_entry_obj(oe));
|
|
const char *oname = qdict_get_str(ot, "name");
|
|
if (!strcmp(aname, oname)) {
|
|
found = oname;
|
|
break;
|
|
}
|
|
}
|
|
|
|
/* Using g_assert_cmpstr() will give more useful failure
|
|
* messages than g_assert(found) */
|
|
g_assert_cmpstr(aname, ==, found);
|
|
}
|
|
|
|
QDECREF(all_types);
|
|
QDECREF(obj_types);
|
|
qtest_end();
|
|
}
|
|
|
|
int main(int argc, char **argv)
|
|
{
|
|
g_test_init(&argc, &argv, NULL);
|
|
|
|
qtest_add_func("device/introspect/list", test_device_intro_list);
|
|
qtest_add_func("device/introspect/none", test_device_intro_none);
|
|
qtest_add_func("device/introspect/abstract", test_device_intro_abstract);
|
|
qtest_add_func("device/introspect/concrete", test_device_intro_concrete);
|
|
qtest_add_func("device/introspect/abstract-interfaces", test_abstract_interfaces);
|
|
|
|
return g_test_run();
|
|
}
|