Mark Cave-Ayland 441f6692ec fdc: fix segfault in fdctrl_stop_transfer() when DMA is disabled ... Commit c8a35f1cf0 "fdc: use IsaDma interface instead of global DMA_* functions" accidentally introduced a segfault in fdctrl_stop_transfer() for non-DMA transfers. If fdctrl->dma_chann has not been configured then the fdctrl->dma interface reference isn't initialised during isabus_fdc_realize(). Unfortunately fdctrl_stop_transfer() unconditionally references the DMA interface when finishing the transfer causing a NULL pointer dereference. Fix the issue by adding a check in fdctrl_stop_transfer() so that the DMA interface reference and release method is only invoked if fdctrl->dma_chann has been set. (This issue was discovered by Martin testing a recent change in the NetBSD installer under qemu-system-sparc) Cc: qemu-stable@nongnu.org Reported-by: Martin Husemann <martin@duskware.de> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Hervé Poussineau <hpoussin@reactos.org> Reviewed-by: John Snow <jsnow@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>		2018-11-19 12:51:22 +01:00
..
9pfs	9p: write lock path in v9fs_co_open2()	2018-11-08 21:19:05 +01:00
acpi	hw/acpi/nvdimm: Don't take address of fields in packed structs	2018-11-12 15:14:06 +00:00
adc	Include qapi/error.h exactly where needed	2018-02-09 13:50:17 +01:00
alpha	hw/alpha/typhoon: Remove unuseful code	2018-10-24 06:44:59 -03:00
arm	hw/arm/sysbus-fdt: Only call match_fn callback if the type matches	2018-11-13 10:47:58 +00:00
audio	audio: use TYPE_MV88W8618_AUDIO instead of hardcoded string	2018-10-29 13:50:15 +01:00
block	fdc: fix segfault in fdctrl_stop_transfer() when DMA is disabled	2018-11-19 12:51:22 +01:00
bt	hw/bt: Replace fprintf(stderr, "*\n" with error_report()	2018-01-22 09:51:00 +01:00
char	hw/char: Implement nRF51 SoC UART	2018-11-02 14:03:33 +00:00
core	Machine queue, 2018-10-25	2018-10-25 20:17:12 +01:00
cpu	hw/cpu/a15mpcore: If CPU has EL2, enable it on the GIC and wire it up	2018-08-24 13:17:34 +01:00
cris	hw/cris: Use the IEC binary prefix definitions	2018-07-02 15:41:15 +02:00
display	edid: silence a stringop-overflow warning	2018-11-12 14:14:18 +01:00
dma	hw/dma/pl080: Remove hw_error() if DMA is enabled	2018-08-20 11:24:33 +01:00
gpio	hw/i2c: Use DeviceClass::realize instead of I2CSlaveClass::init	2018-06-01 15:14:31 +02:00
hppa	hw/hppa/dino: Remove unuseful code	2018-10-24 06:44:59 -03:00
hyperv	hyperv_testdev: add SynIC message and event testmodes	2018-10-19 13:44:14 +02:00
i2c	i2c: switch ddc to use the new edid generator	2018-10-15 09:57:33 +02:00
i386	x86_iommu/amd: Enable Guest virtual APIC support	2018-11-05 13:24:02 -05:00
ide	replay: replay BH for IDE trim operation	2018-10-02 19:09:13 +02:00
input	ps2: prevent changing irq state on save and load	2018-10-02 18:47:55 +02:00
intc	target/arm: Move some system registers into a substructure	2018-10-24 07:50:16 +01:00
ipack	hw/ipack: Use the IEC binary prefix definitions	2018-07-02 15:41:12 +02:00
ipmi	ipmi: Use proper struct reference for BT vmstate	2018-08-23 18:46:25 +02:00
isa	configs: Add a CONFIG_SMC37C669 switch for the "smc37c669-superio" device	2018-10-24 07:33:44 +01:00
lm32	milkymist: Check for failure trying to load BIOS image	2018-11-06 11:32:14 +00:00
m68k	hw/m68k: Use the IEC binary prefix definitions	2018-07-02 15:41:14 +02:00
mem	nvdimm: set non-volatile on the memory region	2018-11-06 21:35:05 +01:00
microblaze	hw/microblaze/xlnx-zynqmp-pmu: Fix introspection problem in 'xlnx, zynqmp-pmu-soc'	2018-07-23 15:21:25 +01:00
mips	hw/mips/malta: Remove unuseful code	2018-10-24 06:44:59 -03:00
misc	pc-testdev: use HTTPS git URL	2018-11-12 11:26:02 +00:00
moxie	change get_image_size return type to int64_t	2018-10-02 19:08:49 +02:00
net	QEMU trivial patches collected between June and October 2018	2018-10-30 15:49:55 +00:00
nios2	hw/nios2: Use the IEC binary prefix definitions	2018-07-02 15:41:15 +02:00
nvram	ppc: move at24c to its own CONFIG_ symbol	2018-10-30 09:12:09 +01:00
openrisc	Change references to serial_hds[] to serial_hd()	2018-04-26 13:57:00 +01:00
pci	pci_bridge: fix typo in comment	2018-11-05 13:24:02 -05:00
pci-bridge	hw/pci-bridge/ioh3420: Remove unuseful header	2018-11-05 13:24:02 -05:00
pci-host	ppc patch queue 2018-11-08	2018-11-08 14:42:37 +00:00
pcmcia	hw: Clean up includes	2016-01-29 15:07:25 +00:00
ppc	ppc/spapr_caps: Add SPAPR_CAP_NESTED_KVM_HV	2018-11-08 13:08:35 +11:00
rdma	config: split PVRDMA from RDMA	2018-08-18 18:01:34 +03:00
riscv	hw/riscv/virt: Free the test device tree node name	2018-11-13 15:12:13 -08:00
s390x	s390x/pci: properly fail if the zPCI device cannot be created	2018-11-13 16:46:55 +01:00
scsi	* icount fix (Clement)	2018-11-08 10:01:51 +00:00
sd	ssi-sd: Make devices picking up backends unavailable with -device	2018-10-24 07:50:16 +01:00
sh4	hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init	2018-10-24 06:44:59 -03:00
smbios	smbios: Clean up error handling in smbios_add()	2018-10-19 14:51:34 +02:00
sparc	sun4m: don't use legacy fw_cfg_init_mem() function	2018-08-20 19:18:31 +01:00
sparc64	hw/sparc64/niagara: Model the I/O Bridge with the 'unimplemented_device'	2018-10-24 06:44:59 -03:00
ssi	hw/ssi/xilinx_spi: Use DeviceState::realize rather than SysBusDevice::init	2018-10-24 06:44:59 -03:00
timer	hw/timer/sun4v-rtc: Use DeviceState::realize rather than SysBusDevice::init	2018-10-24 06:44:59 -03:00
tpm	tpm: use loop iterator to set sts data field	2018-11-14 15:47:24 -05:00
tricore	hw/tricore: Use the IEC binary prefix definitions	2018-07-02 15:41:14 +02:00
unicore32	hw/input/i8042: Extract declarations from i386/pc.h into input/i8042.h	2018-03-12 16:12:48 +01:00
usb	usb: fixes for ohci and smart card emulation.	2018-10-30 13:32:38 +00:00
vfio	s390x/vfio-ap: report correct error	2018-11-05 09:55:01 +01:00
virtio	Error reporting patches for 2018-10-22	2018-10-23 17:20:23 +01:00
watchdog	qapi: Drop qapi_event_send_FOO()'s Error ** argument	2018-08-28 18:21:38 +02:00
xen	xen: Use the PCI_DEVICE macro	2018-10-26 17:17:32 +02:00
xenpv	hw/xen: Use the IEC binary prefix definitions	2018-07-02 15:41:13 +02:00
xtensa	hw/xtensa: Use the IEC binary prefix definitions	2018-07-02 15:41:14 +02:00
Makefile.objs	memory-device: introduce separate config option	2018-10-24 06:44:59 -03:00