mirror of
https://github.com/xemu-project/xemu.git
synced 2024-11-30 23:10:38 +00:00
2ec063788e
I was setting gpioV4-7 to "1110" using the QOM pin property handler and
noticed that lowering gpioV7 was inadvertently lowering gpioV4-6 too.
(qemu) qom-set /machine/soc/gpio gpioV4 true
(qemu) qom-set /machine/soc/gpio gpioV5 true
(qemu) qom-set /machine/soc/gpio gpioV6 true
(qemu) qom-get /machine/soc/gpio gpioV4
true
(qemu) qom-set /machine/soc/gpio gpioV7 false
(qemu) qom-get /machine/soc/gpio gpioV4
false
An expression in aspeed_gpio_set_pin_level was using a logical NOT
operator instead of a bitwise NOT operator:
value &= !pin_mask;
The original author probably intended to make a bitwise NOT expression
"~", but mistakenly used a logical NOT operator "!" instead. Some
programming languages like Rust use "!" for both purposes.
Fixes: 4b7f956862 ("hw/gpio: Add basic Aspeed GPIO model for AST2400 and
AST2500")
Signed-off-by: Peter Delevoryas <pdel@fb.com>
Message-Id: <20220502080827.244815-1-pdel@fb.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
88 lines
3.0 KiB
C
88 lines
3.0 KiB
C
/*
|
|
* QTest testcase for the Aspeed GPIO Controller.
|
|
*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates. (http://www.meta.com)
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qemu/bitops.h"
|
|
#include "qemu/timer.h"
|
|
#include "qapi/qmp/qdict.h"
|
|
#include "libqtest-single.h"
|
|
|
|
static bool qom_get_bool(QTestState *s, const char *path, const char *property)
|
|
{
|
|
QDict *r;
|
|
bool b;
|
|
|
|
r = qtest_qmp(s, "{ 'execute': 'qom-get', 'arguments': "
|
|
"{ 'path': %s, 'property': %s } }", path, property);
|
|
b = qdict_get_bool(r, "return");
|
|
qobject_unref(r);
|
|
|
|
return b;
|
|
}
|
|
|
|
static void qom_set_bool(QTestState *s, const char *path, const char *property,
|
|
bool value)
|
|
{
|
|
QDict *r;
|
|
|
|
r = qtest_qmp(s, "{ 'execute': 'qom-set', 'arguments': "
|
|
"{ 'path': %s, 'property': %s, 'value': %i } }",
|
|
path, property, value);
|
|
qobject_unref(r);
|
|
}
|
|
|
|
static void test_set_colocated_pins(const void *data)
|
|
{
|
|
QTestState *s = (QTestState *)data;
|
|
|
|
/*
|
|
* gpioV4-7 occupy bits within a single 32-bit value, so we want to make
|
|
* sure that modifying one doesn't affect the other.
|
|
*/
|
|
qom_set_bool(s, "/machine/soc/gpio", "gpioV4", true);
|
|
qom_set_bool(s, "/machine/soc/gpio", "gpioV5", false);
|
|
qom_set_bool(s, "/machine/soc/gpio", "gpioV6", true);
|
|
qom_set_bool(s, "/machine/soc/gpio", "gpioV7", false);
|
|
g_assert(qom_get_bool(s, "/machine/soc/gpio", "gpioV4"));
|
|
g_assert(!qom_get_bool(s, "/machine/soc/gpio", "gpioV5"));
|
|
g_assert(qom_get_bool(s, "/machine/soc/gpio", "gpioV6"));
|
|
g_assert(!qom_get_bool(s, "/machine/soc/gpio", "gpioV7"));
|
|
}
|
|
|
|
int main(int argc, char **argv)
|
|
{
|
|
QTestState *s;
|
|
int r;
|
|
|
|
g_test_init(&argc, &argv, NULL);
|
|
|
|
s = qtest_init("-machine ast2600-evb");
|
|
qtest_add_data_func("/ast2600/gpio/set_colocated_pins", s,
|
|
test_set_colocated_pins);
|
|
r = g_test_run();
|
|
qtest_quit(s);
|
|
|
|
return r;
|
|
}
|