mirror of
https://github.com/xemu-project/xemu.git
synced 2024-12-01 07:21:09 +00:00
d2623129a7
The only way object_property_add() can fail is when a property with the same name already exists. Since our property names are all hardcoded, failure is a programming error, and the appropriate way to handle it is passing &error_abort. Same for its variants, except for object_property_add_child(), which additionally fails when the child already has a parent. Parentage is also under program control, so this is a programming error, too. We have a bit over 500 callers. Almost half of them pass &error_abort, slightly fewer ignore errors, one test case handles errors, and the remaining few callers pass them to their own callers. The previous few commits demonstrated once again that ignoring programming errors is a bad idea. Of the few ones that pass on errors, several violate the Error API. The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. ich9_pm_add_properties(), sparc32_ledma_realize(), sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize() are wrong that way. When the one appropriate choice of argument is &error_abort, letting users pick the argument is a bad idea. Drop parameter @errp and assert the preconditions instead. There's one exception to "duplicate property name is a programming error": the way object_property_add() implements the magic (and undocumented) "automatic arrayification". Don't drop @errp there. Instead, rename object_property_add() to object_property_try_add(), and add the obvious wrapper object_property_add(). Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Message-Id: <20200505152926.18877-15-armbru@redhat.com> [Two semantic rebase conflicts resolved]
219 lines
6.1 KiB
C
219 lines
6.1 KiB
C
/*
|
|
* QEMU Host Memory Backend for hugetlbfs
|
|
*
|
|
* Copyright (C) 2013-2014 Red Hat Inc
|
|
*
|
|
* Authors:
|
|
* Paolo Bonzini <pbonzini@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qapi/error.h"
|
|
#include "qemu/error-report.h"
|
|
#include "qemu/module.h"
|
|
#include "sysemu/hostmem.h"
|
|
#include "sysemu/sysemu.h"
|
|
#include "qom/object_interfaces.h"
|
|
|
|
#define MEMORY_BACKEND_FILE(obj) \
|
|
OBJECT_CHECK(HostMemoryBackendFile, (obj), TYPE_MEMORY_BACKEND_FILE)
|
|
|
|
typedef struct HostMemoryBackendFile HostMemoryBackendFile;
|
|
|
|
struct HostMemoryBackendFile {
|
|
HostMemoryBackend parent_obj;
|
|
|
|
char *mem_path;
|
|
uint64_t align;
|
|
bool discard_data;
|
|
bool is_pmem;
|
|
};
|
|
|
|
static void
|
|
file_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)
|
|
{
|
|
#ifndef CONFIG_POSIX
|
|
error_setg(errp, "backend '%s' not supported on this host",
|
|
object_get_typename(OBJECT(backend)));
|
|
#else
|
|
HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(backend);
|
|
gchar *name;
|
|
|
|
if (!backend->size) {
|
|
error_setg(errp, "can't create backend with size 0");
|
|
return;
|
|
}
|
|
if (!fb->mem_path) {
|
|
error_setg(errp, "mem-path property not set");
|
|
return;
|
|
}
|
|
|
|
name = host_memory_backend_get_name(backend);
|
|
memory_region_init_ram_from_file(&backend->mr, OBJECT(backend),
|
|
name,
|
|
backend->size, fb->align,
|
|
(backend->share ? RAM_SHARED : 0) |
|
|
(fb->is_pmem ? RAM_PMEM : 0),
|
|
fb->mem_path, errp);
|
|
g_free(name);
|
|
#endif
|
|
}
|
|
|
|
static char *get_mem_path(Object *o, Error **errp)
|
|
{
|
|
HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
|
|
|
|
return g_strdup(fb->mem_path);
|
|
}
|
|
|
|
static void set_mem_path(Object *o, const char *str, Error **errp)
|
|
{
|
|
HostMemoryBackend *backend = MEMORY_BACKEND(o);
|
|
HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
|
|
|
|
if (host_memory_backend_mr_inited(backend)) {
|
|
error_setg(errp, "cannot change property 'mem-path' of %s",
|
|
object_get_typename(o));
|
|
return;
|
|
}
|
|
g_free(fb->mem_path);
|
|
fb->mem_path = g_strdup(str);
|
|
}
|
|
|
|
static bool file_memory_backend_get_discard_data(Object *o, Error **errp)
|
|
{
|
|
return MEMORY_BACKEND_FILE(o)->discard_data;
|
|
}
|
|
|
|
static void file_memory_backend_set_discard_data(Object *o, bool value,
|
|
Error **errp)
|
|
{
|
|
MEMORY_BACKEND_FILE(o)->discard_data = value;
|
|
}
|
|
|
|
static void file_memory_backend_get_align(Object *o, Visitor *v,
|
|
const char *name, void *opaque,
|
|
Error **errp)
|
|
{
|
|
HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
|
|
uint64_t val = fb->align;
|
|
|
|
visit_type_size(v, name, &val, errp);
|
|
}
|
|
|
|
static void file_memory_backend_set_align(Object *o, Visitor *v,
|
|
const char *name, void *opaque,
|
|
Error **errp)
|
|
{
|
|
HostMemoryBackend *backend = MEMORY_BACKEND(o);
|
|
HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
|
|
Error *local_err = NULL;
|
|
uint64_t val;
|
|
|
|
if (host_memory_backend_mr_inited(backend)) {
|
|
error_setg(&local_err, "cannot change property '%s' of %s",
|
|
name, object_get_typename(o));
|
|
goto out;
|
|
}
|
|
|
|
visit_type_size(v, name, &val, &local_err);
|
|
if (local_err) {
|
|
goto out;
|
|
}
|
|
fb->align = val;
|
|
|
|
out:
|
|
error_propagate(errp, local_err);
|
|
}
|
|
|
|
static bool file_memory_backend_get_pmem(Object *o, Error **errp)
|
|
{
|
|
return MEMORY_BACKEND_FILE(o)->is_pmem;
|
|
}
|
|
|
|
static void file_memory_backend_set_pmem(Object *o, bool value, Error **errp)
|
|
{
|
|
HostMemoryBackend *backend = MEMORY_BACKEND(o);
|
|
HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
|
|
|
|
if (host_memory_backend_mr_inited(backend)) {
|
|
|
|
error_setg(errp, "cannot change property 'pmem' of %s.",
|
|
object_get_typename(o));
|
|
return;
|
|
}
|
|
|
|
#ifndef CONFIG_LIBPMEM
|
|
if (value) {
|
|
Error *local_err = NULL;
|
|
|
|
error_setg(&local_err,
|
|
"Lack of libpmem support while setting the 'pmem=on'"
|
|
" of %s. We can't ensure data persistence.",
|
|
object_get_typename(o));
|
|
error_propagate(errp, local_err);
|
|
return;
|
|
}
|
|
#endif
|
|
|
|
fb->is_pmem = value;
|
|
}
|
|
|
|
static void file_backend_unparent(Object *obj)
|
|
{
|
|
HostMemoryBackend *backend = MEMORY_BACKEND(obj);
|
|
HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(obj);
|
|
|
|
if (host_memory_backend_mr_inited(backend) && fb->discard_data) {
|
|
void *ptr = memory_region_get_ram_ptr(&backend->mr);
|
|
uint64_t sz = memory_region_size(&backend->mr);
|
|
|
|
qemu_madvise(ptr, sz, QEMU_MADV_REMOVE);
|
|
}
|
|
}
|
|
|
|
static void
|
|
file_backend_class_init(ObjectClass *oc, void *data)
|
|
{
|
|
HostMemoryBackendClass *bc = MEMORY_BACKEND_CLASS(oc);
|
|
|
|
bc->alloc = file_backend_memory_alloc;
|
|
oc->unparent = file_backend_unparent;
|
|
|
|
object_class_property_add_bool(oc, "discard-data",
|
|
file_memory_backend_get_discard_data, file_memory_backend_set_discard_data);
|
|
object_class_property_add_str(oc, "mem-path",
|
|
get_mem_path, set_mem_path);
|
|
object_class_property_add(oc, "align", "int",
|
|
file_memory_backend_get_align,
|
|
file_memory_backend_set_align,
|
|
NULL, NULL);
|
|
object_class_property_add_bool(oc, "pmem",
|
|
file_memory_backend_get_pmem, file_memory_backend_set_pmem);
|
|
}
|
|
|
|
static void file_backend_instance_finalize(Object *o)
|
|
{
|
|
HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
|
|
|
|
g_free(fb->mem_path);
|
|
}
|
|
|
|
static const TypeInfo file_backend_info = {
|
|
.name = TYPE_MEMORY_BACKEND_FILE,
|
|
.parent = TYPE_MEMORY_BACKEND,
|
|
.class_init = file_backend_class_init,
|
|
.instance_finalize = file_backend_instance_finalize,
|
|
.instance_size = sizeof(HostMemoryBackendFile),
|
|
};
|
|
|
|
static void register_types(void)
|
|
{
|
|
type_register_static(&file_backend_info);
|
|
}
|
|
|
|
type_init(register_types);
|