xemu-project/xemu
1
0
Fork 0
mirror of https://github.com/xemu-project/xemu.git synced 2024-12-12 14:05:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
7c91aabd89
xemu/include/qapi
History
Eric Blake 7c91aabd89 qapi-visit: Kill unused visit_end_union() 
The generated code can call visit_end_union() without having called
visit_start_union().  Example:

        if (!*obj) {
            goto out_obj;
        }
        visit_type_CpuInfoBase_fields(v, (CpuInfoBase **)obj, &err);
        if (err) {
            goto out_obj; // if we go from here...
        }
        if (!visit_start_union(v, !!(*obj)->u.data, &err) || err) {
            goto out_obj;
        }
        switch ((*obj)->arch) {
    [...]
        }
    out_obj:
        // ... then *obj is true, and ...
        error_propagate(errp, err);
        err = NULL;
        if (*obj) {
            // we end up here
            visit_end_union(v, !!(*obj)->u.data, &err);
        }
        error_propagate(errp, err);

Harmless only because no visitor implements end_union().  Clean it up
anyway, by deleting the function as useless.

Messed up since we have visit_end_union (commit cee2ded).

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1453902888-20457-3-git-send-email-armbru@redhat.com>
[expand scope of patch to delete rather than repair]
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1454075341-13658-13-git-send-email-eblake@redhat.com>
2016-02-08 17:29:55 +01:00
..
qmp qapi: Convert QType into QAPI built-in enum type 2015-12-17 08:21:28 +01:00
dealloc-visitor.h
error.h error: New error_prepend(), error_reportf_err() 2016-01-13 15:16:17 +01:00
opts-visitor.h
qmp-event.h
qmp-input-visitor.h
qmp-output-visitor.h
string-input-visitor.h
string-output-visitor.h
util.h qom: Make enum string tables const-correct 2015-06-19 18:42:18 +02:00
visitor-impl.h qapi-visit: Kill unused visit_end_union() 2016-02-08 17:29:55 +01:00
visitor.h qapi-visit: Kill unused visit_end_union() 2016-02-08 17:29:55 +01:00