mirror of
https://github.com/xemu-project/xemu.git
synced 2024-11-27 13:30:52 +00:00
de38b5005e
Disk sizes close to INT64_MAX cause overflow, for some pretty ridiculous output: $ ./nbdkit -U - memory size=$((2**63 - 512)) --run 'qemu-img info $nbd' image: nbd+unix://?socket=/tmp/nbdkitHSAzNz/socket file format: raw virtual size: -8388607T (9223372036854775296 bytes) disk size: unavailable But there's no reason to have two separate implementations of integer to human-readable abbreviation, where one has overflow and stops at 'T', while the other avoids overflow and goes all the way to 'E'. With this patch, the output now claims 8EiB instead of -8388607T, which really is the correct rounding of largest file size supported by qemu (we could go 511 bytes larger if we used byte-accurate sizing instead of rounding up to the next sector boundary, but that wouldn't change the human-readable result). Quite a few iotests need updates to expected output to match. Reported-by: Richard W.M. Jones <rjones@redhat.com> Signed-off-by: Eric Blake <eblake@redhat.com> Tested-by: Richard W.M. Jones <rjones@redhat.com> Reviewed-by: Alberto Garcia <berto@igalia.com> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com> Tested-by: Max Reitz <mreitz@redhat.com>
69 lines
2.4 KiB
Plaintext
69 lines
2.4 KiB
Plaintext
QA output created by 043
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
|
|
|
|
== backing file references self ==
|
|
qemu-img: Backing file 'TEST_DIR/t.IMGFMT' creates an infinite loop.
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 backing_file=TEST_DIR/t.IMGFMT.base
|
|
|
|
== parent references self ==
|
|
qemu-img: Backing file 'TEST_DIR/t.IMGFMT' creates an infinite loop.
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 backing_file=TEST_DIR/t.IMGFMT.1.base
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 backing_file=TEST_DIR/t.IMGFMT.2.base
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 backing_file=TEST_DIR/t.IMGFMT.3.base
|
|
|
|
== ancestor references another ancestor ==
|
|
qemu-img: Backing file 'TEST_DIR/t.IMGFMT.2.base' creates an infinite loop.
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 backing_file=TEST_DIR/t.IMGFMT.1.base
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 backing_file=TEST_DIR/t.IMGFMT.2.base
|
|
|
|
== finite chain of length 3 (human) ==
|
|
image: TEST_DIR/t.IMGFMT
|
|
file format: IMGFMT
|
|
virtual size: 128 MiB (134217728 bytes)
|
|
cluster_size: 65536
|
|
backing file: TEST_DIR/t.IMGFMT.2.base
|
|
|
|
image: TEST_DIR/t.IMGFMT.2.base
|
|
file format: IMGFMT
|
|
virtual size: 128 MiB (134217728 bytes)
|
|
cluster_size: 65536
|
|
backing file: TEST_DIR/t.IMGFMT.1.base
|
|
|
|
image: TEST_DIR/t.IMGFMT.1.base
|
|
file format: IMGFMT
|
|
virtual size: 128 MiB (134217728 bytes)
|
|
cluster_size: 65536
|
|
|
|
== finite chain of length 3 (json) ==
|
|
[
|
|
{
|
|
"virtual-size": 134217728,
|
|
"filename": "TEST_DIR/t.IMGFMT",
|
|
"cluster-size": 65536,
|
|
"format": "IMGFMT",
|
|
"full-backing-filename": "TEST_DIR/t.IMGFMT.2.base",
|
|
"backing-filename": "TEST_DIR/t.IMGFMT.2.base",
|
|
"dirty-flag": false
|
|
},
|
|
{
|
|
"virtual-size": 134217728,
|
|
"filename": "TEST_DIR/t.IMGFMT.2.base",
|
|
"cluster-size": 65536,
|
|
"format": "IMGFMT",
|
|
"full-backing-filename": "TEST_DIR/t.IMGFMT.1.base",
|
|
"backing-filename": "TEST_DIR/t.IMGFMT.1.base",
|
|
"dirty-flag": false
|
|
},
|
|
{
|
|
"virtual-size": 134217728,
|
|
"filename": "TEST_DIR/t.IMGFMT.1.base",
|
|
"cluster-size": 65536,
|
|
"format": "IMGFMT",
|
|
"dirty-flag": false
|
|
}
|
|
]
|
|
*** done
|