Eduardo Habkost d769f0dfee qom: Don't keep error value between object_property_parse() calls ... When handling errp==NULL at object_apply_global_props(), we are leaving the old error value in `err` after printing a warning. This makes QEMU crash if two global properties generate warnings: $ echo device_add rtl8139 | qemu-system-x86_64 -monitor stdio -global rtl8139.xxx=yyy -global rtl8139.xxx=zzz warning: can't apply global rtl8139.xxx=yyy: Property '.xxx' not found qemu-system-x86_64: util/error.c:57: error_setv: Assertion `*errp == NULL' failed. Aborted (core dumped) Fix that by making `err` go out of scope immediately after the warn_report_err() call. Fixes: 50545b2cc0 "qdev-props: call object_apply_global_props()" Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Message-Id: <20190110020259.8492-2-ehabkost@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Cornelia Huck <cohuck@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>		2019-01-10 12:25:15 -02:00
..
container.c	container: don't leak container reference	2017-05-04 15:34:41 +04:00
cpu.c	qdev-props: remove errp from GlobalProperty	2019-01-07 16:18:42 +04:00
Makefile.objs	qom: allow QOM to be linked into tools binaries	2015-09-15 14:35:39 +01:00
object_interfaces.c	qom: make user_creatable_complete() specific to UserCreatable	2018-12-11 15:45:22 -02:00
object.c	qom: Don't keep error value between object_property_parse() calls	2019-01-10 12:25:15 -02:00
qom-qobject.c	qapi: Drop unused non-strict qobject input visitor	2017-03-05 09:14:19 +01:00
trace-events	docs: fix broken paths to docs/devel/tracing.txt	2017-07-31 13:12:53 +03:00