Daniel P. Berrangé 977a7204ab tests: don't silence error reporting for all tests ... The test-vmstate test is a bit chatty because it triggers various expected failure scenarios and the code in question uses error_report instead of accepting 'Error **errp' parameters. To silence this test the stubs for error_vprintf() were changed to send errors via g_test_message() instead of stderr: commit 28017e010d Author: Paolo Bonzini <pbonzini@redhat.com> Date: Mon Oct 24 18:31:03 2016 +0200 tests: send error_report to test log Implement error_vprintf to send the output of error_report to the test log. This silences test-vmstate. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Message-Id: <1477326663-67817-3-git-send-email-pbonzini@redhat.com> Unfortunately this change has global impact across the entire test suite and means that when tests fail for unexpected reasons, the message is not displayed on stderr. eg when using &error_abort in a call the test merely prints Unexpected error in qcrypto_tls_session_check_certificate() at crypto/tlssession.c:280: and the actual error message is hidden, making it impossible to diagnose the failure. This is especially problematic in CI or build systems where it isn't possible to easily pass the --debug-log flag to tests and re-run with the test log visible. This change makes the previous big hammer much more nuanced, providing a flag in the stub error_vprintf() that can used on a per-test basis to silence the errors. Only the test-vmstate silences errors initially. Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>		2018-07-24 17:35:23 +01:00
..
arch-query-cpu-def.c
arch-query-cpu-model-baseline.c
arch-query-cpu-model-comparison.c
arch-query-cpu-model-expansion.c
bdrv-next-monitor-owned.c
blk-commit-all.c
blockdev-close-all-bdrv-states.c
change-state-handler.c
clock-warp.c
cpu-get-clock.c
cpu-get-icount.c
dump.c
error-printf.c	tests: don't silence error reporting for all tests	2018-07-24 17:35:23 +01:00
fd-register.c
fdset.c	monitor: add lock to protect mon_fdsets	2018-06-18 15:48:22 +02:00
gdbstub.c
get-vm-name.c
iothread-lock.c
iothread.c
is-daemonized.c
linux-aio.c	linux-aio: properly bubble up errors from initialization	2018-06-27 13:06:34 +01:00
machine-init-done.c
Makefile.objs	pc-dimm: factor out MemoryDevice interface	2018-05-07 10:00:02 -03:00
migr-blocker.c
monitor.c	monitor: Fix unsafe sharing of @cur_mon among threads	2018-07-23 14:00:03 +02:00
notify-event.c
pc_madt_cpu_entry.c
pci-host-piix.c
qmp_memory_device.c	pc-dimm: factor out MemoryDevice interface	2018-05-07 10:00:02 -03:00
qtest.c
ram-block.c
replay.c
runstate-check.c
set-fd-handler.c
slirp.c
sysbus.c
target-get-monitor-def.c
target-monitor-defs.c
tpm.c
trace-control.c
uuid.c
vm-stop.c
vmgenid.c
vmstate.c
xen-common.c
xen-hvm.c