mirror of
https://github.com/xemu-project/xemu.git
synced 2024-12-12 05:56:06 +00:00
b7aa131519
The result of openfile was not checked, leading to failure deep in the
actual command with confusing error message, and exiting with exit code 0.
Here is a simple example - trying to read with the wrong format:
$ touch file
$ qemu-io -f qcow2 -c 'read -P 1 0 1024' file; echo $?
can't open device file: Image is not in qcow2 format
no file open, try 'help open'
0
With this patch, we fail earlier with exit code 1:
$ ./qemu-io -f qcow2 -c 'read -P 1 0 1024' file; echo $?
can't open device file: Image is not in qcow2 format
1
Failing earlier, we don't log this error now:
no file open, try 'help open'
But some tests expected it; the line was removed from the test output.
Signed-off-by: Nir Soffer <nirsof@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 20170201003120.23378-2-nirsof@gmail.com
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
41 lines
1.5 KiB
Plaintext
41 lines
1.5 KiB
Plaintext
QA output created by 131
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
|
|
== read empty image ==
|
|
read 65536/65536 bytes at offset 32768
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
== write more than 1 block in a row ==
|
|
wrote 131072/131072 bytes at offset 32768
|
|
128 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
== read less than block ==
|
|
read 32768/32768 bytes at offset 32768
|
|
32 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
== read exactly 1 block ==
|
|
read 65536/65536 bytes at offset 65536
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
== read more than 1 block ==
|
|
read 131072/131072 bytes at offset 32768
|
|
128 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
== check that there is no trash after written ==
|
|
read 32768/32768 bytes at offset 163840
|
|
32 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
== check that there is no trash before written ==
|
|
read 32768/32768 bytes at offset 0
|
|
32 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
== Corrupt image ==
|
|
can't open device TEST_DIR/t.parallels: parallels: Image was not closed correctly; cannot be opened read/write
|
|
ERROR image was not closed correctly
|
|
|
|
1 errors were found on the image.
|
|
Data may be corrupted, or further writes to the image may corrupt it.
|
|
Repairing image was not closed correctly
|
|
The following inconsistencies were found and repaired:
|
|
|
|
0 leaked clusters
|
|
1 corruptions
|
|
|
|
Double checking the fixed image now...
|
|
No errors were found on the image.
|
|
read 65536/65536 bytes at offset 65536
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
*** done
|