mirror of
https://github.com/xemu-project/xemu.git
synced 2024-11-25 12:40:08 +00:00
b889212973
vmport_ioport_read() returns the value that should propagate to vCPU EAX register when guest reads VMPort IOPort (i.e. By x86 IN instruction). However, because vmport_ioport_read() calls cpu_synchronize_state(), the returned value gets overridden by the value in QEMU vCPU EAX register. i.e. cpu->env.regs[R_EAX]. To fix this issue, change vmport_ioport_read() to explicitly override cpu->env.regs[R_EAX] with the value it wish to propagate to vCPU EAX register. Reviewed-by: Nikita Leshenko <nikita.leshchenko@oracle.com> Signed-off-by: Liran Alon <liran.alon@oracle.com> Message-Id: <20200312165431.82118-4-liran.alon@oracle.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
197 lines
5.6 KiB
C
197 lines
5.6 KiB
C
/*
|
|
* QEMU VMPort emulation
|
|
*
|
|
* Copyright (C) 2007 Hervé Poussineau
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
/*
|
|
* Guest code that interacts with this virtual device can be found
|
|
* in VMware open-vm-tools open-source project:
|
|
* https://github.com/vmware/open-vm-tools
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "hw/isa/isa.h"
|
|
#include "hw/qdev-properties.h"
|
|
#include "sysemu/hw_accel.h"
|
|
#include "qemu/log.h"
|
|
#include "vmport.h"
|
|
#include "cpu.h"
|
|
#include "trace.h"
|
|
|
|
#define VMPORT_CMD_GETVERSION 0x0a
|
|
#define VMPORT_CMD_GETRAMSIZE 0x14
|
|
|
|
#define VMPORT_ENTRIES 0x2c
|
|
#define VMPORT_MAGIC 0x564D5868
|
|
|
|
/* Compatibility flags for migration */
|
|
#define VMPORT_COMPAT_READ_SET_EAX_BIT 0
|
|
#define VMPORT_COMPAT_READ_SET_EAX \
|
|
(1 << VMPORT_COMPAT_READ_SET_EAX_BIT)
|
|
|
|
#define VMPORT(obj) OBJECT_CHECK(VMPortState, (obj), TYPE_VMPORT)
|
|
|
|
typedef struct VMPortState {
|
|
ISADevice parent_obj;
|
|
|
|
MemoryRegion io;
|
|
VMPortReadFunc *func[VMPORT_ENTRIES];
|
|
void *opaque[VMPORT_ENTRIES];
|
|
|
|
uint32_t compat_flags;
|
|
} VMPortState;
|
|
|
|
static VMPortState *port_state;
|
|
|
|
void vmport_register(unsigned char command, VMPortReadFunc *func, void *opaque)
|
|
{
|
|
if (command >= VMPORT_ENTRIES) {
|
|
return;
|
|
}
|
|
|
|
trace_vmport_register(command, func, opaque);
|
|
port_state->func[command] = func;
|
|
port_state->opaque[command] = opaque;
|
|
}
|
|
|
|
static uint64_t vmport_ioport_read(void *opaque, hwaddr addr,
|
|
unsigned size)
|
|
{
|
|
VMPortState *s = opaque;
|
|
CPUState *cs = current_cpu;
|
|
X86CPU *cpu = X86_CPU(cs);
|
|
CPUX86State *env = &cpu->env;
|
|
unsigned char command;
|
|
uint32_t eax;
|
|
|
|
cpu_synchronize_state(cs);
|
|
|
|
eax = env->regs[R_EAX];
|
|
if (eax != VMPORT_MAGIC) {
|
|
goto out;
|
|
}
|
|
|
|
command = env->regs[R_ECX];
|
|
trace_vmport_command(command);
|
|
if (command >= VMPORT_ENTRIES || !s->func[command]) {
|
|
qemu_log_mask(LOG_UNIMP, "vmport: unknown command %x\n", command);
|
|
goto out;
|
|
}
|
|
|
|
eax = s->func[command](s->opaque[command], addr);
|
|
|
|
out:
|
|
/*
|
|
* The call above to cpu_synchronize_state() gets vCPU registers values
|
|
* to QEMU but also cause QEMU to write QEMU vCPU registers values to
|
|
* vCPU implementation (e.g. Accelerator such as KVM) just before
|
|
* resuming guest.
|
|
*
|
|
* Therefore, in order to make IOPort return value propagate to
|
|
* guest EAX, we need to explicitly update QEMU EAX register value.
|
|
*/
|
|
if (s->compat_flags & VMPORT_COMPAT_READ_SET_EAX) {
|
|
cpu->env.regs[R_EAX] = eax;
|
|
}
|
|
|
|
return eax;
|
|
}
|
|
|
|
static void vmport_ioport_write(void *opaque, hwaddr addr,
|
|
uint64_t val, unsigned size)
|
|
{
|
|
X86CPU *cpu = X86_CPU(current_cpu);
|
|
|
|
cpu->env.regs[R_EAX] = vmport_ioport_read(opaque, addr, 4);
|
|
}
|
|
|
|
static uint32_t vmport_cmd_get_version(void *opaque, uint32_t addr)
|
|
{
|
|
X86CPU *cpu = X86_CPU(current_cpu);
|
|
|
|
cpu->env.regs[R_EBX] = VMPORT_MAGIC;
|
|
return 6;
|
|
}
|
|
|
|
static uint32_t vmport_cmd_ram_size(void *opaque, uint32_t addr)
|
|
{
|
|
X86CPU *cpu = X86_CPU(current_cpu);
|
|
|
|
cpu->env.regs[R_EBX] = 0x1177;
|
|
return ram_size;
|
|
}
|
|
|
|
static const MemoryRegionOps vmport_ops = {
|
|
.read = vmport_ioport_read,
|
|
.write = vmport_ioport_write,
|
|
.impl = {
|
|
.min_access_size = 4,
|
|
.max_access_size = 4,
|
|
},
|
|
.endianness = DEVICE_LITTLE_ENDIAN,
|
|
};
|
|
|
|
static void vmport_realizefn(DeviceState *dev, Error **errp)
|
|
{
|
|
ISADevice *isadev = ISA_DEVICE(dev);
|
|
VMPortState *s = VMPORT(dev);
|
|
|
|
memory_region_init_io(&s->io, OBJECT(s), &vmport_ops, s, "vmport", 1);
|
|
isa_register_ioport(isadev, &s->io, 0x5658);
|
|
|
|
port_state = s;
|
|
/* Register some generic port commands */
|
|
vmport_register(VMPORT_CMD_GETVERSION, vmport_cmd_get_version, NULL);
|
|
vmport_register(VMPORT_CMD_GETRAMSIZE, vmport_cmd_ram_size, NULL);
|
|
}
|
|
|
|
static Property vmport_properties[] = {
|
|
/* Used to enforce compatibility for migration */
|
|
DEFINE_PROP_BIT("x-read-set-eax", VMPortState, compat_flags,
|
|
VMPORT_COMPAT_READ_SET_EAX_BIT, true),
|
|
DEFINE_PROP_END_OF_LIST(),
|
|
};
|
|
|
|
static void vmport_class_initfn(ObjectClass *klass, void *data)
|
|
{
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
|
|
|
dc->realize = vmport_realizefn;
|
|
/* Reason: realize sets global port_state */
|
|
dc->user_creatable = false;
|
|
device_class_set_props(dc, vmport_properties);
|
|
}
|
|
|
|
static const TypeInfo vmport_info = {
|
|
.name = TYPE_VMPORT,
|
|
.parent = TYPE_ISA_DEVICE,
|
|
.instance_size = sizeof(VMPortState),
|
|
.class_init = vmport_class_initfn,
|
|
};
|
|
|
|
static void vmport_register_types(void)
|
|
{
|
|
type_register_static(&vmport_info);
|
|
}
|
|
|
|
type_init(vmport_register_types)
|