mirror of
https://github.com/xemu-project/xemu.git
synced 2024-12-14 07:18:34 +00:00
bea0279b72
The GCC 9 compiler complains about many places in s390 code
that take the address of members of the 'struct SCHIB' which
is marked packed:
hw/s390x/css.c: In function ‘sch_handle_clear_func’:
hw/s390x/css.c:698:15: warning: taking address of packed member of ‘struct SCHIB’ may result in an unaligned pointer val\
ue [-Waddress-of-packed-member]
698 | PMCW *p = &sch->curr_status.pmcw;
| ^~~~~~~~~~~~~~~~~~~~~~
hw/s390x/css.c:699:15: warning: taking address of packed member of ‘struct SCHIB’ may result in an unaligned pointer val\
ue [-Waddress-of-packed-member]
699 | SCSW *s = &sch->curr_status.scsw;
| ^~~~~~~~~~~~~~~~~~~~~~
...snip many more...
Almost all of these are just done for convenience to avoid
typing out long variable/field names when referencing struct
members. We can get most of this convenience by taking the
address of the 'struct SCHIB' instead, avoiding triggering
the compiler warnings.
In a couple of places we copy via a local variable which is
a technique already applied elsewhere in s390 code for this
problem.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20190329111104.17223-13-berrange@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
|
||
|---|---|---|
| .. | ||
| 3270-ccw.c | ||
| ap-bridge.c | ||
| ap-device.c | ||
| ccw-device.c | ||
| ccw-device.h | ||
| css-bridge.c | ||
| css.c | ||
| event-facility.c | ||
| ipl.c | ||
| ipl.h | ||
| Kconfig | ||
| Makefile.objs | ||
| s390-ccw.c | ||
| s390-pci-bus.c | ||
| s390-pci-bus.h | ||
| s390-pci-inst.c | ||
| s390-pci-inst.h | ||
| s390-skeys-kvm.c | ||
| s390-skeys.c | ||
| s390-stattrib-kvm.c | ||
| s390-stattrib.c | ||
| s390-virtio-ccw.c | ||
| s390-virtio-hcall.c | ||
| s390-virtio-hcall.h | ||
| sclp.c | ||
| sclpcpu.c | ||
| sclpquiesce.c | ||
| tod-kvm.c | ||
| tod-qemu.c | ||
| tod.c | ||
| trace-events | ||
| vhost-vsock-ccw.c | ||
| virtio-ccw-9p.c | ||
| virtio-ccw-balloon.c | ||
| virtio-ccw-blk.c | ||
| virtio-ccw-crypto.c | ||
| virtio-ccw-gpu.c | ||
| virtio-ccw-input.c | ||
| virtio-ccw-net.c | ||
| virtio-ccw-rng.c | ||
| virtio-ccw-scsi.c | ||
| virtio-ccw-serial.c | ||
| virtio-ccw.c | ||
| virtio-ccw.h | ||