Markus Armbruster d64072c0ac Revert "tpm: Clean up error reporting in tpm_init_tpmdev()" ... This reverts commit d10e05f15d. We report some -tpmdev failures, but then continue as if all was fine. Reproducer: $ qemu-system-x86_64 -nodefaults -S -display none -monitor stdio -chardev null,id=tpm0 -tpmdev emulator,id=tpm0,chardev=chrtpm -device tpm-tis,tpmdev=tpm0 qemu-system-x86_64: -tpmdev emulator,id=tpm0,chardev=chrtpm: tpm-emulator: tpm chardev 'chrtpm' not found. qemu-system-x86_64: -tpmdev emulator,id=tpm0,chardev=chrtpm: tpm-emulator: Could not cleanly shutdown the TPM: No such file or directory QEMU 5.0.90 monitor - type 'help' for more information (qemu) qemu-system-x86_64: -device tpm-tis,tpmdev=tpm0: Property 'tpm-tis.tpmdev' can't find value 'tpm0' $ echo $? 1 This is a regression caused by commit d10e05f15d "tpm: Clean up error reporting in tpm_init_tpmdev()". It's incomplete: be->create(opts) continues to use error_report(), and we don't set an error when it fails. I figure converting the create() methods to Error would make some sense, but I'm not sure it's worth the effort right now. Revert the broken commit instead, and add a comment to tpm_init_tpmdev(). Straightforward conflict in tpm.c resolved. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>		2020-07-24 12:44:13 -04:00
..
arch_type.c	stubs: Add arch_type	2020-03-06 17:15:38 +01:00
bdrv-next-monitor-owned.c
blk-commit-all.c
blockdev-close-all-bdrv-states.c
change-state-handler.c
clock-warp.c
cmos.c	acpi: move aml builder code for floppy device	2020-06-24 17:18:28 -04:00
cpu-get-clock.c
cpu-get-icount.c
dump.c
error-printf.c
fd-register.c
fdset.c
fw_cfg.c
gdbstub.c
get-vm-name.c
io_uring.c	stubs: add stubs for io_uring interface	2020-01-30 20:59:41 +00:00
iothread-lock.c
iothread.c
is-daemonized.c
isa-bus.c	stubs: add isa_create_simple	2020-07-06 17:01:11 +02:00
linux-aio.c
machine-init-done.c
Makefile.objs	trivial branch patches 20200707	2020-07-09 14:13:19 +01:00
migr-blocker.c
monitor-core.c	qmp: Fail gracefully if chardev is already in use	2020-03-06 17:21:28 +01:00
monitor.c	hmp: Fail gracefully if chardev is already in use	2020-03-06 17:21:28 +01:00
notify-event.c
pci-bus.c	stubs: add pci_create_simple	2020-07-06 17:01:11 +02:00
pci-host-piix.c
qmp_memory_device.c	qom/object: Move Object typedef to 'qemu/typedefs.h'	2020-06-10 12:09:36 -04:00
qtest.c
ram-block.c
ramfb.c	Revert "hw/display/ramfb: initialize fw-config space with xres/ yres"	2020-05-18 15:42:34 +02:00
replay-user.c
replay.c
runstate-check.c
semihost.c
set-fd-handler.c
sysbus.c
target-get-monitor-def.c
target-monitor-defs.c
tpm.c	Revert "tpm: Clean up error reporting in tpm_init_tpmdev()"	2020-07-24 12:44:13 -04:00
trace-control.c
uuid.c
vm-stop.c
vmgenid.c
vmstate.c
win32-kbd-hook.c	ui/win32-kbd-hook: handle AltGr in a hook procedure	2020-05-19 09:06:44 +02:00