Stefan Hajnoczi
cbaddb25b2
qemu-iotests: step clock after each test iteration
...
The 093 throttling test submits twice as many requests as the throttle
limit in order to ensure that we reach the limit. The remaining
requests are left in-flight at the end of each test iteration.
Commit 452589b6b47e8dc6353df257fc803dfc1383bed8 ("vl.c/exit: pause cpus
before closing block devices") exposed a hang in 093. This happens
because requests are still in flight when QEMU terminates but
QEMU_CLOCK_VIRTUAL time is frozen. bdrv_drain_all() hangs forever since
throttled requests cannot complete.
Step the clock at the end of each test iteration so in-flight requests
actually finish. This solves the hang and is cleaner than leaving tests
in-flight.
Note that this could also be "fixed" by disabling throttling when drives
are closed in QEMU. That approach has two issues:
1. We must drain requests before disabling throttling, so the hang
cannot be easily avoided!
2. Any time QEMU disables throttling internally there is a chance that
malicious users can abuse the code path to bypass throttling limits.
Therefore it makes more sense to fix the test case than to modify QEMU.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20170815130502.8736-1-stefanha@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
2017-08-15 10:03:27 -05:00
..
2016-03-14 16:46:42 +01:00
2017-02-12 00:47:42 +01:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2016-05-12 15:33:24 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2016-05-12 15:33:24 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2017-04-24 15:09:33 -04:00
2015-09-11 10:21:38 +03:00
2016-04-15 17:56:56 +02:00
2016-01-07 21:30:17 +01:00
2016-04-15 17:56:56 +02:00
2017-05-11 14:28:05 +02:00
2017-04-24 15:09:33 -04:00
2016-01-07 21:30:17 +01:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2016-05-12 15:33:24 +02:00
2016-04-15 17:56:56 +02:00
2016-01-07 21:30:17 +01:00
2017-03-13 12:49:33 +01:00
2014-12-12 16:52:33 +00:00
2017-04-27 15:46:16 +02:00
2017-04-27 15:46:16 +02:00
2017-04-27 15:46:16 +02:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2017-04-24 15:09:33 -04:00
2017-04-27 15:39:49 +02:00
2017-04-24 15:09:33 -04:00
2014-12-12 16:52:33 +00:00
2017-07-24 15:06:04 +02:00
2017-05-26 16:48:21 +02:00
2016-04-15 17:56:56 +02:00
2016-01-20 13:36:23 +01:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2017-07-11 17:44:59 +02:00
2016-04-15 17:22:11 +02:00
2016-06-08 10:21:08 +02:00
2016-01-07 21:30:17 +01:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2016-03-17 15:47:56 +01:00
2016-04-15 17:56:56 +02:00
2016-01-07 21:30:17 +01:00
2016-04-15 17:56:56 +02:00
2016-01-07 21:30:17 +01:00
2016-04-15 17:56:56 +02:00
2016-05-12 15:33:24 +02:00
2017-07-24 15:06:04 +02:00
2017-07-24 15:06:04 +02:00
2017-08-01 18:09:33 +02:00
2017-07-24 15:06:04 +02:00
2017-07-11 17:44:55 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2015-12-18 14:36:17 +01:00
2012-11-14 18:19:21 +01:00
2017-07-11 17:45:02 +02:00
2013-09-12 10:12:47 +02:00
2013-09-12 10:12:47 +02:00
2017-05-11 11:08:40 +02:00
2015-09-11 10:21:38 +03:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2017-07-11 17:44:55 +02:00
2016-05-12 15:33:24 +02:00
2017-07-11 17:44:56 +02:00
2017-07-11 17:44:56 +02:00
2016-04-15 17:56:56 +02:00
2016-01-07 21:30:17 +01:00
2017-07-11 17:45:00 +02:00
2017-04-27 15:39:49 +02:00
2017-04-27 15:39:49 +02:00
2016-05-12 15:33:24 +02:00
2016-05-12 15:33:24 +02:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2017-07-24 15:06:04 +02:00
2016-09-05 19:06:48 +02:00
2015-12-03 11:08:07 +08:00
2015-12-03 11:08:07 +08:00
2016-09-05 19:06:47 +02:00
2013-09-12 10:12:47 +02:00
2016-04-15 17:56:56 +02:00
2013-12-04 15:19:00 +01:00
2017-08-01 18:09:33 +02:00
2017-08-01 18:09:33 +02:00
2016-04-15 17:56:56 +02:00
2017-07-10 13:18:05 +02:00
2016-04-15 17:56:56 +02:00
2016-05-12 15:33:24 +02:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2017-08-01 18:09:33 +02:00
2013-09-06 15:25:07 +02:00
2016-04-15 17:56:56 +02:00
2015-01-23 12:41:32 -05:00
2015-03-10 14:02:20 +01:00
2013-10-11 16:49:50 +02:00
2017-05-11 12:08:24 +02:00
2017-05-11 12:08:24 +02:00
2017-07-18 15:14:36 +02:00
2017-07-18 15:14:36 +02:00
2017-07-11 17:45:00 +02:00
2017-06-26 14:51:13 +02:00
2016-04-15 17:56:56 +02:00
2016-01-13 15:16:18 +01:00
2016-04-15 17:56:56 +02:00
2017-02-12 00:47:42 +01:00
2016-10-24 17:54:03 +02:00
2017-05-23 13:28:17 +02:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2017-04-24 15:09:33 -04:00
2015-09-11 10:21:38 +03:00
2017-08-01 18:09:33 +02:00
2013-12-04 14:31:39 +01:00
2016-04-15 17:56:56 +02:00
2017-02-12 00:47:42 +01:00
2016-04-15 17:56:56 +02:00
2017-02-12 00:47:42 +01:00
2016-06-07 14:40:51 +01:00
2016-06-07 14:40:51 +01:00
2016-04-15 17:56:56 +02:00
2017-02-12 00:47:42 +01:00
2016-04-15 17:56:56 +02:00
2015-09-11 10:21:38 +03:00
2016-04-15 17:56:56 +02:00
2017-02-12 00:47:42 +01:00
2016-10-24 17:54:03 +02:00
2017-05-23 13:28:17 +02:00
2017-07-18 15:27:37 +02:00
2017-07-18 15:27:37 +02:00
2016-05-12 15:33:23 +02:00
2017-06-06 20:18:36 +02:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2017-07-24 13:35:11 +02:00
2017-07-11 17:44:55 +02:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2017-07-11 17:44:56 +02:00
2017-07-11 17:44:56 +02:00
2016-04-15 17:56:56 +02:00
2017-02-12 00:47:42 +01:00
2016-04-15 17:56:56 +02:00
2016-07-18 18:19:01 -04:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2017-05-11 11:08:40 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2017-02-12 00:47:42 +01:00
2017-08-15 10:03:27 -05:00
2016-10-24 17:54:03 +02:00
2017-04-24 15:09:33 -04:00
2017-05-23 13:28:17 +02:00
2016-06-16 15:20:37 +02:00
2016-01-07 21:30:17 +01:00
2016-05-19 16:45:31 +02:00
2015-10-16 15:34:29 +02:00
2017-04-03 17:11:40 +02:00
2017-04-03 17:11:40 +02:00
2016-04-15 17:56:56 +02:00
2015-09-11 10:21:38 +03:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2014-08-22 11:01:12 +02:00
2017-04-24 15:09:33 -04:00
2017-05-11 14:28:06 +02:00
2016-04-15 17:56:56 +02:00
2016-01-13 15:16:18 +01:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2014-10-03 10:30:33 +01:00
2017-07-11 17:45:02 +02:00
2017-07-11 17:45:02 +02:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2016-04-15 17:56:56 +02:00
2014-12-12 16:52:33 +00:00
2017-08-08 14:36:59 +02:00
2017-08-08 14:36:59 +02:00
2016-04-15 17:56:56 +02:00
2015-12-18 14:36:17 +01:00
2016-04-15 17:56:56 +02:00
2017-07-18 15:27:37 +02:00
2016-04-15 17:56:56 +02:00
2015-12-18 14:34:43 +01:00
2016-04-15 17:56:56 +02:00
2014-12-10 10:31:20 +01:00
2017-04-24 15:09:33 -04:00
2017-07-10 13:18:05 +02:00
2016-04-15 17:56:56 +02:00
2015-09-11 10:21:38 +03:00
2016-04-15 17:56:56 +02:00
2017-02-12 00:47:42 +01:00
2017-04-24 15:09:33 -04:00
2017-05-23 13:28:17 +02:00
2016-10-24 17:54:03 +02:00
2015-11-11 16:25:47 +01:00
2016-04-15 17:56:56 +02:00
2017-05-23 13:28:17 +02:00
2017-07-11 17:44:59 +02:00
2017-05-23 13:28:17 +02:00
2016-04-15 17:56:56 +02:00
2015-09-11 10:21:38 +03:00
2016-04-15 17:56:56 +02:00
2017-05-11 14:28:07 +02:00
2016-04-15 17:56:56 +02:00
2015-02-16 15:07:18 +00:00
2017-08-01 18:09:33 +02:00
2016-11-14 22:47:34 -05:00
2017-07-11 17:45:02 +02:00
2017-07-11 17:45:02 +02:00
2017-07-11 17:45:00 +02:00
2017-07-11 17:45:00 +02:00
2016-04-15 17:56:56 +02:00
2015-03-10 14:02:24 +01:00
2015-04-28 15:36:09 +02:00
2015-04-28 15:36:09 +02:00
2017-04-24 15:09:33 -04:00
2017-04-27 15:39:49 +02:00
2016-04-15 17:56:56 +02:00
2017-02-12 00:47:42 +01:00
2015-07-02 10:06:23 +01:00
2015-07-02 10:06:23 +01:00
2016-04-15 17:56:56 +02:00
2015-12-18 14:34:43 +01:00
2017-07-11 17:44:56 +02:00
2017-07-11 17:44:56 +02:00
2016-04-15 17:56:56 +02:00
2015-07-27 17:19:07 +02:00
2017-08-08 15:19:16 +02:00
2016-05-19 16:45:31 +02:00
2017-02-24 16:09:22 +01:00
2016-05-12 15:33:24 +02:00
2016-04-15 17:56:56 +02:00
2015-09-14 16:51:37 +02:00
2017-07-24 13:35:11 +02:00
2016-09-23 13:45:36 +02:00
2017-07-11 17:44:59 +02:00
2017-07-17 13:57:42 -05:00
2017-08-01 18:09:33 +02:00
2017-02-28 20:47:46 +01:00
2017-07-11 17:45:00 +02:00
2017-04-27 15:39:49 +02:00
2017-04-24 15:09:33 -04:00
2017-07-17 13:57:42 -05:00
2016-02-02 18:07:27 +01:00
2017-07-11 17:44:55 +02:00
2017-07-11 17:44:59 +02:00
2017-04-27 15:39:49 +02:00
2016-03-14 16:46:42 +01:00
2017-05-11 14:28:06 +02:00
2017-05-26 16:48:21 +02:00
2016-10-27 19:05:23 +02:00
2016-04-12 18:07:39 +02:00
2016-03-17 16:43:30 +01:00
2017-07-11 17:45:00 +02:00
2017-07-11 17:45:00 +02:00
2016-04-15 17:56:56 +02:00
2016-04-12 18:06:51 +02:00
2016-04-20 16:52:55 +02:00
2016-04-20 16:52:55 +02:00
2017-08-01 18:09:33 +02:00
2017-07-10 13:18:05 +02:00
2017-06-30 21:48:06 +08:00
2017-06-30 21:48:06 +08:00
2016-10-24 17:54:03 +02:00
2016-06-16 15:20:37 +02:00
2017-08-01 18:09:33 +02:00
2017-05-23 13:28:17 +02:00
2017-07-11 17:44:59 +02:00
2017-07-11 17:44:59 +02:00
2017-07-18 15:27:37 +02:00
2017-07-11 17:44:56 +02:00
2017-07-11 17:44:59 +02:00
2016-09-20 22:10:57 +02:00
2016-09-20 22:10:57 +02:00
2016-09-20 22:10:57 +02:00
2017-08-01 18:09:33 +02:00
2016-10-24 17:54:03 +02:00
2017-07-11 17:44:59 +02:00
2017-07-11 17:44:59 +02:00
2017-07-11 17:44:59 +02:00
2016-09-20 22:10:57 +02:00
2017-07-11 17:45:00 +02:00
2016-10-31 16:52:39 +01:00
2017-05-11 11:08:40 +02:00
2017-05-11 11:08:40 +02:00
2017-02-12 00:47:42 +01:00
2017-02-12 00:47:42 +01:00
2017-07-11 17:44:59 +02:00
2017-02-12 00:47:42 +01:00
2017-02-24 16:09:22 +01:00
2017-02-24 16:09:22 +01:00
2017-04-03 17:11:40 +02:00
2017-04-03 17:11:40 +02:00
2017-07-10 13:18:05 +02:00
2017-07-10 13:18:05 +02:00
2017-07-11 17:45:01 +02:00
2017-07-11 17:45:01 +02:00
2017-07-11 17:45:01 +02:00
2017-08-01 18:09:33 +02:00
2017-05-11 14:28:07 +02:00
2017-07-11 17:44:59 +02:00
2017-04-27 15:39:49 +02:00
2017-05-11 12:08:20 +02:00
2017-05-11 12:08:20 +02:00
2017-06-09 11:45:03 +02:00
2017-06-09 11:45:03 +02:00
2017-08-11 14:44:39 +02:00
2017-07-11 17:44:55 +02:00
2017-08-01 18:09:33 +02:00
2017-08-01 18:09:33 +02:00
2017-08-08 15:19:16 +02:00
2017-08-08 15:19:16 +02:00
2017-07-11 17:44:56 +02:00
2017-07-11 17:44:56 +02:00
2017-07-18 15:27:37 +02:00
2017-07-11 17:44:56 +02:00
2017-08-01 18:09:33 +02:00
2017-08-01 18:09:33 +02:00
2017-08-14 13:06:54 +03:00
2017-07-11 17:44:56 +02:00
2017-07-11 17:45:00 +02:00
2017-07-11 17:45:00 +02:00
2017-05-11 14:28:05 +02:00
2017-07-11 17:44:59 +02:00
2017-08-14 13:06:54 +03:00
2012-02-22 16:15:22 +01:00
2017-08-08 15:19:16 +02:00
2017-07-24 15:06:04 +02:00
2017-02-12 00:47:42 +01:00
2014-03-14 16:28:28 +01:00
2014-12-10 10:31:13 +01:00
2016-02-08 17:29:54 +01:00
2016-06-16 15:19:55 +02:00
2016-10-27 19:05:23 +02:00