Original Xbox Emulator for Windows, macOS, and Linux (Active Development)
Go to file
Paul Durrant dd29b5c30c xen: cleanup unrealized flash devices
The generic pc_machine_initfn() calls pc_system_flash_create() which creates
'system.flash0' and 'system.flash1' devices. These devices are then realized
by pc_system_flash_map() which is called from pc_system_firmware_init() which
itself is called via pc_memory_init(). The latter however is not called when
xen_enable() is true and hence the following assertion fails:

qemu-system-i386: hw/core/qdev.c:439: qdev_assert_realized_properly:
Assertion `dev->realized' failed

These flash devices are unneeded when using Xen so this patch avoids the
assertion by simply removing them using pc_system_flash_cleanup_unused().

Reported-by: Jason Andryuk <jandryuk@gmail.com>
Fixes: ebc29e1bea ("pc: Support firmware configuration with -blockdev")
Signed-off-by: Paul Durrant <pdurrant@amazon.com>
Tested-by: Jason Andryuk <jandryuk@gmail.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200624121841.17971-3-paul@xen.org>
Fixes: dfe8c79c44 ("qdev: Assert onboard devices all get realized properly")
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
2020-07-10 13:49:16 +01:00
.github .github: Enable repo-lockdown bot to refuse GitHub pull requests 2020-04-07 16:19:18 +01:00
.gitlab-ci.d gitlab-ci: Move edk2 and opensbi YAML files to .gitlab-ci.d folder 2020-05-28 11:00:39 +02:00
accel accel/kvm: Convert to ram_block_discard_disable() 2020-07-02 05:54:59 -04:00
audio audio/jack: simplify the re-init code path 2020-06-17 14:44:51 +02:00
authz qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
backends tpm: Move backend code under the 'backends/' directory 2020-06-19 07:25:55 -04:00
block qed: Simplify backing reads 2020-07-06 10:34:14 +02:00
bsd-user linux-user/sparc64: Fix the handling of window spill trap 2020-06-29 13:00:23 +02:00
capstone@22ead3e0bf
chardev chardev: enable modules, use for braille 2020-07-07 15:33:59 +02:00
contrib libvhost-user: advertise vring features 2020-06-12 10:17:06 -04:00
crypto firmware (and crypto) patches 2020-07-09 20:01:43 +01:00
default-configs hw/rx: Add RX GDB simulator 2020-06-22 18:37:12 +02:00
disas
docs firmware (and crypto) patches 2020-07-09 20:01:43 +01:00
dtc@85e5d83984 Makefile: dtc: update, build the libfdt target 2020-06-16 14:49:05 +01:00
dump various: Remove suspicious '\' character outside of #define in C code 2020-04-29 08:01:51 +02:00
fpu softfloat: return low bits of quotient from floatx80_modrem 2020-06-26 09:39:38 -04:00
fsdev virtfs-proxy-helper: Make the helper_opts[] array const 2020-03-09 15:59:31 +01:00
gdb-xml target/arm: Use correct GDB XML for M-profile cores 2020-05-14 15:03:08 +01:00
hw xen: cleanup unrealized flash devices 2020-07-10 13:49:16 +01:00
include xen: cleanup unrealized flash devices 2020-07-10 13:49:16 +01:00
io io/task: Move 'qom/object.h' header to source 2020-06-10 12:09:37 -04:00
libdecnumber
linux-headers Linux headers: update 2020-06-18 12:13:36 +02:00
linux-user linux-user: Add strace support for printing arguments of ioctl() 2020-07-04 18:08:51 +02:00
migration virtio,acpi: features, fixes, cleanups. 2020-07-07 17:37:44 +01:00
monitor virtio-pci: Send qapi events when the virtio-mem size changes 2020-07-03 07:57:04 -04:00
nbd nbd/server: Avoid long error message assertions CVE-2020-10761 2020-06-10 12:58:59 -05:00
net trivial branch patches 20200707 2020-07-09 14:13:19 +01:00
pc-bios s390 update: 2020-07-04 10:24:07 +01:00
plugins qemu/qemu-plugin: Make qemu_plugin_hwaddr_is_io() hwaddr argument const 2020-05-15 15:25:16 +01:00
po translations: Add Swedish language 2020-06-15 20:51:10 +02:00
python/qemu python/qemu/qtest: Check before accessing _qtest 2020-05-31 18:25:31 +02:00
qapi Block patches for 5.1: 2020-07-07 19:47:26 +01:00
qga qga: Plug unlikely memory leak in guest-set-memory-blocks 2020-07-02 06:25:29 +02:00
qobject qobject: Eliminate qdict_iter(), use qdict_first(), qdict_next() 2020-04-30 06:51:15 +02:00
qom qdev: device module support 2020-07-07 14:54:29 +02:00
replay replay: synchronize on every virtual timer callback 2020-06-26 06:45:30 -04:00
roms seabios: update 128k config 2020-07-02 16:20:08 +02:00
scripts tracetool: work around ust <sys/sdt.h> include conflict 2020-07-07 16:07:14 +01:00
scsi error: Use error_reportf_err() where appropriate 2020-05-27 07:45:30 +02:00
slirp@2faae0f778 slirp: update to fix CVE-2020-1983 2020-04-21 18:39:20 +01:00
softmmu firmware (and crypto) patches 2020-07-09 20:01:43 +01:00
storage-daemon qemu-storage-daemon: Add --monitor option 2020-03-06 17:21:28 +01:00
stubs trivial branch patches 20200707 2020-07-09 14:13:19 +01:00
target m68k pull-request 20200706 2020-07-08 21:38:47 +01:00
tcg tcg: Fix do_nonatomic_op_* vs signed operations 2020-07-06 10:58:19 -07:00
tests Block patches for 5.1: 2020-07-07 19:47:26 +01:00
tools/virtiofsd virtiofsd: Allow addition or removal of capabilities 2020-07-03 16:23:05 +01:00
trace trace/simple: Fix unauthorized enable 2020-06-24 11:21:00 +01:00
ui vnc: Plug minor memory leak in vnc_display_open() 2020-07-02 06:25:29 +02:00
util qom: add support for qom objects in modules. 2020-07-09 17:02:29 +01:00
.cirrus.yml cirrus.yml: serialise make check 2020-06-16 14:49:05 +01:00
.dir-locals.el
.editorconfig
.exrc
.gdbinit
.gitignore .gitignore: Ignore storage-daemon files 2020-06-17 14:53:40 +02:00
.gitlab-ci.yml gitlab-ci: Determine the number of jobs dynamically 2020-05-28 11:01:38 +02:00
.gitmodules
.gitpublish
.mailmap MAINTAINERS: Update Radoslaw Biernacki email address 2020-07-07 12:38:50 +02:00
.patchew.yml
.readthedocs.yml
.shippable.yml Revert ".shippable: temporaily disable some cross builds" 2020-06-16 14:49:05 +01:00
.travis.yml configure: Let SLOF be initialized by ./scripts/git-submodule.sh 2020-06-15 18:26:47 +02:00
arch_init.c arch_init: Remove unused 'qapi-commands-misc.h' include 2020-06-05 21:23:22 +02:00
balloon.c virtio-balloon: Rip out qemu_balloon_inhibit() 2020-07-02 05:54:59 -04:00
block.c block: inline bdrv_unallocated_blocks_are_zero() 2020-07-06 08:49:28 +02:00
blockdev-nbd.c blockdev-nbd: Boxed argument type for nbd-server-add 2020-03-06 17:21:28 +01:00
blockdev.c blockdev: Deprecate -drive with bogus interface type 2020-06-23 16:07:07 +02:00
blockjob.c block: Add BdrvChildRole to BdrvChild 2020-05-18 19:05:25 +02:00
bootdevice.c Drop more @errp parameters after previous commit 2020-05-15 07:08:14 +02:00
Changelog
CODING_STYLE.rst
configure virtio,acpi: features, fixes, cleanups. 2020-07-07 17:37:44 +01:00
COPYING
COPYING.LIB
cpus-common.c cpu: convert queued work to a QSIMPLEQ 2020-06-16 14:49:05 +01:00
cpus.c replay: notify the main loop when there are no instructions 2020-06-26 06:45:30 -04:00
device_tree.c device_tree: Constify compat in qemu_fdt_node_path() 2020-04-30 15:35:41 +01:00
disas.c disas: Let disas::read_memory() handler return EIO on error 2020-06-10 12:10:23 -04:00
dma-helpers.c icount: make dma reads deterministic 2020-06-17 14:53:39 +02:00
exec-vary.c
exec.c exec: Introduce ram_block_discard_(disable|require)() 2020-07-02 05:54:59 -04:00
gdbstub.c gdbstub/linux-user: support debugging over a unix socket 2020-05-06 09:29:26 +01:00
gitdm.config
hmp-commands-info.hx memory: Make 'info mtree' not display disabled regions by default 2020-06-10 12:10:49 -04:00
hmp-commands.hx hmp: Make json format optional for qom-set 2020-06-17 17:48:39 +01:00
ioport.c
iothread.c qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
job-qmp.c job: take each job's lock individually in job_txn_apply 2020-04-07 14:34:47 +02:00
job.c job: take each job's lock individually in job_txn_apply 2020-04-07 14:34:47 +02:00
Kconfig.host
LICENSE
MAINTAINERS trivial branch patches 20200707 2020-07-09 14:13:19 +01:00
Makefile Makefile: Install qemu-[qmp/ga]-ref.* into the directory "interop" 2020-06-26 09:39:37 -04:00
Makefile.objs chardev: enable modules, use for braille 2020-07-07 15:33:59 +02:00
Makefile.target build: fix device module builds 2020-07-07 15:29:31 +02:00
memory_ldst.inc.c
memory_mapping.c
memory.c memory: Revert "memory: accept mismatching sizes in memory_region_access_valid" 2020-06-26 06:45:30 -04:00
module-common.c
os-posix.c
os-win32.c
qdev-monitor.c qom: add support for qom objects in modules. 2020-07-09 17:02:29 +01:00
qemu-bridge-helper.c
qemu-edid.c
qemu-img-cmds.hx block/amend: add 'force' option 2020-07-06 08:49:28 +02:00
qemu-img.c qemu-img: convert: don't use unallocated_blocks_are_zero 2020-07-06 08:49:28 +02:00
qemu-io-cmds.c block-backend: Add flags to blk_truncate() 2020-04-30 17:51:07 +02:00
qemu-io.c
qemu-keymap.c
qemu-nbd.c error: Use error_reportf_err() where appropriate 2020-05-27 07:45:30 +02:00
qemu-options-wrapper.h
qemu-options.h
qemu-options.hx firmware (and crypto) patches 2020-07-09 20:01:43 +01:00
qemu-seccomp.c
qemu-storage-daemon.c qemu-storage-daemon: add missing cleanup calls 2020-07-03 09:37:03 +02:00
qemu.nsi qemu.nsi: Install Sphinx documentation 2020-03-09 16:45:00 +00:00
qemu.sasl
qtest.c qtest: fix fuzzer-related 80-char limit violations 2020-03-06 10:33:26 +00:00
README.rst
replication.c
replication.h
rules.mak build-sys: Move the print-variable rule to rules.mak 2020-03-09 15:59:31 +01:00
thunk.c linux-user: Add strace support for printing arguments of ioctl() 2020-07-04 18:08:51 +02:00
tpm.c
trace-events
VERSION Open 5.1 development tree 2020-04-29 15:07:10 +01:00
version.rc

===========
QEMU README
===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:


.. code-block:: shell

  mkdir build
  cd build
  ../configure
  make

Additional information can also be found online via the QEMU website:

* `<https://qemu.org/Hosts/Linux>`_
* `<https://qemu.org/Hosts/Mac>`_
* `<https://qemu.org/Hosts/W32>`_


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

.. code-block:: shell

   git clone https://git.qemu.org/git/qemu.git

When submitting patches, one common approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the CODING_STYLE.rst file.

Additional information on submitting patches can be found online via
the QEMU website

* `<https://qemu.org/Contribute/SubmitAPatch>`_
* `<https://qemu.org/Contribute/TrivialPatches>`_

The QEMU website is also maintained under source control.

.. code-block:: shell

  git clone https://git.qemu.org/git/qemu-web.git

* `<https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/>`_

A 'git-publish' utility was created to make above process less
cumbersome, and is highly recommended for making regular contributions,
or even just for sending consecutive patch series revisions. It also
requires a working 'git send-email' setup, and by default doesn't
automate everything, so you may want to go through the above steps
manually for once.

For installation instructions, please go to

*  `<https://github.com/stefanha/git-publish>`_

The workflow with 'git-publish' is:

.. code-block:: shell

  $ git checkout master -b my-feature
  $ # work on new commits, add your 'Signed-off-by' lines to each
  $ git publish

Your patch series will be sent and tagged as my-feature-v1 if you need to refer
back to it in the future.

Sending v2:

.. code-block:: shell

  $ git checkout my-feature # same topic branch
  $ # making changes to the commits (using 'git rebase', for example)
  $ git publish

Your patch series will be sent with 'v2' tag in the subject and the git tip
will be tagged as my-feature-v2.

Bug reporting
=============

The QEMU project uses Launchpad as its primary upstream bug tracker. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

* `<https://bugs.launchpad.net/qemu/>`_

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via launchpad.

For additional information on bug reporting consult:

* `<https://qemu.org/Contribute/ReportABug>`_


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

* `<mailto:qemu-devel@nongnu.org>`_
* `<https://lists.nongnu.org/mailman/listinfo/qemu-devel>`_
* #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

* `<https://qemu.org/Contribute/StartHere>`_