Peter Maydell ef011555da hw/intc/arm_gicv3_its: Use enum for return value of process_* functions ... When an ITS detects an error in a command, it has an implementation-defined (CONSTRAINED UNPREDICTABLE) choice of whether to ignore the command, proceeding to the next one in the queue, or to stall the ITS command queue, processing nothing further. The behaviour required when the read of the command packet from memory fails is less clearly documented, but the same set of choices as for command errors seem reasonable. The intention of the QEMU implementation, as documented in the comments, is that if we encounter a memory error reading the command packet or one of the various data tables then we should stall, but for command parameter errors we should ignore the queue and continue. However, we don't actually do this. To get the desired behaviour, the various process_* functions need to return true to cause process_cmdq() to advance to the next command and keep processing, and false to stall command processing. What they mostly do is return false for any kind of error. To make the code clearer, replace the 'bool' return from the process_ functions with an enum which may be either CMD_STALL or CMD_CONTINUE. In this commit no behaviour changes; in subsequent commits we will adjust the error-return paths for the process_ functions one by one. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Message-id: 20220111171048.3545974-6-peter.maydell@linaro.org		2022-01-20 16:04:58 +00:00
..
allwinner-a10-pic.c	Clean up inclusion of sysemu/sysemu.h	2019-08-16 13:31:53 +02:00
apic_common.c	Do not include cpu.h if it's not really necessary	2021-05-02 17:24:51 +02:00
apic.c	Do not include cpu.h if it's not really necessary	2021-05-02 17:24:51 +02:00
arm_gic_common.c	arm_gic: Mask the un-supported priority bits	2020-02-28 16:14:57 +00:00
arm_gic_kvm.c	Do not include cpu.h if it's not really necessary	2021-05-02 17:24:51 +02:00
arm_gic.c	hw/intc/arm_gic: Allow reset of the running priority	2022-01-20 11:47:52 +00:00
arm_gicv2m.c	arm tcg cpus: Fix Lesser GPL version number	2020-11-15 16:42:14 +01:00
arm_gicv3_common.c	hw/intc/arm_gicv3: Support multiple redistributor regions	2021-11-15 16:12:59 +00:00
arm_gicv3_cpuif_common.c	hw/intc/arm_gicv3: Extract gicv3_set_gicv3state from arm_gicv3_cpuif.c	2021-12-15 10:11:34 +00:00
arm_gicv3_cpuif.c	hw/intc/arm_gicv3: Extract gicv3_set_gicv3state from arm_gicv3_cpuif.c	2021-12-15 10:11:34 +00:00
arm_gicv3_dist.c	hw/intc: GICv3 ITS Feature enablement	2021-09-13 21:01:08 +01:00
arm_gicv3_its_common.c	hw/intc/arm_gicv3_its: Revert version increments in vmstate_its	2021-11-22 18:17:19 +00:00
arm_gicv3_its_kvm.c	hw/intc: GICv3 ITS initial framework	2021-09-13 16:07:54 +01:00
arm_gicv3_its.c	hw/intc/arm_gicv3_its: Use enum for return value of process_* functions	2022-01-20 16:04:58 +00:00
arm_gicv3_kvm.c	hw/intc/arm_gicv3: Support multiple redistributor regions	2021-11-15 16:12:59 +00:00
arm_gicv3_redist.c	hw/intc/arm_gicv3: Update cached state after LPI state changes	2021-11-26 16:57:51 +00:00
arm_gicv3.c	hw/intc/arm_gicv3: Introduce CONFIG_ARM_GIC_TCG Kconfig selector	2021-12-15 10:35:10 +00:00
armv7m_nvic.c	arm: Move system PPB container handling to armv7m	2021-09-01 11:08:18 +01:00
aspeed_vic.c	Include migration/vmstate.h less	2019-08-16 13:31:52 +02:00
bcm2835_ic.c	hw/intc/bcm2835_ic: Trace GPU/CPU IRQ handlers	2020-10-20 16:12:00 +01:00
bcm2836_control.c	hw/intc/bcm2836_control: Use IRQ definitions instead of magic numbers	2020-10-20 16:12:00 +01:00
etraxfs_pic.c	hw: Replace anti-social QOM type names	2021-03-19 15:18:43 +01:00
exynos4210_combiner.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
exynos4210_gic.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
gic_internal.h	hw/intc/arm_gic: Drop GIC_BASE_IRQ macro	2018-09-25 15:13:24 +01:00
gicv3_internal.h	hw/intc/arm_gicv3_its: Use FIELD macros for CTEs	2022-01-07 17:07:59 +00:00
goldfish_pic.c	hw/m68k: Fix typo in SPDX tag	2021-11-09 10:11:27 +01:00
grlib_irqmp.c	Do not include cpu.h if it's not really necessary	2021-05-02 17:24:51 +02:00
heathrow_pic.c	Include hw/hw.h exactly where needed	2019-08-16 13:31:52 +02:00
i8259_common.c	isa: Convert uses of isa_create() with Coccinelle	2020-06-15 22:05:28 +02:00
i8259.c	hw/intc/i8259: Refactor pic_read_irq() to avoid uninitialized variable	2021-03-19 08:48:18 -04:00
imx_avic.c	Include migration/vmstate.h less	2019-08-16 13:31:52 +02:00
imx_gpcv2.c	hw: Do not include qemu/log.h if it is not necessary	2021-05-02 17:24:50 +02:00
intc.c	intc: add an interface to gather statistics/informations on interrupt controllers	2016-10-04 10:00:25 +02:00
ioapic_common.c	nomaintainer: Fix Lesser GPL version number	2020-11-15 17:04:40 +01:00
ioapic.c	Remove superfluous timer_del() calls	2021-01-08 15:13:38 +00:00
Kconfig	hw/intc/arm_gicv3: Introduce CONFIG_ARM_GIC_TCG Kconfig selector	2021-12-15 10:35:10 +00:00
loongson_liointc.c	hw/intc/loongson_liointc: Fix per core ISR handling	2021-02-21 18:41:46 +01:00
m68k_irqc.c	hw/m68k: Fix typo in SPDX tag	2021-11-09 10:11:27 +01:00
meson.build	hw/intc/arm_gicv3: Introduce CONFIG_ARM_GIC_TCG Kconfig selector	2021-12-15 10:35:10 +00:00
mips_gic.c	qdev: set properties with device_class_set_props()	2020-01-24 20:59:15 +01:00
omap_intc.c	omap_intc: Use typedef name for instance_size	2020-09-09 13:20:22 -04:00
ompic.c	hw: Do not include qemu/log.h if it is not necessary	2021-05-02 17:24:50 +02:00
openpic_kvm.c	memory: Name all the memory listeners	2021-09-30 15:30:24 +02:00
openpic.c	hw/intc: openpic: Clean up the styles	2021-09-30 12:26:06 +10:00
pl190.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
pnv_xive_regs.h	ppc/pnv: add a XIVE interrupt controller model for POWER9	2019-03-12 14:33:04 +11:00
pnv_xive.c	dma: Let ld*_dma() propagate MemTxResult	2021-12-31 01:05:27 +01:00
ppc-uic.c	misc: Correct relative include path	2021-06-05 21:10:42 +02:00
realview_gic.c	error: Eliminate error_propagate() with Coccinelle, part 1	2020-07-10 15:18:08 +02:00
riscv_aclint.c	hw/intc: Upgrade the SiFive CLINT implementation to RISC-V ACLINT	2021-09-21 07:56:49 +10:00
rx_icu.c	hw/intc: fix heap-buffer-overflow in rxicu_realize()	2020-11-23 10:41:58 +00:00
s390_flic_kvm.c	target/s390x: move kvm files into kvm/	2021-07-07 14:01:59 +02:00
s390_flic.c	Do not include cpu.h if it's not really necessary	2021-05-02 17:24:51 +02:00
sh_intc.c	hw/intc/sh_intc: Remove unneeded local variable initialisers	2021-10-30 18:39:37 +02:00
sifive_plic.c	hw/intc: sifive_plic: Cleanup remaining functions	2022-01-08 15:46:09 +10:00
slavio_intctl.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
spapr_xive_kvm.c	spapr/xive: Use xive_esb_rw() to trigger interrupts	2021-10-21 11:42:47 +11:00
spapr_xive.c	dma: Let dma_memory_rw() take MemTxAttrs argument	2021-12-30 17:16:32 +01:00
trace-events	hw/sh4: Change debug printfs to traces	2021-10-30 18:39:37 +02:00
trace.h	trace: switch position of headers to what Meson requires	2020-08-21 06:18:24 -04:00
vgic_common.h	intc/gic: Extract some reusable vGIC code	2015-09-24 01:29:36 +01:00
xics_kvm.c	Do not include cpu.h if it's not really necessary	2021-05-02 17:24:51 +02:00
xics_pnv.c	non-virt: Fix Lesser GPL version number	2020-11-15 16:38:24 +01:00
xics_spapr.c	Do not include cpu.h if it's not really necessary	2021-05-02 17:24:51 +02:00
xics.c	Do not include cpu.h if it's not really necessary	2021-05-02 17:24:51 +02:00
xilinx_intc.c	Use DECLARE_*CHECKER* macros	2020-09-09 09:27:09 -04:00
xive.c	dma: Let dma_memory_read/write() take MemTxAttrs argument	2021-12-30 17:16:32 +01:00
xlnx-pmu-iomod-intc.c	qdev: set properties with device_class_set_props()	2020-01-24 20:59:15 +01:00
xlnx-zynqmp-ipi.c	Include migration/vmstate.h less	2019-08-16 13:31:52 +02:00