mirror of
https://github.com/xemu-project/xemu.git
synced 2024-11-25 04:30:02 +00:00
5c90308f07
qemu_savevm_state_iterate() expects the iterators to return 1
when they are done, and 0 if there is still something left to do.
However, ram_save_iterate() does not obey this rule and returns
the number of saved pages instead. This causes a fatal hang with
ppc64 guests when you run QEMU like this (also works with TCG):
qemu-img create -f qcow2 /tmp/test.qcow2 1M
qemu-system-ppc64 -nographic -nodefaults -m 256 \
-hda /tmp/test.qcow2 -serial mon:stdio
... then switch to the monitor by pressing CTRL-a c and try to
save a snapshot with "savevm test1" for example.
After the first iteration, ram_save_iterate() always returns 0 here,
so that qemu_savevm_state_iterate() hangs in an endless loop and you
can only "kill -9" the QEMU process.
Fix it by using proper return values in ram_save_iterate().
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
|
||
|---|---|---|
| .. | ||
| block.c | ||
| colo-comm.c | ||
| colo-failover.c | ||
| colo.c | ||
| exec.c | ||
| fd.c | ||
| Makefile.objs | ||
| migration.c | ||
| postcopy-ram.c | ||
| qemu-file-channel.c | ||
| qemu-file.c | ||
| qjson.c | ||
| ram.c | ||
| rdma.c | ||
| savevm.c | ||
| socket.c | ||
| tls.c | ||
| trace-events | ||
| vmstate.c | ||
| xbzrle.c | ||