mirror of
https://github.com/xemu-project/xemu.git
synced 2024-11-24 20:19:44 +00:00
785ec4b1b9
Some error messages contain ambiguous representations of the 'node-name'
parameter. This can be particularly confusing when exchanging QMP
messages (C = client, S = server):
C: {"execute": "block_resize", "arguments": { "device": "my_file", "size": 26843545600 }}
S: {"error": {"class": "GenericError", "desc": "Cannot find device=my_file nor node_name="}}
^^^^^^^^^
This error message suggests one could send a message with a key called
'node_name':
C: {"execute": "block_resize", "arguments": { "node_name": "my_file", "size": 26843545600 }}
^^^^^^^^^
but using the underscore is actually incorrect, the parameter should be
'node-name':
S: {"error": {"class": "GenericError", "desc": "Parameter 'node_name' is unexpected"}}
This behavior was uncovered in bz1651437, but I ended up going down a
rabbit hole looking for other areas where this miscommunication might
occur and changing those accordingly as well.
Fixes: https://bugzilla.redhat.com/1651437
Signed-off-by: Connor Kuehl <ckuehl@redhat.com>
Message-Id: <20210305151929.1947331-2-ckuehl@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
48 lines
2.8 KiB
Plaintext
48 lines
2.8 KiB
Plaintext
QA output created by 249
|
|
Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=1048576
|
|
Formatting 'TEST_DIR/t.IMGFMT.int', fmt=IMGFMT size=1048576 backing_file=TEST_DIR/t.IMGFMT.base backing_fmt=IMGFMT
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1048576 backing_file=TEST_DIR/t.IMGFMT.int backing_fmt=IMGFMT
|
|
{ 'execute': 'qmp_capabilities' }
|
|
{"return": {}}
|
|
|
|
=== Send a write command to a drive opened in read-only mode (1)
|
|
|
|
{ 'execute': 'human-monitor-command',
|
|
'arguments': {'command-line': 'qemu-io none0 "aio_write 0 2k"'}}
|
|
{"return": "Block node is read-onlyrn"}
|
|
|
|
=== Run block-commit on base using an invalid filter node name
|
|
|
|
{ 'execute': 'block-commit',
|
|
'arguments': {'job-id': 'job0', 'device': 'none1', 'top-node': 'int',
|
|
'filter-node-name': '1234'}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "created", "id": "job0"}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "null", "id": "job0"}}
|
|
{"error": {"class": "GenericError", "desc": "Invalid node-name: '1234'"}}
|
|
|
|
=== Send a write command to a drive opened in read-only mode (2)
|
|
|
|
{ 'execute': 'human-monitor-command',
|
|
'arguments': {'command-line': 'qemu-io none0 "aio_write 0 2k"'}}
|
|
{"return": "Block node is read-onlyrn"}
|
|
|
|
=== Run block-commit on base using the default filter node name
|
|
|
|
{ 'execute': 'block-commit',
|
|
'arguments': {'job-id': 'job0', 'device': 'none1', 'top-node': 'int'}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "created", "id": "job0"}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "running", "id": "job0"}}
|
|
{"return": {}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "waiting", "id": "job0"}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "pending", "id": "job0"}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "BLOCK_JOB_COMPLETED", "data": {"device": "job0", "len": 1048576, "offset": 1048576, "speed": 0, "type": "commit"}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "concluded", "id": "job0"}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "null", "id": "job0"}}
|
|
|
|
=== Send a write command to a drive opened in read-only mode (3)
|
|
|
|
{ 'execute': 'human-monitor-command',
|
|
'arguments': {'command-line': 'qemu-io none0 "aio_write 0 2k"'}}
|
|
{"return": "Block node is read-onlyrn"}
|
|
*** done
|