mirror of
https://github.com/xemu-project/xemu.git
synced 2024-12-03 17:11:01 +00:00
f96a8cc3c6
There is a data race if the sequence is written concurrently to the read. In C11 this has undefined behavior. Use atomic_set; the read side is already using atomic_read. Reported-by: Alex Bennée <alex.bennee@linaro.org> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Message-Id: <20160930213106.20186-6-alex.bennee@linaro.org> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
66 lines
1.4 KiB
C
66 lines
1.4 KiB
C
/*
|
|
* Seqlock implementation for QEMU
|
|
*
|
|
* Copyright Red Hat, Inc. 2013
|
|
*
|
|
* Author:
|
|
* Paolo Bonzini <pbonzini@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*
|
|
*/
|
|
|
|
#ifndef QEMU_SEQLOCK_H
|
|
#define QEMU_SEQLOCK_H
|
|
|
|
#include "qemu/atomic.h"
|
|
#include "qemu/thread.h"
|
|
|
|
typedef struct QemuSeqLock QemuSeqLock;
|
|
|
|
struct QemuSeqLock {
|
|
unsigned sequence;
|
|
};
|
|
|
|
static inline void seqlock_init(QemuSeqLock *sl)
|
|
{
|
|
sl->sequence = 0;
|
|
}
|
|
|
|
/* Lock out other writers and update the count. */
|
|
static inline void seqlock_write_begin(QemuSeqLock *sl)
|
|
{
|
|
atomic_set(&sl->sequence, sl->sequence + 1);
|
|
|
|
/* Write sequence before updating other fields. */
|
|
smp_wmb();
|
|
}
|
|
|
|
static inline void seqlock_write_end(QemuSeqLock *sl)
|
|
{
|
|
/* Write other fields before finalizing sequence. */
|
|
smp_wmb();
|
|
|
|
atomic_set(&sl->sequence, sl->sequence + 1);
|
|
}
|
|
|
|
static inline unsigned seqlock_read_begin(QemuSeqLock *sl)
|
|
{
|
|
/* Always fail if a write is in progress. */
|
|
unsigned ret = atomic_read(&sl->sequence);
|
|
|
|
/* Read sequence before reading other fields. */
|
|
smp_rmb();
|
|
return ret & ~1;
|
|
}
|
|
|
|
static inline int seqlock_read_retry(const QemuSeqLock *sl, unsigned start)
|
|
{
|
|
/* Read other fields before reading final sequence. */
|
|
smp_rmb();
|
|
return unlikely(atomic_read(&sl->sequence) != start);
|
|
}
|
|
|
|
#endif
|