xemu/io at fd87a6bd3b78cc51be5be2cf1bccffd010a3f4cb - xemu

mirror of https://github.com/xemu-project/xemu.git synced 2025-02-20 12:24:42 +00:00

History

Peter Xu 8bd9c4e6c5 io: fix qio_channel_socket_accept err handling

When accept failed, we should setup errp with the reason. More
importantly, the caller may assume errp be non-NULL when error happens,
and not setting the errp may crash QEMU.

At the same time, move the trace_qio_channel_socket_accept_fail() after
the if check on EINTR. Two reasons:

1. when EINTR happened, it's not really a fault (we should just try
   again), so we should not log with an "accept failure".

2. trace_*() functions may overwrite errno, then the old errno will be
   missing. We need to either check errno before trace_*() calls, or
   reserve the errno.

Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <1501666880-10159-3-git-send-email-peterx@redhat.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

2017-08-02 11:27:44 +01:00

channel-buffer.c

io: avoid double-free when closing QIOChannelBuffer

2016-05-26 11:31:09 +05:30

channel-command.c

io: add methods to set I/O handlers on AioContext

2017-02-21 11:14:07 +00:00

channel-file.c

io: add methods to set I/O handlers on AioContext

2017-02-21 11:14:07 +00:00

channel-socket.c

io: fix qio_channel_socket_accept err handling