xenia-project/FFmpeg
1
0
Fork 0
mirror of https://github.com/xenia-project/FFmpeg.git synced 2024-11-28 22:10:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

oggdec: Initialize stream index to -1 in ogg_packet.

Browse Source 
The previous method of having to initialize it outside lead
to incorrect code: even if it was initialized, it usually was
only initialized once, thus a packet that could not be matched
to any stream would just be processed with the return values
from the previous call.

Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
This commit is contained in:
Reimar Döffinger 2012-08-05 09:45:04 +02:00
parent a4163b2d65
commit 69aeba1396
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
libavformat/oggdec.c
View File

@ -337,6 +337,13 @@ static int ogg_read_page(AVFormatContext *s, int *str)
return 0; return 0;
} }
/**
* @brief find the next Ogg packet
* @param *str is set to the stream for the packet or -1 if there is
* no matching stream, in that case assume all other return
* values to be uninitialized.
* @return negative value on error or EOF.
*/
static int ogg_packet(AVFormatContext *s, int *str, int *dstart, int *dsize, static int ogg_packet(AVFormatContext *s, int *str, int *dstart, int *dsize,
int64_t *fpos) int64_t *fpos)
{ {
@ -347,6 +354,8 @@ static int ogg_packet(AVFormatContext *s, int *str, int *dstart, int *dsize,
int segp = 0, psize = 0; int segp = 0, psize = 0;
av_dlog(s, "ogg_packet: curidx=%i\n", ogg->curidx); av_dlog(s, "ogg_packet: curidx=%i\n", ogg->curidx);
if (str)
*str = -1;
do{ do{
idx = ogg->curidx; idx = ogg->curidx;
@ -525,7 +534,6 @@ static int ogg_get_length(AVFormatContext *s)
ogg_save (s); ogg_save (s);
avio_seek (s->pb, s->data_offset, SEEK_SET); avio_seek (s->pb, s->data_offset, SEEK_SET);
ogg_reset(s); ogg_reset(s);
i = -1;
while (streams_left > 0 && !ogg_packet(s, &i, NULL, NULL, NULL)) { while (streams_left > 0 && !ogg_packet(s, &i, NULL, NULL, NULL)) {
int64_t pts; int64_t pts;
if (i < 0) continue; if (i < 0) continue;
@ -612,7 +620,7 @@ static int ogg_read_packet(AVFormatContext *s, AVPacket *pkt)
{ {
struct ogg *ogg; struct ogg *ogg;
struct ogg_stream *os; struct ogg_stream *os;
int idx = -1, ret; int idx, ret;
int pstart, psize; int pstart, psize;
int64_t fpos, pts, dts; int64_t fpos, pts, dts;
@ -671,7 +679,7 @@ static int64_t ogg_read_timestamp(AVFormatContext *s, int stream_index,
AVIOContext *bc = s->pb; AVIOContext *bc = s->pb;
int64_t pts = AV_NOPTS_VALUE; int64_t pts = AV_NOPTS_VALUE;
int64_t keypos = -1; int64_t keypos = -1;
int i = -1; int i;
int pstart, psize; int pstart, psize;
avio_seek(bc, *pos_arg, SEEK_SET); avio_seek(bc, *pos_arg, SEEK_SET);
ogg_reset(s); ogg_reset(s);