Files
Feng Tang 4df910620b mm: memcg: relayout structure mem_cgroup to avoid cache interference
0day reported one -22.7% regression for will-it-scale page_fault2
case [1] on a 4 sockets 144 CPU platform, and bisected to it to be
caused by Waiman's optimization (commit bd0b230fe1) of saving one
'struct page_counter' space for 'struct mem_cgroup'.

Initially we thought it was due to the cache alignment change introduced
by the patch, but further debug shows that it is due to some hot data
members ('vmstats_local', 'vmstats_percpu', 'vmstats') sit in 2 adjacent
cacheline (2N and 2N+1 cacheline), and when adjacent cache line prefetch
is enabled, it triggers an "extended level" of cache false sharing for
2 adjacent cache lines.

So exchange the 2 member blocks, while keeping mostly the original
cache alignment, which can restore and even enhance the performance,
and save 64 bytes of space for 'struct mem_cgroup' (from 2880 to 2816,
with 0day's default RHEL-8.3 kernel config)

[1]. https://lore.kernel.org/lkml/20201102091543.GM31092@shao2-debian/

Fixes: bd0b230fe1 ("mm/memcg: unify swap and memsw page counters")
Reported-by: kernel test robot <rong.a.chen@intel.com>
Signed-off-by: Feng Tang <feng.tang@intel.com>
Acked-by: Waiman Long <longman@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2020-11-26 09:35:49 -08:00
..
2020-06-25 22:25:13 -07:00
2020-06-16 14:19:57 +02:00
2020-10-28 13:18:56 +01:00
2020-05-24 20:48:11 +02:00
2020-07-21 08:24:52 -05:00
2020-07-08 10:48:35 -07:00
2020-10-02 14:59:25 -07:00
2020-09-21 15:00:40 -07:00
2020-10-02 15:00:49 -07:00
2020-10-16 17:21:51 +02:00
2020-06-16 19:25:20 +02:00
2020-07-27 14:29:23 -04:00
2020-08-12 20:42:08 +02:00
2020-06-17 00:07:38 +02:00
2020-10-27 16:22:43 +01:00
2020-09-30 22:44:26 +02:00
2020-07-24 17:12:41 -07:00
2020-08-04 21:02:38 -04:00
2020-09-16 08:54:53 -05:00
2020-05-18 10:30:21 +01:00
2020-08-26 12:41:56 +02:00
2020-11-19 22:38:29 -05:00
2020-10-13 18:38:32 -07:00
2020-06-02 15:15:46 +01:00
2020-09-04 09:25:20 -07:00
2020-05-28 10:31:09 +02:00
2020-09-23 18:02:49 -07:00
2020-09-04 12:46:07 +01:00
2020-08-27 16:06:47 -04:00
2020-10-07 14:28:39 -04:00
2020-07-01 10:49:02 +02:00
2020-09-24 19:49:36 -07:00
2020-07-23 17:34:18 +10:00
2020-08-31 12:52:33 -07:00
2020-10-28 11:41:15 -06:00
2020-10-18 09:27:10 -07:00
2020-08-18 17:06:15 +02:00
2020-07-16 23:19:51 +02:00
2020-11-06 10:05:18 -08:00
2020-08-07 11:33:24 -07:00
2020-09-26 22:55:05 -04:00
2020-07-04 09:35:36 -05:00
2020-09-10 14:03:31 -07:00
2020-07-07 11:58:59 -05:00
2020-08-01 11:28:17 +02:00
2020-10-18 09:27:10 -07:00
2020-10-05 13:21:49 +02:00