Commit Graph

49 Commits

Author SHA1 Message Date
Roardom
9bdbe9764c refactor: cached select group id by slug queries
Uses a better key. Doesn't use the cache when it's not needed.
2025-07-14 18:15:29 +00:00
Roardom
a7a72c1807 update: only select necessary database records for console commands 2024-08-18 10:10:07 +00:00
Roardom
bcea35be32 refactor: use mass assignment syntax in console commands
Cleaner code
2024-08-18 06:14:41 +00:00
Roardom
2b49384488 refactor: use early returns in console commands
Reducing indentation results in cleaner code and prevents bugs like #3802.
2024-08-18 05:03:09 +00:00
Roardom
7af1a9963c refactor: don't call ->toDateTimeString() on carbon instances
Eloquent already does this for us automatically by calling __toString() on Carbon instances with the default format being the same as the mysql timestamp format.
2024-08-17 09:20:08 +00:00
Roardom
2e91e1157f fix: some user group permissions
These permissions were never meant to be directly edited by staff. They should never have been added to the staff user edit page as it just caused confusion when the settings reset at the daily group change. I've now added these settings to the group directly and allow the settings on the user edit page to override the group settings. I refrained from fixing the can_download permission for now, because so many different things affect it and it will need at 3 separate permissions to control everything it does. Trying to fix it will take much more effort than what can be fixed today. Because of this, I removed the setting from the user edit page to reduce confusion from staff who don't realize it is controlled by the scheduler. Relevant issue: #1820.
2024-07-26 22:35:45 +00:00
Roardom
6d729fee16 fix: consistently upsert user into external announce on group change 2024-06-24 02:50:33 +00:00
Roardom
b86475a732 add: strict types to all files 2024-05-23 13:58:29 +00:00
HDVinnie
99f5f33283 update: commands 2024-05-06 15:54:19 -04:00
Roardom
8127734979 fix: various larastan command issues 2023-08-25 07:58:38 +00:00
Roardom
80428fdc88 refactor: swap count and comparisons to 0 with exists() 2023-06-19 23:18:40 +00:00
Roardom
05ad4c37b9 add: external tracker support 2023-03-27 04:17:30 -05:00
HDVinnie
f4ebee885c update: lint 2023-02-03 22:23:00 -05:00
HDVinnie
472c820f99 update: UNIT3D linting
- github action updated with new ruleset in pint.json
- codebase linted with new ruleset
- contributors can now run `./vendor/bin/pint`
- action workflow will auto correct any lint issues upon commit/opened pull request
2023-02-02 08:02:34 -05:00
Roardom
985423e267 update: announce 2023-01-04 05:46:02 -06:00
HDVinnie
21674f186c Merge branch '6.x.x' into simplify-user-model 2022-09-20 00:07:34 -04:00
Roardom
4811a7ceca refactor: simplify user model
Models shouldn't contain custom logic
2022-08-28 01:41:38 -05:00
HDVinnie
33494ca5ce refactor: simplify pointless boolean expressions in ifs 2022-08-25 19:17:06 -04:00
StyleCI Bot
e292545306 Apply fixes from StyleCI 2022-05-31 22:06:07 +00:00
Shift
be2d37ed6e Use Illuminate\Support\Carbon 2022-05-31 22:05:34 +00:00
HDVinnie
98521378d2 chore: phpdoc blocks 2022-01-10 17:46:43 -05:00
HDVinnie
dd19889ee6 Merge branch '6.x.x' into Code-Style 2022-01-10 17:03:50 -05:00
HDVinnie
5e01a26c88 optimize: whereIn and whereNotIn queries 2022-01-10 16:25:26 -05:00
HDVinnie
97394c062f chore: adopt type hints 2022-01-07 23:35:33 -05:00
HDVinnie
2a53cea216 refactor: newline after statement 2021-09-28 12:49:46 -04:00
Oha-you
540f2dea9f fix: Auto pruning with artisan auto:disable_inactive_users 2021-04-29 08:47:44 +03:00
HDVinnie
71e88f08ac refactor: disable inactive users command 2020-12-30 01:07:15 -05:00
HDVinnie
0733269867 update: phpdoc blocks 2020-07-22 16:57:13 -04:00
HDVinnie
a975116218 refactor: preslash simple functions
- Add pre-slash to short named functions to improve performance by almost 30%
-  @see https://stackoverflow.com/questions/55419673/php7-adding-a-slash-to-all-standard-php-functions-php-cs-fixer-rule
2020-07-22 15:09:37 -04:00
HDVinnie
b498b446e4 update: auto:disable_inactive_users command 2020-06-30 12:59:41 -04:00
HDVinnie
4afdfbdade Apply fixes from StyleCI
[ci skip] [skip ci]
2020-04-19 05:31:13 +00:00
HDVinnie
ea2a12be15 refactor: closure to arrow function 2020-04-14 20:38:48 -04:00
shlandturtle
96ced1ddb3 fix: Pruning commands 2020-03-09 22:12:03 +00:00
HDVinnie
408bfafc3e Apply fixes from StyleCI
[ci skip] [skip ci]
2020-03-05 15:47:30 +00:00
HDVinnie
4b9c006a05 chore: phpdoc blocks cleanup 2020-03-05 10:46:14 -05:00
HDVinnie
ad3ec8de19 tests: console commands 2020-02-25 13:01:48 -05:00
HDVinnie
e47afe4ab4 chore: styleci 2020-02-12 14:51:22 -05:00
HDVinnie
80c842e39c chore: update license block
- make styleci happy
2020-02-12 14:49:18 -05:00
HDVinnie
dbb928f940 chore: update license block 2020-02-12 14:45:59 -05:00
HDVinnie
0bece18c5c (Update) Group Queries 🚀
- add caching to system required groups
2019-11-20 12:11:41 -05:00
Innocente205
c04e862d01 Correct minor spelling 2019-11-13 11:59:39 +07:00
HDVinnie
d889971834 Apply fixes from StyleCI
[ci skip] [skip ci]
2019-11-05 22:40:30 +00:00
HDVinnie
eed3b51c92 (Update) CRUDDY PT.7 🚀 2019-10-25 17:35:14 -04:00
HDVinnie
8bb397c29c (Update) Standardize Select Queries 🚀 2019-03-13 11:26:20 -04:00
HDVinnie
e0e1aa924b Apply fixes from StyleCI 2019-02-22 13:16:32 +00:00
HDVinnie
3c87845e54 (Update) Namespace models under App\Models 🚀 2019-02-22 08:15:41 -05:00
HDVinnie
2f2c52328b Apply fixes from StyleCI 2018-12-06 22:57:41 +00:00
HDVinnie
00bb324053 Apply fixes from StyleCI 2018-12-06 14:42:13 +00:00
HDVinnie
ab01fcce33 (Update) Commands and Schedule
- use proper naming schema per laravel community standards.
2018-11-04 13:43:34 -05:00