Commit Graph

52 Commits

Author SHA1 Message Date
Roardom
9bdbe9764c refactor: cached select group id by slug queries
Uses a better key. Doesn't use the cache when it's not needed.
2025-07-14 18:15:29 +00:00
Roardom
0d92098d6f refactor: replace users.active with users.email_verified_at
This is the correct column intended to be used by the Laravel framework. `active` seems to be a custom column that was implemented in UNIT3D before Laravel added email verification in version 5.7.
2025-06-11 06:07:56 +00:00
HDVinnie
094f64ed46 refactor: mass private message system
- Dedicated CRUD controller
- Allow selected groups only
- Old Mass action controller will be moved to own Mass validate users controller in separate pr
- closes #4690
2025-05-06 08:37:54 -04:00
Roardom
868ad35aa4 refactor: swap magic RedirectResponse withX('Y') to with('X', 'Y')
Allows ctrl+clicking to access the underlying function unlike the previous magic implementation. Probably also negligibly faster.

Swapped all instances of `>withSuccess(` -> `>with('success', `, `>withWarning(` -> `>with('warning', `, and `>withInfo(` -> `>with('info', ` with ide's find and replace.
2025-01-21 16:05:11 +00:00
Roardom
2e91e1157f fix: some user group permissions
These permissions were never meant to be directly edited by staff. They should never have been added to the staff user edit page as it just caused confusion when the settings reset at the daily group change. I've now added these settings to the group directly and allow the settings on the user edit page to override the group settings. I refrained from fixing the can_download permission for now, because so many different things affect it and it will need at 3 separate permissions to control everything it does. Trying to fix it will take much more effort than what can be fixed today. Because of this, I removed the setting from the user edit page to reduce confusion from staff who don't realize it is controlled by the scheduler. Relevant issue: #1820.
2024-07-26 22:35:45 +00:00
Roardom
6d729fee16 fix: consistently upsert user into external announce on group change 2024-06-24 02:50:33 +00:00
Roardom
b86475a732 add: strict types to all files 2024-05-23 13:58:29 +00:00
Roardom
f8d6e73902 refactor: use system user id constant in more places 2024-02-24 05:08:58 +00:00
LostRager
222e5a1f91 Update MassActionController.php 2023-12-17 07:24:20 +01:00
Roardom
2ca7adbbe5 fix: various larastan controller issues 2023-08-25 09:13:18 +00:00
Roardom
5890ebc749 refactor: miscellaneous staff controller refactors 2023-07-07 00:28:47 +00:00
Roardom
9d4789ba91 refactor: require whitespace before statements 2023-07-07 00:27:13 +00:00
Roardom
05ad4c37b9 add: external tracker support 2023-03-27 04:17:30 -05:00
HDVinnie
f4ebee885c update: lint 2023-02-03 22:23:00 -05:00
HDVinnie
472c820f99 update: UNIT3D linting
- github action updated with new ruleset in pint.json
- codebase linted with new ruleset
- contributors can now run `./vendor/bin/pint`
- action workflow will auto correct any lint issues upon commit/opened pull request
2023-02-02 08:02:34 -05:00
Roardom
7dcc2e00cb refactor: move staff mass action request to form request 2023-01-08 05:04:49 -06:00
HDVinnie
594b7864d9 refactor: adopt new helpers in laravel 9 2022-03-06 17:20:05 -05:00
HDVinnie
dd19889ee6 Merge branch '6.x.x' into Code-Style 2022-01-10 17:03:50 -05:00
HDVinnie
5e01a26c88 optimize: whereIn and whereNotIn queries 2022-01-10 16:25:26 -05:00
HDVinnie
d3abd28925 update: type hints 2022-01-08 15:35:53 -05:00
HDVinnie
97394c062f chore: adopt type hints 2022-01-07 23:35:33 -05:00
clandestine8
a737482e79 Apply fixes from StyleCI
[ci skip] [skip ci]
2021-09-06 23:26:02 +00:00
HDVinnie
321847e067 Apply fixes from StyleCI
[ci skip] [skip ci]
2021-05-16 02:41:53 +00:00
HDVinnie
3407075214 refactor: better php8 usage
- Change simple property init and assign to constructor promotion
- Remove unused variable in catch()
- Change docs types to union types, where possible
2021-05-15 22:41:28 -04:00
HDVinnie
d8c7cdacf2 refactor: staff mass action controller 2020-12-30 12:18:16 -05:00
HDVinnie
b4521b696d cleanup: masss action controller 2020-12-28 23:44:41 -05:00
HDVinnie
7e664a667b Apply fixes from StyleCI
[ci skip] [skip ci]
2020-12-03 02:27:21 +00:00
HDVinnie
e92aabae41 update: phpdoc blocks 2020-12-02 21:27:04 -05:00
HDVinnie
e703bc7765 Apply fixes from StyleCI
[ci skip] [skip ci]
2020-10-07 01:43:19 +00:00
HDVinnie
eb0b6380d3 update: mass action controller
- pull cached groups that should not be included in the MassPM.
- update users query to not included exempt group and only pluck the users id.
2020-10-06 21:43:04 -04:00
HDVinnie
0733269867 update: phpdoc blocks 2020-07-22 16:57:13 -04:00
HDVinnie
a975116218 refactor: preslash simple functions
- Add pre-slash to short named functions to improve performance by almost 30%
-  @see https://stackoverflow.com/questions/55419673/php7-adding-a-slash-to-all-standard-php-functions-php-cs-fixer-rule
2020-07-22 15:09:37 -04:00
HDVinnie
4afdfbdade Apply fixes from StyleCI
[ci skip] [skip ci]
2020-04-19 05:31:13 +00:00
HDVinnie
ea2a12be15 refactor: closure to arrow function 2020-04-14 20:38:48 -04:00
HDVinnie
6160c03ede refactor: change variable with read only status and default value to a constant 2020-03-06 09:04:22 -05:00
HDVinnie
408bfafc3e Apply fixes from StyleCI
[ci skip] [skip ci]
2020-03-05 15:47:30 +00:00
HDVinnie
4b9c006a05 chore: phpdoc blocks cleanup 2020-03-05 10:46:14 -05:00
HDVinnie
b5c0471576 tests: staff mass action controller 2020-03-03 11:33:17 -05:00
HDVinnie
c8d953a3ad Merge branch 'master' into development 2020-02-12 18:03:21 -05:00
HDVinnie
e47afe4ab4 chore: styleci 2020-02-12 14:51:22 -05:00
HDVinnie
80c842e39c chore: update license block
- make styleci happy
2020-02-12 14:49:18 -05:00
HDVinnie
dbb928f940 chore: update license block 2020-02-12 14:45:59 -05:00
HDVinnie
8d72989943 Apply fixes from StyleCI
[ci skip] [skip ci]
2020-02-12 17:41:17 +00:00
HDVinnie
611fcd6bc1 refactor: if / else / elseif statements
- Change If Else Value Assign To Early Return
- Change Nested Ifs To Early Return
- Remove Always Else
2020-02-12 12:34:34 -05:00
HDVinnie
0bece18c5c (Update) Group Queries 🚀
- add caching to system required groups
2019-11-20 12:11:41 -05:00
HDVinnie
e0379e5b95 (Add) Audit System 🆕
- filtering to follow
2019-11-06 06:42:17 -05:00
HDVinnie
d889971834 Apply fixes from StyleCI
[ci skip] [skip ci]
2019-11-05 22:40:30 +00:00
HDVinnie
e9378b71fa (Update) Minor Cleanup 🚀 2019-11-05 17:05:39 -05:00
HDVinnie
92f825289e (Update) CRUDDY PT.10 🚀 2019-11-03 13:09:45 -05:00
HDVinnie
da30d2a706 (Update) CRUDDY PT.8 🚀 2019-10-29 20:26:54 -04:00