20 Commits

Author SHA1 Message Date
Roardom
a3063fb8c5 refactor: normalize request votes
Cleans up the code and better normalization practice. Should this ever be a performance issue (such as sorting by vote count on request search page), then it'd probably be better to use meilisearch, but currently with 60k bounties, the query time only takes ~300ms compared to the 40ms previously.
2025-06-22 00:49:41 +00:00
Roardom
b05f3e0e47 fix: filled request filter broken when fill approver soft deleted
Use the timestamp instead of the user id as it doesn't disappear when the user is (soft) deleted. The `whereDoesntHave` is the real issue here since it handles soft deletion, but since users are also deletable, handle all cases where it checks the field directly as well to instead use the timestamp.
2025-05-04 21:51:38 +00:00
Jay Sizzla
6e34a86388 Use shouldSend for NewBounty notifications 2025-02-27 13:09:23 +00:00
Roardom
868ad35aa4 refactor: swap magic RedirectResponse withX('Y') to with('X', 'Y')
Allows ctrl+clicking to access the underlying function unlike the previous magic implementation. Probably also negligibly faster.

Swapped all instances of `>withSuccess(` -> `>with('success', `, `>withWarning(` -> `>with('warning', `, and `>withInfo(` -> `>with('info', ` with ide's find and replace.
2025-01-21 16:05:11 +00:00
HDVinnie
192b5ed15d chore: remove unused imports that pint is missing 2024-12-01 20:52:32 -05:00
Roardom
64a60089d9 refactor: treat sprintf as native function
This breaks the pint CI currently. This is probably due to the next version of php (8.4) adding opcache optimizations to sprintf and our config requiring pre-slashing native functions.
2024-08-09 21:08:26 +00:00
Roardom
2117a4fcd1 fix: unexpected incrementEach effects
see https://github.com/laravel/framework/issues/49009
2024-05-28 03:33:01 +00:00
Roardom
12903f64ac fix: strict type issues
Don't pass null into functions that don't accept null.
2024-05-23 17:40:16 +00:00
Roardom
b86475a732 add: strict types to all files 2024-05-23 13:58:29 +00:00
HDVinnie
7160ae00c2 Merge pull request #3594 from Roardom/typed-notifications 2024-03-02 10:11:52 -05:00
Roardom
c7408be672 update: pass types directly into some notifications
Only the request notifications for now, but they should all get done with time.
2024-03-01 17:58:24 +00:00
Roardom
98c32a38f3 update: remove request bon transactions
This data is already stored in the requests and bounty tables. At this point, the name and comment fields are duplicates of each other and don't need to both be kept.
2024-02-26 09:33:33 +00:00
Roardom
1348ffeaa8 fix: reorder seedbonus decrement so error is generated first 2023-08-31 09:20:50 +00:00
Roardom
182cfeaca7 fix: add type hints to notifications 2023-08-26 08:14:04 +00:00
Roardom
011b92f37c add: allow editing bounty anonymity 2023-07-30 06:58:21 +00:00
Roardom
229eed8091 refactor: use _id suffix on bon_transactions foreign keys 2023-07-22 21:30:50 +00:00
Roardom
70e3505886 update: cruddy requests
Separate requests into cruddy routes. Use route model binding. Allow forfeit of award if request approval is revoked. Use form requests.
2023-07-07 03:18:13 +00:00
Roardom
9d4789ba91 refactor: require whitespace before statements 2023-07-07 00:27:13 +00:00
Roardom
d2e36c368e refactor: reduce temporary variables passed to views 2023-06-19 23:25:40 +00:00
Roardom
4c93353f03 update: cruddy request controller 2023-04-21 21:49:35 +00:00