4ian/GDevelop
1
0
Fork 0
mirror of https://github.com/4ian/GDevelop.git synced 2026-10-12 02:01:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add failing tests for variable type checks

Browse Source 
These tests reproduce 2 issues found while reviewing #9105. They are
expected to fail until the corresponding code is fixed.

- "primitive" is ignored for "variableOrProperty" and
  "variableOrPropertyOrParameter" parameters. ExpressionValidator only
  checks Type::Variable, Type::ObjectVariable and Type::LegacyVariable,
  so the 6 built-in variable conditions and actions declaring
  "primitive" never raise an error on a structure or an array.

- isIntoBrackets is reset to false instead of being restored in
  OnVisitVariableBracketAccessorNode, so a nested bracket accessor makes
  the following empty node fall back to the generic message instead of
  the bracket specific one.

Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01U3gfFre6be5CeT4rhTCeST
This commit is contained in:
Claude
2026-09-21 11:41:47 +00:00
parent d2e90ccc1b
commit de4e2f8c19
1 changed files with 50 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Core/tests/ExpressionParser2.cpp
+50
View File
@@ -2475,6 +2475,39 @@ TEST_CASE("ExpressionParser2", "[common][events]") {
RequireNoError(validator);
}
// This is the parameter type used by the built-in "Value of a variable"
// condition (and its number/text/boolean variants).
SECTION("Invalid scene variable structure in a primitive "
"variableOrPropertyOrParameter parameter (1 level)") {
auto node = parser.ParseExpression("MySceneStructureVariable");
gd::ExpressionValidator validator(platform, projectScopedContainers,
"variableOrPropertyOrParameter", "",
"primitive");
node->Visit(validator);
RequireNoFatalError(validator);
RequireAllErrorsCount(validator, 1);
REQUIRE(validator.GetAllErrors()[0]->GetMessage() ==
"You need to specify the name of the child variable to access. For "
"example: `MyVariable.child`.");
}
// This is the parameter type used by the built-in "Change variable value"
// action (and its number/text/boolean variants).
SECTION("Invalid scene variable structure in a primitive "
"variableOrProperty parameter (1 level)") {
auto node = parser.ParseExpression("MySceneStructureVariable");
gd::ExpressionValidator validator(platform, projectScopedContainers,
"variableOrProperty", "", "primitive");
node->Visit(validator);
RequireNoFatalError(validator);
RequireAllErrorsCount(validator, 1);
REQUIRE(validator.GetAllErrors()[0]->GetMessage() ==
"You need to specify the name of the child variable to access. For "
"example: `MyVariable.child`.");
}
SECTION("Valid scene variable structure in a variable parameter of a function (1 level)") {
auto node = parser.ParseExpression(
"MyExtension::GetAnyVariableAsNumber(MySceneStructureVariable)");
@@ -4659,6 +4692,23 @@ TEST_CASE("ExpressionParser2", "[common][events]") {
REQUIRE(validator.GetFatalErrors()[0]->GetMessage() ==
"You must enter a valid expression inside the brackets.");
}
SECTION("empty expression after a nested bracket accessor") {
// While typing `myVariable[MySceneStructureVariable["MyChild"] + 1]`,
// the index expression is incomplete: the bracket specific message must
// still be used.
auto node = parser.ParseExpression(
"myVariable[MySceneStructureVariable[\"MyChild\"] + ]");
REQUIRE(node != nullptr);
gd::ExpressionValidator validator(platform, projectScopedContainers, "scenevar");
node->Visit(validator);
RequireFatalErrorsCount(validator, 2);
// The closing bracket is eaten by the empty expression.
REQUIRE(validator.GetFatalErrors()[0]->GetMessage() ==
"Missing a closing bracket. Add a closing bracket for each opening bracket.");
REQUIRE(validator.GetFatalErrors()[1]->GetMessage() ==
"You must enter a valid expression inside the brackets.");
}
SECTION("number instead") {
auto node = parser.ParseExpression("1234");
REQUIRE(node != nullptr);