AssetRipper/AssetRipper.TextureDecoder
1
0 Fork 0
mirror of https://github.com/AssetRipper/AssetRipper.TextureDecoder.git synced 2026-11-12 18:07:28 -10:00
Code Issues Packages Projects Releases 1 Wiki Activity

Replace Unsafe.As with Unsafe.BitCast where appropriate

Browse Source
This commit is contained in:
ds5678 committed 2026-02-26 17:39:51 -08:00
1 parent ec6754a5d2
commit 09067cecbb
5 files changed
+246 -246
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

AssetRipper.TextureDecoder.ColorGenerator/NumericConversionGenerator.cs
+15 -15
View File
@@ -82,14 +82,14 @@ internal static class NumericConversionGenerator
writer.WriteLine("if (typeof(TFrom) == typeof(TTo))");
using (new CurlyBrackets(writer))
{
writer.WriteLine("return Unsafe.As<TFrom, TTo>(ref value);");
writer.WriteLine("return Unsafe.BitCast<TFrom, TTo>(value);");
}
foreach (CSharpPrimitives.Data from in CSharpPrimitives.List)
{
writer.WriteLine($"else if (typeof(TFrom) == typeof({from.LangName}))");
using (new CurlyBrackets(writer))
{
writer.WriteLine($"return {ConvertMethodName(from.Type)}<TTo>(Unsafe.As<TFrom, {from.LangName}>(ref value));");
writer.WriteLine($"return {ConvertMethodName(from.Type)}<TTo>(Unsafe.BitCast<TFrom, {from.LangName}>(value));");
}
}
writer.WriteLine("else");
@@ -133,32 +133,32 @@ internal static class NumericConversionGenerator
{
if (from == to)
{
writer.WriteLine($"return Unsafe.As<{to.LangName}, TTo>(ref value);");
writer.WriteLine($"return Unsafe.BitCast<{to.LangName}, TTo>(value);");
}
else if (to.HasPointerSize(out CSharpPrimitives.Data? bit32To, out CSharpPrimitives.Data? bit64To))
{
using (new If(writer, "IntPtr.Size == sizeof(int)"))
{
writer.WriteLine($"{to.LangName} converted = ({to.LangName}){methodName}<{bit32To.LangName}>(value);");
writer.WriteLine($"return Unsafe.As<{to.LangName}, TTo>(ref converted);");
writer.WriteLine($"return Unsafe.BitCast<{to.LangName}, TTo>(converted);");
}
using (new Else(writer))
{
writer.WriteLine($"{to.LangName} converted = ({to.LangName}){methodName}<{bit64To.LangName}>(value);");
writer.WriteLine($"return Unsafe.As<{to.LangName}, TTo>(ref converted);");
writer.WriteLine($"return Unsafe.BitCast<{to.LangName}, TTo>(converted);");
}
}
else if (to.IsSignedInteger(out CSharpPrimitives.Data? unsignedTo))
{
writer.WriteLine($"{to.LangName} converted = {ChangeSign}({methodName}<{unsignedTo.LangName}>(value));");
writer.WriteLine($"return Unsafe.As<{to.LangName}, TTo>(ref converted);");
writer.WriteLine($"return Unsafe.BitCast<{to.LangName}, TTo>(converted);");
}
else if (from.IsFloatingPoint)
{
if (to.IsFloatingPoint)
{
writer.WriteLine($"{to.LangName} converted = ({to.LangName})value;");
writer.WriteLine($"return Unsafe.As<{to.LangName}, TTo>(ref converted);");
writer.WriteLine($"return Unsafe.BitCast<{to.LangName}, TTo>(converted);");
}
else
{
@@ -176,7 +176,7 @@ internal static class NumericConversionGenerator
string maxValue = to.MaxValue;
writer.WriteLine($"{from.LangName} x = value * ({from.LangName}){maxValue};");
writer.WriteLine($"{to.LangName} converted = ({from.LangName}){maxValue} < x ? {maxValue} : (x > ({from.LangName}){minValue} ? ({to.LangName})x : {minValue});");
writer.WriteLine($"return Unsafe.As<{to.LangName}, TTo>(ref converted);");
writer.WriteLine($"return Unsafe.BitCast<{to.LangName}, TTo>(converted);");
}
}
}
@@ -191,12 +191,12 @@ internal static class NumericConversionGenerator
writer.WriteComment($"There isn't enough precision to convert from {from.LangName} to {to.LangName}, so we convert to {conversionType.LangName} first.");
writer.WriteLine($"{conversionType.LangName} x = {methodName}<{conversionType.LangName}>(value);");
writer.WriteLine($"{to.LangName} converted = ({to.LangName})x;");
writer.WriteLine($"return Unsafe.As<{to.LangName}, TTo>(ref converted);");
writer.WriteLine($"return Unsafe.BitCast<{to.LangName}, TTo>(converted);");
}
else
{
writer.WriteLine($"{to.LangName} converted = ({to.LangName})value / ({to.LangName}){from.MaxValue};");
writer.WriteLine($"return Unsafe.As<{to.LangName}, TTo>(ref converted);");
writer.WriteLine($"return Unsafe.BitCast<{to.LangName}, TTo>(converted);");
}
}
else
@@ -216,7 +216,7 @@ internal static class NumericConversionGenerator
writer.Write($"(({conversionType})value << {i * from.Size * 8}) | ");
}
writer.WriteLine("value);");
writer.WriteLine($"return Unsafe.As<{to.LangName}, TTo>(ref converted);");
writer.WriteLine($"return Unsafe.BitCast<{to.LangName}, TTo>(converted);");
}
}
else
@@ -227,14 +227,14 @@ internal static class NumericConversionGenerator
writer.WriteComment("This is a special case where we already know an optimal algorithm.");
writer.WriteLine("uint x = (value * 255u + 32895u) >> 16;");
writer.WriteLine("byte converted = unchecked((byte)x);");
writer.WriteLine("return Unsafe.As<byte, TTo>(ref converted);");
writer.WriteLine("return Unsafe.BitCast<byte, TTo>(converted);");
}
else if (from.Size < sizeof(double) && to.Size < sizeof(double))
{
writer.WriteLine($"double interpolated = (double)value / (double){from.MaxValue};");
writer.WriteLine($"double exact = interpolated * (double){to.MaxValue};");
writer.WriteLine($"{to.LangName} converted = ({to.LangName})double.Round(exact, MidpointRounding.AwayFromZero);");
writer.WriteLine($"return Unsafe.As<{to.LangName}, TTo>(ref converted);");
writer.WriteLine($"return Unsafe.BitCast<{to.LangName}, TTo>(converted);");
}
else
{
@@ -245,7 +245,7 @@ internal static class NumericConversionGenerator
{
int offset = (from.Size / to.Size - 1) * to.Size * 8;
writer.WriteLine($"{to.LangName} converted = ({to.LangName})(({conversionType})value >> {offset});");
writer.WriteLine($"return Unsafe.As<{to.LangName}, TTo>(ref converted);");
writer.WriteLine($"return Unsafe.BitCast<{to.LangName}, TTo>(converted);");
}
}
}
@@ -276,7 +276,7 @@ internal static class NumericConversionGenerator
using (new CurlyBrackets(writer))
{
writer.WriteLine($"{from.LangName} value = {methodName}Safe<{from.LangName}>();");
writer.WriteLine($"return Unsafe.As<{from.LangName}, T>(ref value);");
writer.WriteLine($"return Unsafe.BitCast<{from.LangName}, T>(value);");
}
}
writer.WriteLine("else");
AssetRipper.TextureDecoder/Exr/BinaryWriterExtensions.cs
+4 -4
View File
@@ -76,16 +76,16 @@ internal static class BinaryWriterExtensions
switch (Unsafe.SizeOf<T>())
{
case sizeof(byte):
writer.Write(Unsafe.As<T, byte>(ref value));
writer.Write(Unsafe.BitCast<T, byte>(value));
break;
case sizeof(ushort):
writer.Write(Unsafe.As<T, ushort>(ref value));
writer.Write(Unsafe.BitCast<T, ushort>(value));
break;
case sizeof(uint):
writer.Write(Unsafe.As<T, uint>(ref value));
writer.Write(Unsafe.BitCast<T, uint>(value));
break;
case sizeof(ulong):
writer.Write(Unsafe.As<T, ulong>(ref value));
writer.Write(Unsafe.BitCast<T, ulong>(value));
break;
}
}
AssetRipper.TextureDecoder/Rgb/Color.cs
+1 -1
View File
@@ -82,7 +82,7 @@ public static class Color
{
if (typeof(TThis) == typeof(TTarget))
{
return Unsafe.As<TThis, TTarget>(ref color);
return Unsafe.BitCast<TThis, TTarget>(color);
}
else
{
AssetRipper.TextureDecoder/Rgb/NumericConversion.cs
+2 -2
View File
@@ -42,7 +42,7 @@ public static partial class NumericConversion
TFrom SignBit = TFrom.One << (Unsafe.SizeOf<TFrom>() * 8 - 1);
TFrom converted = (SignBit ^ value);
return Unsafe.As<TFrom, TTo>(ref converted);
return Unsafe.BitCast<TFrom, TTo>(converted);
}
[MethodImpl(MethodImplOptions.AggressiveInlining | MethodImplOptions.AggressiveOptimization)]
@@ -56,6 +56,6 @@ public static partial class NumericConversion
}
TTo SignBit = TTo.One << (Unsafe.SizeOf<TTo>() * 8 - 1);
return SignBit ^ Unsafe.As<TFrom, TTo>(ref value);
return SignBit ^ Unsafe.BitCast<TFrom, TTo>(value);
}
}
AssetRipper.TextureDecoder/Rgb/NumericConversion.g.cs
+224 -224
View File
File diff suppressed because it is too large. Load diff