When cloning a table we loop over all the columns and clone them, but if a column
contains an expression with a reference to a later column, we'll throw an exception
unless we delay the expression compilation until all the columns have been added
to the new table clone.
So I've split out the expression compilation logic from the Expression property setter,
and now the column Clone method only sets the field. The Clone caller is responsible
for calling CompileExpression on the cloned column after adding all the cloned columns to
the cloned table.
* Fixes to the SUBSTRING and TRIM function to allow
a wider range of functions to be passed as
parameters. This fixes xamarin #665
* Fix to the Parser.jay grammar to eliminate the
reduce/reduce conflicts.
* Dropping the string concatenation code and instead
use the existing arithmetic addition operator which
also fixes the concatenation operation in the presence
of null values
* Adds the null literal
With the associated test cases.
- It is recommended to set auto-increment fields to ReadOnly. When
calling Copy() the check for ReadOnly must be omitted, otherwise
you get an exception.
The RadOnly attribute is set for the parent "Id" field to test
proper handling of read-only fields.
- Source reindention and cleanups.
Signed-off-by: Carsten Schlote <[email protected]>
- When calling GetChanges() the ReadOnly check for DataCalumns must be
turned off, as otherwise data of readonly columns can't be cloned
into new rows for the new created DataSet/dataTable
Signed-off-by: Carsten Schlote <[email protected]>
** Fixes#456234 - Patch by [email protected]
* OdbcDataReader.cs (GetValue): Handle SQL_NO_TOTAL sanely and
use corresponding Decoder.GetChars instead of Encoding.GetString.
** Fixes#582732 - Patch by Jeffrey Alvarez <[email protected]>
* DataColumn.cs (Clone): Deep copy the ExtendedProperties
collection.
* XmlSchemaDataImporter.cs: Support import of extended
properties.
* XmlSchemaWriter.cs: Fix exception by writing the extended
properties before simpletype element.
** Fixes#561667
* SqlCommand.cs (Dispose): While Disposing, set connection's
datareader to null so the connection can be reused with another datareader.
This is a scripted conversion of mixed line-ending files to LF-only or CRLF-only
based on which patch is smaller. I used a threshold of upto a quarter of the
lines to determine whether to keep the patch or not.
This set of .gitattributes was automatically generated from the list of files
that GIT tried to normalize when I enabled automatic EOL conversion.
With this set of attributes, we prevent automated EOL conversion on files that
we know will cause trouble down the road.
** Fixes#565616 - Based on Patch by Hubert FONGARNAND
* DataContainer.cs (GetContainerData): If typecode is string,
call Convert.ToString() irrespective of whether value is
IConvertible or not.
** Fixes#581679
* DataRelationCollection.cs (Add, Remove): Use DataRelation obj
instead of this when raising OnCollectionChang(ing, ed) events.
svn path=/trunk/mcs/; revision=159447
** Fixes#613087
* Tds.cs (ProcessLoginAck): Fix server version being compared in
the switch-case.
* Tds70.cs (BuildPreparedParameters, BuildProcedureCall): Set
* default
precision to 18 as used by MS.Net when connecting to SqlServer
7.0.
(BuildExec, ExecRPC): Marked protected in order to be used by
Tds80
and henceforth.
* Tds80.cs (Execute): Separated from Tds70 to include Tds80
* changes.
svn path=/trunk/mcs/; revision=158951
** Fixes#591443
* DataColumn.cs (Clone): Use propert to clone Expression as it
* builds
compiled expression also, if any.
svn path=/trunk/mcs/; revision=155216
** Fixes #564833/580736
* DbDataAdapter.cs (*Command): Fix for .NET compatibility which
supports both type of adapters with/without discrete command
instances.
svn path=/trunk/mcs/; revision=154270
* XmlSchemaDataImporter.cs: the <connections> element might be
empty - make sure FirstChild of the element is not null before
attempting to use it. Fixes bug #578587
svn path=/trunk/mcs/; revision=151201