Commit Graph
2588 Commits
Author SHA1 Message Date
Atsushi Eno 2571e8fa43 2009-01-16 Atsushi Enomoto <[email protected]>
* DataColumnTest.cs : try a string comparison fix.


svn path=/trunk/mcs/; revision=123557
2009-01-16 00:50:33 +00:00
Raja R Harinath 2c3d3c3c42 * DataRelationCollection.cs (BinarySerialize): New. Carved out of ...
* DataSet.cs (BinarySerialize): ... this.

svn path=/trunk/mcs/; revision=122412
2009-01-05 07:32:17 +00:00
Raja R Harinath 95fc061ac6 * DataRelationCollection.cs: Sequester NET_2_0 and NET_1_1 specific code into separate parts.
svn path=/trunk/mcs/; revision=122411
2009-01-05 07:31:45 +00:00
Raja R Harinath c5306b4ddc Move DataSet.Tables serialization to DataTableCollection
* DataTableCollection.cs (BinarySerialize_Schema): New.
(BinarySerialize_Data): Likewise.  Carved out of ...
* DataSet.cs (BinarySerialize): ... this.

svn path=/trunk/mcs/; revision=122410
2009-01-05 07:31:20 +00:00
Raja R Harinath 3a1b121b33 * DataTableCollection.cs: Sequester NET_2_0 and NET_1_1 specific code into separate parts.
svn path=/trunk/mcs/; revision=122409
2009-01-05 07:30:49 +00:00
Gert Driesen 2188d2883c * DataReaderTest.cs: Added tests for GetValue. Improved test
for GetBytes.

svn path=/trunk/mcs/; revision=122399
2009-01-04 21:47:09 +00:00
Gert Driesen a2589359cd * SqlCommandBuilderTest.cs: Improved tests to also check
behavior of RefreshSchema.
* SqlDataReaderTest.cs: Added tests for GetBytes.

svn path=/trunk/mcs/; revision=122398
2009-01-04 21:45:09 +00:00
Gert Driesen e3c0d4579c * SqlDataReader.cs: Added GetSchemaRowDbType overload for
getting sql type of a given column (identified using its
ordinal). Modified GetBytes to throw SqlNullValueException
(2.0 profile) or return 0 (1.0 profile) when reading bytes
sequentially. Added support for non-sequentially reading
text and ntext columns using GetBytes. Modified GetChar
to throw a NotSupportedException to match MS.

svn path=/trunk/mcs/; revision=122396
2009-01-04 21:38:09 +00:00
Gert Driesen e9afd5d74d * SqlCommandBuilder.cs (RefreshSchema): Clear commands.
svn path=/trunk/mcs/; revision=122395
2009-01-04 20:55:09 +00:00
Gert Driesen a7331a74c3 * DataReaderTest.cs: Added tests for GetChars, GetOrdinal,
GetValue and GetValues. Improved existing tests.
* DbDataReaderTest.cs: Moved GetProviderSpecificValue test
to provider specific tests (as its behavior differs between
Odbc and SqlClient). Removed unused property.

svn path=/trunk/mcs/; revision=122384
2009-01-03 23:33:20 +00:00
Gert Driesen 8a6bd370d1 Save as UTF-8.
svn path=/trunk/mcs/; revision=122383
2009-01-03 23:27:27 +00:00
Gert Driesen 37d01cae34 * SqlCommandBuilderTest.cs: Improve Get*Command tests.
* SqlCommandTest.cs: Fixed warning.
* SqlConnectionTest.cs: Removed unused property.
* SqlDataReaderTest.cs: Enabled GetChars test on 1.0
profile. Added GetValues test. Added and improved
GetSqlValue tests. Improved HasRows and NextResult
tests. Added GetFieldType tests. Added big batch of
schema-related tests.
* SqlParameterTest.cs: Moved disconnected tests to
System.Data test suite. Improved test for bug
#382635. Added test for failed conversion to SQL type.


svn path=/trunk/mcs/; revision=122382
2009-01-03 23:24:47 +00:00
Gert Driesen 1e50a2325f * SqlDataReader.cs: Removed unused dataTypeNames, and
unnecessary initializations. Added missing reader state
and row state checks. Fixed implementation of HasRows.
Modified type of DataType to object on 1.0 profile for
compatibility with .NET 1.x. Do not mark (Big)VarBinary
or ((Big)Binary as long, as unit tests show that IsLong
is for wide (unicode) data types. Fixed type data for
SmallDateTime and SmallMoney data types. Improved support
for bigint data type (using TDS 7.0).

svn path=/trunk/mcs/; revision=122381
2009-01-03 23:07:06 +00:00
Gert Driesen 55a3f19733 * SqlCommand.cs: Moved connection reset before the throw.
Improved exception message.

svn path=/trunk/mcs/; revision=122380
2009-01-03 22:59:29 +00:00
Gert Driesen 9ec8751239 * SqlCommandBuilder.cs: Only set SourceColumn for null check
parameters on the 2.0 profile, and set SourceVersion to
Current on 1.0 profile. Changed accessibility of RefreshSchema
to public, and do not immediately create commands. Removed
CWL.

svn path=/trunk/mcs/; revision=122379
2009-01-03 22:55:09 +00:00
Gert Driesen 7c73fb19d6 * SqlParameterTest.cs: Added .ctor tests. Improved
ParameterType and ResetDbType tests. Added ParameterName,
SourceColumn and Value tests. Partially enable SqlValue
test.

svn path=/trunk/mcs/; revision=122378
2009-01-03 22:48:07 +00:00
Gert Driesen 83cff6650f * SqlParameter.cs: When setting ParameterName or sourceName to
null, use a zero-length string instead. On 1.0 profile, only
infer type from value if value is not null or DBNull. Store
raw value in TdsMetadataParameter, and use delegate to convert
it to framework type (when necessary). Improve implementation
of SqlValue (still needs lots of work).

svn path=/trunk/mcs/; revision=122376
2009-01-03 22:40:34 +00:00
Gert Driesen 13b9781926 * System.Data_test.dll.sources: Added SqlCommandBuilderTest.cs
and SqlParameterTest.cs.
* DbCommandBuilder.cs (QuoteIdentifier): Throw NotSupportedException.
* DbDataAdapter.cs (Update): Add row causing concurrency violation
to DBConcurrencyException.
* OdbcCommandBuilder.cs (QuoteIdentifier): Escape QuoteSuffix
character(s) in unquoted identifier.
* SqlCommandBuilder.cs: Added missing checks for QuotePrefix and
QuoteSuffix on 2.0 profile, and return a zero-length string if
not set (or set to null) on 1.0 profile. Do not allow the value
of CatalogSeparator and SchemaSeparator to be changed from '.'.
Modified generated SQL to match MS. Added implementation for
QuoteIdenfifier. Modified parameters to match MS.
* SqlParameter.cs (SqlValue): Keep Value in sync.
* DbCommandBuilderTest.cs: Added test for QuoteIdentifier.
* OdbcCommandBuilderTest.cs: Enabled test for QuoteIdentifier.
* SqlCommandBuilderTest.cs: Added tests for CatalogLocation,
CatalogSeparator, ConflictOption, QuoteIdentifier, QuotePrefix,
QuoteSuffix  and SchemaSeparator.
* SqlParameterTest.cs: Moved existing tests from ProviderTests
to increase their visibility. Added tests for type inference.

svn path=/trunk/mcs/; revision=122361
2009-01-03 14:24:15 +00:00
Ivan Zlatev 65b7926385 2009-01-02 Ivan N. Zlatev <[email protected]>
* DataViewManager.cs: Implement all MonoTODO. Fixes the WinForms
	DataBinding unit tests.

svn path=/trunk/mcs/; revision=122333
2009-01-02 13:27:10 +00:00
Ivan Zlatev 016e720dee 2009-01-01 Ivan N. Zlatev <[email protected]>
* DataViewManager.cs: Hookup to the table/relations changed events and
	raise ListChanged events accordingly.

svn path=/trunk/mcs/; revision=122315
2009-01-01 18:46:02 +00:00
Gert Driesen 25c01a2252 * app-default.config: Renamed to app-net_1_1.config, and added
providerTests section.
* app-net_2.0.config: Added providerTests section and removed
mono.data section.
* Makefile: Added support for CONNECTION variable and corresponding
PROVIDER_TESTS_CONNECTION environment variable. Always rebuild test
assembly since we have no dependency check for sources in place.
Only add reference to Mono.Data on 1.1 profile. Added reference to
System.Configuration on 2.0 profile.
* sqlserver.config: Merged into app-*.config.
* odbc.config: Merged into app-*.config.
* System.Data.Connected.Tests.dll.sources: Added ConnectionConfig.cs,
EngineConfig.cs, EngineType.cs, ProviderTestsConfigurationHandler.cs
and DbDataReaderTest.cs. Removed OdbcConnectionStringBuilderTest.cs.
* ConnectionConfig.cs:  Holds information on a specific connection and
corresponding engine to test.
* EngineConfig.cs: Holds information on the capabilities and behavior
of an RDBMS engine.
* EngineType.cs: Defines different database engines supported by the
provider tests.
* ConnectionManager.cs: Use DbProviderFactory and DbConnection
on 2.0 profile. Added support for new Connection/Engine configuration.
* ProviderTestsConfigurationHandler.cs: IConfigurationSectionHandler
for the ProviderTests section.
* DataReaderTest.cs: Added tests that were previously part of
SqlClient tests but apply to all families. Improved existing
tests.
* DbDataReaderTest.cs: Added GetProviderSpecificValues error check
 tests.
* IDbCommandTest.cs: Added ExecuteNonQuery tests for empty CommandText.
Added test for bug #462947.
* OdbcCommandBuilderTest.cs: Improved GetDeleteCommand,
GetInsertCommand and GetUpdateCommand tests. Added QuotePrefix,
QuoteSuffix and QuoteIdentifier tests.
* OdbcCommandTest.cs: Improved existing tests. Added
ExecuteNonQuery and Dispose tests.
* OdbcConnectionStringBuilderTest.cs: Moved to System.Data
test suite.
* OdbcDataAdapterTest.cs: Removed extra whitespace.
* OdbcDataReaderTest.cs: Added GetBytes and GetSchemaTable
tests.
* OdbcParameterCollectionTest.cs: Improve existing tests.
* OdbcParameterTest.cs: Added tests for several data types.
* SqlCommandBuilderTest.cs: Improve Get*Command tests.
* SqlCommandTest.cs: Added test for bug #341743. Added test
for connection state after executing invalid SQL. Improved
stored procedure test to check behavior with and without
leading '@' for parameter names. Minor formatting changes.
* SqlConnectionTest.cs: Split up connection string errors
test.
* SqlDataReaderTest.cs: Improved GetInt64Test. Improved and
added GetBytes tests. Added GetSqlValues and HasRows tests.
Added GetSchemaTable test. Improved GetProviderSpecificFieldType
tests.
* SqlParameterTest.cs: Improved ParameterType test. Added
type inferrence tests.
* SqlTransactionTest.cs: Allow not working tests to run on MS.
* MySQL_5.sql: Added numeric and decimal colums with different
precision and scale. Added more rows to binary_family. Added
nchar and nvarchar columns to string_family, and added extra
data. Added time and date columns to datetime_family.
* sqlserver.sql: Added numeric and decimal colums with different
precision and scale. Added timestamp column and more rows to
binary_family. Added nchar and nvarchar columns to string_family,
and added extra data. Added sp_326182 stored procedure.
* sybase.sql: Added more rows to binary_family.

svn path=/trunk/mcs/; revision=122297
2008-12-31 15:35:07 +00:00
Gert Driesen 39a234d167 * SqlConnectionTest.cs: Improve Database test.
svn path=/trunk/mcs/; revision=122270
2008-12-30 21:24:56 +00:00
Gert Driesen f0571296c3 * DBConcurrencyException.cs: Marked .ctor taking DataRow [] as
internal so we can use it on the 1.0 profile (internally). Implemented
RowCount.
* System.Data_test.dll.sources: Added DBConcurrencyExceptionTest.cs.
* DBConcurrencyExceptionTest.cs: Added .ctor and Row(Count) tests.

svn path=/trunk/mcs/; revision=122263
2008-12-30 19:58:45 +00:00
Raja R Harinath a1cae67e2c Mildly rewrite duplicate-inferring logic.
* Index.cs (IndexDuplicateState): Remove.
(_hasDuplicates): Remove.  Replace by ...
(know_have_duplicates, know_no_duplicates): ... these.

svn path=/trunk/mcs/; revision=122242
2008-12-30 14:58:57 +00:00
Gert Driesen 021e47b486 * SqlXmlTest.cs: Minor improvements to tests. Marked tests as
NotWorking/NotDotNet to fix test failures on MS.

svn path=/trunk/mcs/; revision=122231
2008-12-30 10:29:34 +00:00
Gert Driesen dd1385a13b * DbCommandBuilder.cs: When CatalogSeparator or SchemaSeparator are
not set (or explicitly set to null or empty string), then return
default separator character. Added value check for CatalogLocation and
ConflictOption. Removed regions.
* DbCommandBuilderTest.cs: Added tests for properties.
* OdbcCommandBuilderTest.cs: Added tests for properties.

svn path=/trunk/mcs/; revision=122230
2008-12-30 10:21:41 +00:00
Gert Driesen fe34437ee6 * DbCommandBuilder.cs: Fixed default value for ConflicOption.
* OdbcCommandBuilder.cs: Added test for ConflictOption default value.

svn path=/trunk/mcs/; revision=122227
2008-12-30 05:11:15 +00:00
Gert Driesen b53afee2b9 * OdbcCommandTest.cs: Added test for bug #341743.
* OdbcColumn.cs: Treat OdbcType.Numeric as decimal.
* OdbcConnection.cs: Keep (weak) list of commands to allow us to
dispose them (and free their corresponding statement handles) when
the connection is closed. Fixed bug #341743.
* OdbcCommand.cs: Add internal Unlink method that is invoked when the
OdbcConnection is disposed, and which frees the statement handle.
Modified ExecuteNonQuery helper to take CommandBehavior and rename
freeHandle argument to createReader. Added CommandBehavior argument
to ExecSQL. Added FreeStatement overload that takes an option to not
perform an unlink. Fixes bug #3417434.

svn path=/trunk/mcs/; revision=122226
2008-12-30 04:33:40 +00:00
Gert Driesen b8ff346173 * DbCommandBuilder.cs: Return a zero-length string when QuotePrefix or
QuoteSuffix are not set (or are set to null). Changing QuotePrefix or
QuoteSuffix after a command has been generated should result in an
InvalidOperationException.
* DbConnectionStringBuilder.cs: Added support for ODBC rules. Major
rewrite fixing many compatibility issues, and improving support for
connectionstring formats/characters.
* System.Data_test.dll.sources: Added OdbcCommandBuilderTest.cs,
OdbcConnectionStringBuilderTest.cs and DbCommandBuilderTest.cs.
* libodbc.cs: Add IdentifierQuoteChar to OdbcInfo.
* OdbcCommandBuilder.cs: Return a zero-length string when QuotePrefix
or QuoteSuffix are not set (or are set to null). Changing QuotePrefix
or QuoteSuffix after a command has been generated should result in an
InvalidOperationException. Implemented support for obtaining
character(s) for quoting identifiers from specified connection.
Modified generated SQL to match MS.
* OdbcConnectionStringBuilder.cs: Improved special casing of Driver
and Dsn keywords. Re-use implemenation of DbConnectionStringBuilder.
Improved argument checks to match MS.
* DbCommandBuilderTest.cs: Added tests for QuotePrefix and
QuoteSuffix.
* DbConnectionStringBuilderTest.cs: Added tests for both odbc and
non-odbc rules.
* OdbcCommandBuilderTest.cs: Added tests for QuotePrefix and
QuoteSuffix. Added tests for QuoteIdentifier (some still marked
NotWorking).
* OdbcConnectionStringBuilderTest.cs: Moved from ProviderTests.
Added and improved tests.

svn path=/trunk/mcs/; revision=122225
2008-12-30 03:41:45 +00:00
Gert Driesen 9beafa005e * XmlDataDocumentTest.cs: Change spaces to tabs. Removed CWLs.
Restore original culture on teardown.

svn path=/trunk/mcs/; revision=122224
2008-12-30 02:40:56 +00:00
Gert Driesen 302207194d * SqlDecimalTest.cs
* SqlInt32Test.cs
* SqlCharsTest.cs
* SqlInt16Test.cs
* SqlInt64Test.cs
* SqlDoubleTest.cs: Change spaces to tabs, and remove extra tabs.
Restore original culture on teardown. Removed CWLs.

svn path=/trunk/mcs/; revision=122219
2008-12-30 02:22:07 +00:00
Gert Driesen 5f1f2dedb3 * SqlGuidTest.cs: Fixed line endings.
svn path=/trunk/mcs/; revision=122217
2008-12-30 01:44:43 +00:00
Gert Driesen b951709b43 * SqlStringTest.cs: Change spaces to tabs. Restore original culture
on teardown. Enable commented-out tests. Removed CWLs.

svn path=/trunk/mcs/; revision=122216
2008-12-30 01:41:46 +00:00
Gert Driesen ef3cae998a * BinarySerializationTest.cs: Change culture for culture-sensitive
tests.
* DataColumnTest2.cs: Change culture for culture-sensitive tests.

svn path=/trunk/mcs/; revision=122213
2008-12-30 00:55:01 +00:00
Gert Driesen 3b4f6b131c * DataTableTest.cs: Allow NFIFromBug55978 test to pass when MONO_PATH
is not set.

svn path=/trunk/mcs/; revision=122212
2008-12-30 00:52:51 +00:00
Gert Driesen 4aa2d9976e * SqlDbType: Added Date and Time (2.0 only).
svn path=/trunk/mcs/; revision=122209
2008-12-29 23:11:19 +00:00
Gonzalo Paniagua Javier 79db1be679 Use IndexOf (char)
svn path=/trunk/mcs/; revision=122122
2008-12-25 07:47:35 +00:00
Gonzalo Paniagua Javier 55bbc22620 Use IndexOf (char)
svn path=/trunk/mcs/; revision=122121
2008-12-25 07:46:26 +00:00
Veerapuram Varadhan 440b695312 * SqlXmlTest.cs: Available only in 2.0 and above
svn path=/trunk/mcs/; revision=122007
2008-12-22 20:48:01 +00:00
Ankit Jain 5f2e91b931 * System.Data_test.dll.sources: Fix typo in SqlXmlTest.cs
svn path=/trunk/mcs/; revision=121986
2008-12-22 13:49:54 +00:00
Veerapuram Varadhan 9276aac973 New SqlXmlTests
svn path=/trunk/mcs/; revision=121958
2008-12-21 03:36:34 +00:00
Veerapuram Varadhan a80d9ff2de Added new SqlXmlTest
svn path=/trunk/mcs/; revision=121957
2008-12-21 03:35:52 +00:00
Veerapuram Varadhan 0f66ecebd5 * SqlXml.cs (CreateReader): Better use
ConformanceLevel.Fragment while creating the reader as column
        values are not really Xml documents.  Also, throw
        SqlNullValueException when data is null.
        (.ctor): Take good care of empty XmlReaders.


svn path=/trunk/mcs/; revision=121956
2008-12-21 03:29:26 +00:00
Gonzalo Paniagua Javier 366a8838ab 2008-12-20 Gonzalo Paniagua Javier <[email protected]>
* SqlParameter.cs: I removed these 2 lines I added 2 patches ago in
	the previous patch...



svn path=/trunk/mcs/; revision=121937
2008-12-20 20:47:47 +00:00
Gonzalo Paniagua Javier 1bced9acdb 2008-12-20 Gonzalo Paniagua Javier <[email protected]>
* SqlConnection.cs: close the connection on error.


svn path=/trunk/mcs/; revision=121920
2008-12-20 08:53:16 +00:00
Gonzalo Paniagua Javier 8c8c3c6bec 2008-12-16 Gonzalo Paniagua Javier <[email protected]>
* SqlParameter.cs: don't allocate error strings until the error
	actually happens. Compare types instead of strings. Use a Hashtable
	for type mappings.


svn path=/trunk/mcs/; revision=121605
2008-12-16 15:43:29 +00:00
Gonzalo Paniagua Javier c8ebfe25f1 2008-12-12 Gonzalo Paniagua Javier <[email protected]>
* SqlParameter.cs: use the underlying type when inferring the type for
	enumerations.


svn path=/trunk/mcs/; revision=121485
2008-12-13 01:51:41 +00:00
Atsushi Eno 622852656f 2008-11-25 Atsushi Enomoto <[email protected]>
* DbDataRecord.cs : it is abstract, so create different impl. class.
	* DbEnumerator.cs : use above.


svn path=/trunk/mcs/; revision=119940
2008-11-25 10:32:45 +00:00
Raja R Harinath 54a3992ed3 Fix #420862
In class/System.Data/System.Data:
	* XmlConstants.cs (QnUnsignedShort): Rename from QnUsigned short
	and fix the value too.
	* XmlSchemaWriter.cs (XmlQualifiedName): Update to changes.

In class/System.Data/Test/System.Data:
	* DataSetTest.cs (Bug420862): New test.

svn path=/trunk/mcs/; revision=119197
2008-11-18 18:27:40 +00:00
Raja R Harinath 9d0c64bbfd Avoid allocating empty arrays.
* Index.cs (empty): New empty array constant.
(Reset): Initialize '_array' to 'empty'.
(RebuildIndex): Don't allocate array if it will be empty.
(FindAllIndexes): Use 'empty' instead of 'new int [0]'.

svn path=/trunk/mcs/; revision=119008
2008-11-17 12:30:45 +00:00