The problem already starts when creating the OperationDescription; we need
to also look at the End* method here to correctly parse the reply parameters.
Then ClientRuntimeChannel.Process needs to distinguish between sync/async
and copy the out/byref parameters when needed.
Fixes: http://bugzilla.xamarin.com/show_bug.cgi?id=1164
The breakage reported in #1164 was caused by commit 106fdeb4, which
fixed bxc206. The problem is that in fixing bxc206, response messages
of a type having a MessageContractAttribute custom attribute were
changed to have a `void` return type, according to the
MessageDescription's Body.ReturnValue.Type property.
This fix is correct, in that it's what .NET does, but it broke XML
deserialization which expected the "actual" return type to exist, not
`void`.
Case in point: the added IService1.EndJSMGetDatabases() method will
have a MessageDescription with a Body.ReturnValue.Type=typeof(void).
The problem is that deserializing this message will fail:
System.Runtime.Serialization.SerializationException: Deserializing
type 'System.Void'. Expecting state 'EndElement'. Encountered state
'Text' with name '' with namespace ''.
Obviously this is not good. ;-)
The fix is simple: don't use the MessageDescription's ReturnValue if
it's `typeof(void)`.
There are two added wrinkles:
1. Writing a test case for the above.
2. The test case broke with another error: a NRE within
BaseMessagesFormatter.MessageObjectToParts(). This is because
when ContractDescriptionGenerator.GetMessage() sets the
ReturnValue for a response message, it doesn't set
MessagePartDescription.MemberInfo.
BaseMessagesFormatter.MessageObjectToParts(), meanwhile, was
checking the ReturnValue's MemberInfo...which was null.
Add a null check here so that the actual bug can be tested.
It is part of bugfix 687902.
To get the bug fixed, the new "using" sections in ChannelDispatcher.cs to
explicitly dispose channels. But this causes regression in PerSession-based
tests. So some new session management code is (likely) required as well.
It will also alter "mixed" MaxConcurrentCalls and MaxConcurrentSessions with
correct management code.
XmlMessagesFormatter will be used in Sys.Xml.Serialization.dll and this
type should not be excluded by !NET_2_1 or !MOONLIGHT. It is not doable
if this class is in BaseMessagesFormatter.cs.
There were several issues here:
- The IChannelDispatcherBoundListener was defined twice, in two different namespaces, and it caused code in
ChannelDispatcher.Attach not to set its associated listener's ChannelDispatcher property to the correct value.
This, in turn, caused incorrect HttpListenerManagerTable operation, where it would put the "/js" and "/jsdebug"
dispatchers in separate HttpListenerManagers, instead of in the main (base) service's one.
- After fixing the above, it turned out that SvcHttpHandler selected the manager based on the host's base address,
when it should first try to find one whose URL matches the current request exactly.
The problem is that DispatchRuntime.Type is a service implementation type
that could implement two or more contract interfaces, and it was in random
order how ServiceProxyGenerator picks up the contract type. Now it looks
for correct contract type instead of the service type by exactly looking
for the target contract in the endpoint (dispatcher).
* InputOrReplyProcessor.cs : remove SecurityHandler. WS-Trust must
be handled before endpoint dispatching (it must not pass contract
filter) and doesn't make sense to be here.
* SecurityHandler.cs : move to old-code.
* SecurityReplyChannel.cs : handle WS-Trust message here.
* SecurityRequestContext.cs : so, do not pass those messages here.
* SslSecurityTokenAuthenticator.cs,
AuthenticatorCommunicationObject.cs,
SecureConversationSecurityTokenAuthenticator.cs :
add timeout argument to negotication requests.
* System.ServiceModel.dll.sources: remove SecurityHandler.cs
svn path=/trunk/mcs/; revision=160244
* ChannelDispatcher.cs : do not swallow exception during
RequestContext.get_RequestMessage() and thus return SOAP Fault for
MessageSecurityException to the client.
svn path=/trunk/mcs/; revision=160122
* HttpTransportBindingElement.cs :
Use new HTTP channel listener implementation.
* ChannelDispatcher.cs : enable service throttling again.
This time Http(Listener), ASP.NET and TCP listeners all work.
* System.ServiceModel.dll.sources :
add new HTTP channel listener implementation sources.
Old sources will be kept for a while, won't entirely vanish as
ASP.NET support will live there.
svn path=/trunk/mcs/; revision=159491
* ServiceHostBase.cs : Do not build more than one ChannelDispatcher
for a Binding. Then check duplicate listen URIs, excluding mex ones.
* ChannelDispatcher.cs : add simple bool field to mark for mex channel.
* ServiceMetadataExtension.cs : use simple ChannelDispatcher.IsMex field.
* ServiceHostTest.cs : improved endpoint tests and enabled them.
* ChannelDispatcherTest.cs : had to disable a test that regressed from
validating duplicate listen URI. Possible remedy is described too.
svn path=/trunk/mcs/; revision=159140